From mboxrd@z Thu Jan  1 00:00:00 1970
From: punit.agrawal@arm.com (Punit Agrawal)
Date: Tue, 25 Nov 2014 10:13:20 +0000
Subject: [PATCH v5 3/6] arm64: Add framework for legacy instruction
 emulation
In-Reply-To: <CAJKQeMZE_akWY39U3X3a1_-co3da2H03kUkOsZ_5CLrwMn-=wA@mail.gmail.com>
 (Greg Hackmann's message of "Mon, 24 Nov 2014 12:58:33 -0800")
References: <1416310887-14649-1-git-send-email-punit.agrawal@arm.com>
 <1416310887-14649-4-git-send-email-punit.agrawal@arm.com>
 <CAJKQeMZE_akWY39U3X3a1_-co3da2H03kUkOsZ_5CLrwMn-=wA@mail.gmail.com>
Message-ID: <9hhmw7f611b.fsf@e105922-lin.cambridge.arm.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Greg,

Greg Hackmann <ghackmann@google.com> writes:

> If it's not too late to chime in, I ran across one issue testing this
> patchset:

Sure. Thanks for taking the patches for a spin.

>
> On Tue, Nov 18, 2014 at 3:41 AM, Punit Agrawal <punit.agrawal@arm.com> wrote:
>> +       ret = update_insn_emulation_mode(insn, prev_mode);
>> +       if (!ret) {
>> +               /* Mode change failed, revert to previous mode. */
>> +               insn->current_mode = prev_mode;
>> +               update_insn_emulation_mode(insn, INSN_UNDEF);
>> +       }
>
> update_insn_emulation_mode() returns 0 on success, so the condition
> needs to be "if (ret)".  Otherwise writes to the sysctl file are
> immediately rolled back.

Dang! Missed this in the testing before posting. I'll co-ordinate with
Will to get the fix into next.

>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel