From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1962A606A31F for ; Fri, 23 Oct 2026 21:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=xLzHW9w/; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=Nh2aMrDs DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Cc:To:From:Subject:Message-ID:References:Mime-Version: In-Reply-To:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=37bgzHVD8y8sAVNI32vtF0/e4Mt+8V5lKNPa4buINEw=; b=xLzHW9w/6WJzfSxQ/FCu/gPsV9 du68INCUUDShzmbwbVEEZez6LuhEG2v+xV+o9mM2uJgE3vWP5dtyukpiEU8VKk7zNfLPBvdLAjCXW dUHe2weK3BxUG4iKBSIbcYgCk3R6HWDaHG2QI5NfiKoFPUzGwAhNFzQMMIa4tdvS+a9GCCyMD3tp/ ZJbQFEoBziWOl9hiyxG4xum3Th/LL3kxOxsFPdQKMZeLcVrI2qiOWAnSCYSIxkpcvam+9NkU16t4x od8MbB/2oiUr++SCNu8ra+ZfBObsDecvvMv3YywrKr6+Pj4N0Y1uptw6dM3Ymj0L4EsAJFmVXIn9d OR5WyqRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKNB8-0000000H0x1-24vR; Fri, 23 Oct 2026 21:52:00 +0000 Received: from mail-ed1-x547.google.com ([2a00:1450:4864:20::547]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xKNB5-0000000H0vu-17gY for linux-arm-kernel@lists.infradead.org; Fri, 23 Oct 2026 21:51:56 +0000 Received: by mail-ed1-x547.google.com with SMTP id 4fb4d7f45d1cf-6b1eeef39a0so1577344a12.0 for ; Fri, 23 Oct 2026 14:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792792313; x=1793397113; darn=lists.infradead.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=37bgzHVD8y8sAVNI32vtF0/e4Mt+8V5lKNPa4buINEw=; b=Nh2aMrDs0yIN/xHfXsgv2a4j87ed4shERz6SX93BvJ7xkyk/+JrP46/1e6CCCg2p1O S00z9fTqtQwlZ2NS5HWG/rRcivT7BmnZBemHzFlb8wdiJ7MvOWkmRs75H/v77Den6Tfb n2gBkIweKbSYXMG1eb+pSkIY3IsW4osFCTo3MirKDqOsUanjMrxuj/PgrAYa0aqKGBEE /ZPw73Mm/rOrX2f6B+Owvp4XKx/fP0Dv0Dfi5d5TgWOUsPd4HLkQkrUvBONMO8sc0t+/ 33IVq+tGovMIfFLBBqdIQQj7tt4dwYSqSWgNEKp7FVk/RjQHULoFbAVcueQTLFhVqKq/ leoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792792313; x=1793397113; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=37bgzHVD8y8sAVNI32vtF0/e4Mt+8V5lKNPa4buINEw=; b=bXOjRGAcgIaTnagtlGw/cYKaiHOiWVNcoUWJhmKLFf3u/uP5NjkH5RIX23izJuIss3 pi+KgheGsTTCTHEXYz7f4CWboUH80tnoAF5pFgt0MCTR5EPeZqQ7z/Tij11x0/tc7PKY Re62wOAJ9EQJ09w0hc7p9phv2DIdzGp8ehgaDhdIZLzXRCMp/O2LiOY3/4aQH5E1EMiL t2y2i/NbngYLpK40YToDUlU+bzuNOT/GVw/AudSSHVfBbSavgjDtE6XNI/L+b1avCpPR t66UfeL71CiET4XPEdnwEBXOPX2sUcS5J5fp8QO3ygMLLhvd+zDELdqd2/BsOQ1wbUNJ jt6w== X-Forwarded-Encrypted: i=1; AKwUvByInnn8Uaqc0mDVD5ZaoZQQbS8YFH3gOwxKp4SQJgqEvHpfcV5xfl3AFiGGMcO6QDnV0R+h6/A+Axf4Nudi7rNp@lists.infradead.org X-Gm-Message-State: AFq9FYJvysEvE2zj3AS0lMsFEZAp8Im6JbH22ahVj5MLTueXw4cJ9W2M 1kD4s0/mS5SPw9BEoyIKVMHtn52ZfHcPkX9ql0y0xD2JMo3UsszKb1fEgAuTcLb2ASn/VEClgF9 VlQ3tD6r5UvEXF+s6Cg== X-Received: from edve18.prod.google.com ([2002:a05:6402:1492:b0:6b3:c422:923c]) (user=tarunsahu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:5191:b0:6b1:b97b:744 with SMTP id 4fb4d7f45d1cf-6b442ff3810mr590380a12.32.1792792312470; Fri, 23 Oct 2026 14:51:52 -0700 (PDT) Date: Fri, 23 Oct 2026 21:51:51 +0000 In-Reply-To: X-Archived-By: Mime-Version: 1.0 References: <20261021152527.375070-1-tarunsahu@google.com> <20261021152527.375070-2-tarunsahu@google.com> <9huzik2u6hs5.fsf@tarunix.c.googlers.com> <9huzld7q4zjz.fsf@tarunix.c.googlers.com> Message-ID: <9huz33twf5l4.fsf@tarunix.c.googlers.com> Subject: Re: [RFC PATCH v2 1/4] liveupdate: Rename handler compatible to name From: tarunsahu@google.com To: Mike Rapoport Cc: Pasha Tatashin , Andrew Morton , joro@8bytes.org, Pratyush Yadav , maz@kernel.org, arnd@arndb.de, David Matlack , jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261023_145155_352901_D4E017D5 X-CRM114-Status: GOOD ( 24.81 ) X-Spam-Score: -9.5 (---------) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Mike Rapoport writes: > On Wed, Oct 21, 2026 at 07:35:28PM +0000, tarunsahu@google.com wrote: >> Pasha Tatashin writes: >> > On Wed, Oct 21, 2026 at 2:16=E2=80=AFPM wrote: >> >> Pasha Tatashin writes: >> >> >> >> > On Wed, Oct 21, 2026 at 11:25=E2=80=AFAM Tarun Sahu wrote: >> >> >> >> >> >> --- a/include/linux/kho/abi/luo.h >> >> >> @@ -84,18 +84,16 @@ struct luo_ser { >> >> >> u64 flbs_pa; >> >> >> } __packed; >> >> >> >> >> >> -#define LIVEUPDATE_HNDL_COMPAT_LENGTH 48 >> >> >> - >> >> >> /** >> >> >> * struct luo_file_ser - Represents the serialized preserves file= s. >> >> >> - * @compatible: File handler compatible string. >> >> >> + * @name: File handler name string. >> >> > >> >> > We are renaming from cpmaptible to name; I am not sure that is >> >> > necessary. We can still use compatible for the same purpose as name= . >> >> > Unless it really bothers people, but for me 'compatible' works just >> >> > the same. >> >> >> >> Yes it is necessary, For example if we have two handler for a single >> >> subsystem. We should refer it by handle this or handler that, not lik= e >> >> handler with compatible string this and handler with compatible strin= g >> >> that. >> > >> > I still feel like compatability makes more sense to me. Take an exampl= e: >> > >> > We have two file handlers for memfd (i.e., FH_OLD and FH_NEW): one has >> > compatibility =3D "memfd", and the other has compatibility =3D >> > "memfd_next_generation". The user chooses one of them to preserve the >> > memfd data, and the compatibility string is saved alongside the FD. >> > When the next kernel scans through the registered file handlers, it >> > must find exactly one that is compatible with the preserved data. >>=20 >> I will open this for vote. > > I'd rather won't ;-) > > "compatible" does not contradict more fine grained bitfields, and still h= as meaning. > Just like in FDT world from where we inherited it, it means "these ops ar= e > somewhat compatible with that serialized format, will check the details a= nd > will know for sure". > > And IMO we should keep it. > =20 > And please, trim your responses. I had to scroll 463 lines to see there's > nothing there. Okay. I will send the v3 soon with feature flags only. Also I will drop this and its next patch, as It will be part of other compatiblity series with exporting the schema to userspace so that userspace can make better decision in selecting the handler (As per the response from the other threa= d). ~Tarun > > --=20 > Sincerely yours, > Mike.