From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC417C05027 for ; Thu, 2 Feb 2023 09:53:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rLF5zHPXSUr9KMafHEDq1QYR3ZTS0uIH+X/FukQSzIs=; b=JXsDEAClEgGgxW ApPGNPr4V5y1l91hvc/poU/KMgLQ9RCd1bsxRVeXCqrrf2D7rJhUzuHj9ni7yGiS3yB+hOx63wRRh tWvZt+LSHZsWl+fOqAT829EbwiqhW4TQzMMrxqC7NDU7aHeZyFBTPORAkD3Z3IVhG9wcct58r6A/K PrmWgprq4DnICcY19rIZxwEjUxJqx9eJaxWH3uoBOpSiTAVtIf0T84Nd6C42dx5Al5aiJXKKrimBt BZTrsL9bWLrD1u8WIQ0LzW2vUcGNJ7loyMGqXejST68r240rslSgBqhuRU02mc4wl4AZgQdJQdee5 DsDPdcl/WDFqBMgVQ7MA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNWGQ-00FGGO-Nm; Thu, 02 Feb 2023 09:52:18 +0000 Received: from out-45.mta1.migadu.com ([2001:41d0:203:375::2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNWGL-00FGDg-PR for linux-arm-kernel@lists.infradead.org; Thu, 02 Feb 2023 09:52:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1675331528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LCBTDt5ICx8Mvi5W+/+gY2aaUdXSNOvE3rMuXJ+tKi8=; b=PhVeP3jDB1n3NatercWXmqIzxQrWiQ3p3vD33qp0f1yK20MLk9VJ8i4aPAYHHzqiiYURz+ 5PXAOZw2RCL4CtNccLoGB4shACHCh4IvceHoaFWCF/TfeMUtscf95Kh2MYVTkZXOjkms4a GQs7d3Qr1k4ffDwiAIiOtcdj3WyAvEY= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: [PATCH V2] arm64/mm: Intercept pfn changes in set_pte_at() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Thu, 2 Feb 2023 17:51:39 +0800 Cc: Will Deacon , Robin Murphy , Anshuman Khandual , linux-arm-kernel@lists.infradead.org, Mark Rutland , Andrew Morton , linux-kernel@vger.kernel.org, Mark Brown Message-Id: References: <20230109052816.405335-1-anshuman.khandual@arm.com> <20230126133321.GB29148@willie-the-truck> <20230131154950.GB2646@willie-the-truck> To: Catalin Marinas X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230202_015214_312200_548301D8 X-CRM114-Status: GOOD ( 22.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > On Feb 1, 2023, at 20:20, Catalin Marinas wrote: > > On Tue, Jan 31, 2023 at 03:49:51PM +0000, Will Deacon wrote: >> On Fri, Jan 27, 2023 at 12:43:17PM +0000, Robin Murphy wrote: >>> On 2023-01-26 13:33, Will Deacon wrote: >>>> On Tue, Jan 24, 2023 at 11:11:49AM +0530, Anshuman Khandual wrote: >>>>> On 1/9/23 10:58, Anshuman Khandual wrote: >>>>>> Changing pfn on a user page table mapped entry, without first going through >>>>>> break-before-make (BBM) procedure is unsafe. This just updates set_pte_at() >>>>>> to intercept such changes, via an updated pgattr_change_is_safe(). This new >>>>>> check happens via __check_racy_pte_update(), which has now been renamed as >>>>>> __check_safe_pte_update(). >>>>>> >>>>>> Cc: Catalin Marinas >>>>>> Cc: Will Deacon >>>>>> Cc: Mark Rutland >>>>>> Cc: Andrew Morton >>>>>> Cc: linux-arm-kernel@lists.infradead.org >>>>>> Cc: linux-kernel@vger.kernel.org >>>>>> Signed-off-by: Anshuman Khandual >>>>>> --- >>>>>> This applies on v6.2-rc3. This patch had some test time on an internal CI >>>>>> system without any issues being reported. >>>>> >>>>> Gentle ping, any updates on this patch ? Still any concerns ? >>>> >>>> I don't think we really got to the bottom of Mark's concerns with >>>> unreachable ptes on the stack, did we? I also have vague recollections >>>> of somebody (Robin?) running into issues with the vmap code not honouring >>>> BBM. >>> >>> Doesn't ring a bell, so either it wasn't me, or it was many years ago and >>> about 5 levels deep into trying to fix something else :/ >> >> Bah, sorry! Catalin reckons it may have been him talking about the vmemmap. > > Indeed. The discussion with Anshuman started from this thread: > > https://lore.kernel.org/all/20221025014215.3466904-1-mawupeng1@huawei.com/ > > We already trip over the existing checks even without Anshuman's patch, > though only by chance. We are not setting the software PTE_DIRTY on the > new pte (we don't bother with this bit for kernel mappings). > > Given that the vmemmap ptes are still live when such change happens and > no-one came with a solution to the break-before-make problem, I propose > we revert the arm64 part of commit 47010c040dec ("mm: hugetlb_vmemmap: > cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP*"). We just need this hunk: > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 27b2592698b0..5263454a5794 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -100,7 +100,6 @@ config ARM64 > select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT > select ARCH_WANT_FRAME_POINTERS > select ARCH_WANT_HUGE_PMD_SHARE if ARM64_4K_PAGES || (ARM64_16K_PAGES && !ARM64_VA_BITS_36) > - select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP Maybe it is a little overkill for HVO as it can significantly minimize the overhead of vmemmap on ARM64 servers for some workloads (like qemu, DPDK). So I don't think disabling it is a good approach. Indeed, HVO broke BBM, but the waring does not affect anything since the tail vmemmap pages are supposed to be read-only. So, I suggest skipping warnings if it is the vmemmap address in set_pte_at(). What do you think of? Muchun, Thanks. > select ARCH_WANT_LD_ORPHAN_WARN > select ARCH_WANTS_NO_INSTR > select ARCH_WANTS_THP_SWAP if ARM64_4K_PAGES > > -- > Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel