linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jean.pihet@newoldbits.com (Jean Pihet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] perf: add OMAP support for the new power events
Date: Thu, 10 Mar 2011 09:17:00 +0100	[thread overview]
Message-ID: <AANLkTi=4PXfF9upXi4hJ5unVyhWSzLBdejbitydy2vpn@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1103091759300.15132@utopia.booyaka.com>

Hi Paul,

On Thu, Mar 10, 2011 at 2:04 AM, Paul Walmsley <paul@pwsan.com> wrote:
> On Thu, 3 Mar 2011, Jean Pihet wrote:
>
>> The patch adds the new power management trace points for
>> the OMAP architecture.
>>
>> The trace points are for:
>> - default idle handler. Since the cpuidle framework is
>> ? instrumented in the generic way there is no need to
>> ? add trace points in the OMAP specific cpuidle handler;
>> - cpufreq (DVFS),
>> - SoC clocks changes (enable, disable, set_rate),
>> - power domain states: the desired target state and -if different-
>> ? the actually hit state.
>>
>> Because of the generic nature of the changes, OMAP3 and OMAP4 are supported.
>>
>> Tested on OMAP3 with suspend/resume, cpuidle, basic DVFS.
>>
>> Signed-off-by: Jean Pihet <j-pihet@ti.com>
>
> In terms of tracing powerdomain state changes, since OMAP powerdomains can
> potentially transition without the MPU knowing about it, some powerdomain
> transitions will be missed by these. ?(The software counters miss them
> too.) ?The only way to be certain about these is to watch the debug
> observability lines. ?Still, it is the rare board that brings out debobs
> lines. ?So this seems reasonable, as long as people don't expect 100%
> coverage.
OK that is correct. The events are tracing SW events only, i.e. a
trace is generated when a decision is made wrt next power states,
clock changes etc.
A remark: the OMAP4+ HW tracing modules do support the changes of
power domains states. There definitely is more to come on that topic!

Thanks for reviewing!
Jean

>
> For the clock and powerdomain changes,
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
>
>
> - Paul
>

      reply	other threads:[~2011-03-10  8:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18 18:10 [PATCH] perf: add OMAP support for the new power events jean.pihet at newoldbits.com
2011-02-18 18:21 ` Santosh Shilimkar
2011-02-19 18:55 ` Santosh Shilimkar
2011-02-21  8:44   ` Jean Pihet
2011-02-21  8:53     ` Santosh Shilimkar
2011-02-28 16:33       ` Jean Pihet
2011-03-03  0:43 ` Kevin Hilman
2011-03-03 10:25 ` Jean Pihet
2011-03-10  0:08   ` Kevin Hilman
2011-03-10  8:09     ` Jean Pihet
2011-03-10 18:15       ` Kevin Hilman
2011-03-10  1:04   ` Paul Walmsley
2011-03-10  8:17     ` Jean Pihet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=4PXfF9upXi4hJ5unVyhWSzLBdejbitydy2vpn@mail.gmail.com' \
    --to=jean.pihet@newoldbits.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).