From: martinwguy@gmail.com (Martin Guy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ep93xx: add /proc/cpuinfo extension
Date: Thu, 17 Mar 2011 04:30:19 +0100 [thread overview]
Message-ID: <AANLkTi=7hmWOFZFg_-zT3EO3uwzOXKkR+pCroc3UUTOV@mail.gmail.com> (raw)
In-Reply-To: <0D753D10438DA54287A00B02708426976368DDCD38@AUSP01VMBX24.collaborationhost.net>
Just spotted an off-by-one error in this patch, if of very minor and
unlikely effect.
On 22 March 2010 19:39, H Hartley Sweeten <hartleys@visionengravers.com> wrote:
> Add a callback to mach-ep93xx for the /proc/cpuinfo extension.
>
> This cpuinfo extension dumps the processor unique ID and Maverick
> Key as well as the processor silicon revision and a number of
> boot configuration options.
> ...
> diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
> index 90fb591..fe1eb7a 100644
> --- a/arch/arm/mach-ep93xx/core.c
> +++ b/arch/arm/mach-ep93xx/core.c
>...
> +static const char *ep93xx_rev[] = {
> + ? ? ? "A", "B", "C", "D0", "D1", "E0", "E1", "E2", "??"
> +};
>...
> + ? ? ? val = ep93xx_chip_revision();
> + ? ? ? if (val > ARRAY_SIZE(ep93xx_rev))
> + ? ? ? ? ? ? ? val = ARRAY_SIZE(ep93xx_rev) - 1;
> + ? ? ? seq_printf(m, "Silicon Rev\t: %s\n", ep93xx_rev[val]);
Shouldn't that be
+ if (val >= ARRAY_SIZE(ep93xx_rev))
?
M
?
next prev parent reply other threads:[~2011-03-17 3:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AcrJ7vBVySpZbSYBQ1eQDb/9VrGf4Q==>
2010-03-22 18:39 ` [PATCH 2/3] ep93xx: add /proc/cpuinfo extension H Hartley Sweeten
2010-03-23 15:35 ` Mika Westerberg
2010-03-23 16:34 ` H Hartley Sweeten
2010-03-23 16:49 ` Mika Westerberg
2010-03-23 16:45 ` H Hartley Sweeten
2011-03-17 3:30 ` Martin Guy [this message]
2011-03-17 16:15 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=7hmWOFZFg_-zT3EO3uwzOXKkR+pCroc3UUTOV@mail.gmail.com' \
--to=martinwguy@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).