From mboxrd@z Thu Jan 1 00:00:00 1970 From: catalin.marinas@arm.com (Catalin Marinas) Date: Mon, 15 Nov 2010 09:51:01 +0000 Subject: [PATCH v2 03/20] ARM: LPAE: use u32 instead of unsigned long for 32-bit ptes In-Reply-To: <201011151047.37103.arnd@arndb.de> References: <1289584840-18097-1-git-send-email-catalin.marinas@arm.com> <20101114151445.GB10871@n2100.arm.linux.org.uk> <201011151047.37103.arnd@arndb.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 15 November 2010 09:47, Arnd Bergmann wrote: > On Monday 15 November 2010 10:39:30 Catalin Marinas wrote: >> > There will be compiler warnings because u32 is unsigned int, and we >> > print it as %08lx. ?Generic code cases pte values to (long long) and >> > prints them using %08llx. ?We should do the same. >> >> We still need some kind of macro because with LPAE we need %016llx >> since the phys address can go to 40-bit and there are some additional >> bits in the top word. Unless you'd like to always print 16 characters >> even for 32-bit ptes (or if there is some other printk magic I'm not >> aware of). > > Why not just %010llx? That would just be two extra characters. We still have attributes (like XN, bit 54) stored in the top part of the pte. This may be of interest when debugging. -- Catalin