From: yong.shen@linaro.org (Yong Shen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3] support PMIC mc13892
Date: Thu, 9 Dec 2010 11:27:35 +0800 [thread overview]
Message-ID: <AANLkTi=NGBLLto3rKsReH8qQKdVpVhdym3spvaLxTuqU@mail.gmail.com> (raw)
In-Reply-To: <20101208171140.GS16418@rakim.wolfsonmicro.main>
On Thu, Dec 9, 2010 at 1:11 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Dec 08, 2010 at 03:26:16PM +0100, Arnaud Patard wrote:
>> >> > +#define MC13892_PWGT1SPI ? ? ? ?21
>> >> > +#define MC13892_PWGT2SPI ? ? ? ?22
>> >> > +#define MC13892_VCOINCELL ? ? ? 23
>
>> If we move this header into drivers/regulator, how are we supposed to
>> declared regulators in the machine file ?
>
> Oh, fail, yes - with this interface you do need to put the defines where
> the machine driver can see them.
>
Yes, that's the main reason for this. And besides that, there also
possibility for other mc13892 related drivers to use these
definitions, so it should be better in 'include/linux/mfd'.
Yong
next prev parent reply other threads:[~2010-12-09 3:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1291778460-22819-1-git-send-email-yong.shen@freescale.com>
2010-12-08 3:21 ` [PATCHv3] support PMIC mc13892 yong.shen at freescale.com
2010-12-08 3:28 ` Yong Shen
2010-12-08 8:52 ` Uwe Kleine-König
2010-12-08 9:02 ` Yong Shen
2010-12-08 12:54 ` Liam Girdwood
2010-12-09 5:13 ` Yong Shen
2010-12-09 9:21 ` Liam Girdwood
2010-12-09 9:42 ` Uwe Kleine-König
2010-12-09 22:33 ` Liam Girdwood
2010-12-08 9:12 ` Uwe Kleine-König
2010-12-08 9:51 ` Yong Shen
2010-12-08 10:01 ` Mark Brown
2010-12-08 10:55 ` Uwe Kleine-König
2010-12-08 14:26 ` Arnaud Patard (Rtp)
2010-12-08 17:11 ` Mark Brown
2010-12-09 3:27 ` Yong Shen [this message]
2010-12-08 9:25 ` Samuel Ortiz
2010-12-08 9:59 ` Yong Shen
2010-12-09 10:25 ` Sascha Hauer
2010-12-09 12:59 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=NGBLLto3rKsReH8qQKdVpVhdym3spvaLxTuqU@mail.gmail.com' \
--to=yong.shen@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).