* [PATCH 0/3] ARM: pxa168: Added Teton BGA Board Support
@ 2010-09-08 2:56 Mark F. Brown
2010-09-08 2:56 ` [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform Mark F. Brown
` (2 more replies)
0 siblings, 3 replies; 13+ messages in thread
From: Mark F. Brown @ 2010-09-08 2:56 UTC (permalink / raw)
To: linux-arm-kernel
1) Support for Teton BGA Board
2) Keypad support for Teton BGA
3) RTC support
Patched on top of Eric Miao's tree commit 5df3afbca20235ff8b3d33bd0d26a0d47b989a30
Mark F. Brown (3):
ARM: pxa168: added support for Teton BGA platform
ARM: pxa168/teton bga: added keypad support
ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
arch/arm/mach-mmp/Kconfig | 7 ++++
arch/arm/mach-mmp/Makefile | 1 +
arch/arm/mach-mmp/teton_bga.c | 81 +++++++++++++++++++++++++++++++++++++++++
3 files changed, 89 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/mach-mmp/teton_bga.c
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
2010-09-08 2:56 [PATCH 0/3] ARM: pxa168: Added Teton BGA Board Support Mark F. Brown
@ 2010-09-08 2:56 ` Mark F. Brown
2010-09-08 5:36 ` Haojian Zhuang
2010-09-08 15:51 ` Marek Vasut
2010-09-08 2:56 ` [PATCH 2/3] ARM: pxa168/teton bga: added keypad support Mark F. Brown
2010-09-08 2:56 ` [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337 Mark F. Brown
2 siblings, 2 replies; 13+ messages in thread
From: Mark F. Brown @ 2010-09-08 2:56 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
---
arch/arm/mach-mmp/Kconfig | 7 ++++++
arch/arm/mach-mmp/Makefile | 1 +
arch/arm/mach-mmp/teton_bga.c | 47 +++++++++++++++++++++++++++++++++++++++++
3 files changed, 55 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/mach-mmp/teton_bga.c
diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
index 6ab843e..0711d3b 100644
--- a/arch/arm/mach-mmp/Kconfig
+++ b/arch/arm/mach-mmp/Kconfig
@@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER
PXA910-based development board. Since MMP2 is compatible to
ARMv6 architecture.
+config MACH_TETON_BGA
+ bool "Marvell's PXA168 Teton BGA Development Board"
+ select CPU_PXA168
+ help
+ Say 'Y' here if you want to support the Marvell PXA168-based
+ Teton BGA Development Board.
+
endmenu
config CPU_PXA168
diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
index 8b66d06..751cdbf 100644
--- a/arch/arm/mach-mmp/Makefile
+++ b/arch/arm/mach-mmp/Makefile
@@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o
obj-$(CONFIG_MACH_TTC_DKB) += ttc_dkb.o
obj-$(CONFIG_MACH_FLINT) += flint.o
obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o
+obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o
diff --git a/arch/arm/mach-mmp/teton_bga.c b/arch/arm/mach-mmp/teton_bga.c
new file mode 100644
index 0000000..014cc37
--- /dev/null
+++ b/arch/arm/mach-mmp/teton_bga.c
@@ -0,0 +1,47 @@
+/*
+ * linux/arch/arm/mach-mmp/teton_bga.c
+ *
+ * Support for the Marvell PXA168 Teton BGA Development Platform.
+ *
+ * This code is based on aspenite.c
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * publishhed by the Free Software Foundation.
+ */
+
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/platform_device.h>
+
+#include <asm/mach-types.h>
+#include <asm/mach/arch.h>
+#include <mach/addr-map.h>
+#include <mach/mfp-pxa168.h>
+#include <mach/pxa168.h>
+#include <mach/gpio.h>
+
+#include "common.h"
+
+static unsigned long teton_bga_pin_config[] __initdata = {
+ /* UART1 */
+ GPIO107_UART1_TXD,
+ GPIO108_UART1_RXD,
+};
+
+static void __init teton_bga_init(void)
+{
+ mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
+
+ /* on-chip devices */
+ pxa168_add_uart(1);
+}
+
+MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
+ .phys_io = APB_PHYS_BASE,
+ .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc,
+ .map_io = mmp_map_io,
+ .init_irq = pxa168_init_irq,
+ .timer = &pxa168_timer,
+ .init_machine = teton_bga_init,
+MACHINE_END
--
1.7.0.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/3] ARM: pxa168/teton bga: added keypad support
2010-09-08 2:56 [PATCH 0/3] ARM: pxa168: Added Teton BGA Board Support Mark F. Brown
2010-09-08 2:56 ` [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform Mark F. Brown
@ 2010-09-08 2:56 ` Mark F. Brown
2010-09-08 2:56 ` [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337 Mark F. Brown
2 siblings, 0 replies; 13+ messages in thread
From: Mark F. Brown @ 2010-09-08 2:56 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
---
arch/arm/mach-mmp/teton_bga.c | 24 ++++++++++++++++++++++++
1 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mmp/teton_bga.c b/arch/arm/mach-mmp/teton_bga.c
index 014cc37..bbeda5c 100644
--- a/arch/arm/mach-mmp/teton_bga.c
+++ b/arch/arm/mach-mmp/teton_bga.c
@@ -20,6 +20,8 @@
#include <mach/mfp-pxa168.h>
#include <mach/pxa168.h>
#include <mach/gpio.h>
+#include <linux/input.h>
+#include <plat/pxa27x_keypad.h>
#include "common.h"
@@ -27,6 +29,27 @@ static unsigned long teton_bga_pin_config[] __initdata = {
/* UART1 */
GPIO107_UART1_TXD,
GPIO108_UART1_RXD,
+
+ /* Keypad */
+ GPIO109_KP_MKIN1,
+ GPIO110_KP_MKIN0,
+ GPIO111_KP_MKOUT7,
+ GPIO112_KP_MKOUT6,
+};
+
+static unsigned int teton_bga_matrix_key_map[] = {
+ KEY(0, 6, KEY_ESC),
+ KEY(0, 7, KEY_ENTER),
+ KEY(1, 6, KEY_LEFT),
+ KEY(1, 7, KEY_RIGHT),
+};
+
+static struct pxa27x_keypad_platform_data teton_bga_keypad_info __initdata = {
+ .matrix_key_rows = 2,
+ .matrix_key_cols = 8,
+ .matrix_key_map = teton_bga_matrix_key_map,
+ .matrix_key_map_size = ARRAY_SIZE(teton_bga_matrix_key_map),
+ .debounce_interval = 30,
};
static void __init teton_bga_init(void)
@@ -35,6 +58,7 @@ static void __init teton_bga_init(void)
/* on-chip devices */
pxa168_add_uart(1);
+ pxa168_add_keypad(&teton_bga_keypad_info);
}
MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
--
1.7.0.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
2010-09-08 2:56 [PATCH 0/3] ARM: pxa168: Added Teton BGA Board Support Mark F. Brown
2010-09-08 2:56 ` [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform Mark F. Brown
2010-09-08 2:56 ` [PATCH 2/3] ARM: pxa168/teton bga: added keypad support Mark F. Brown
@ 2010-09-08 2:56 ` Mark F. Brown
2010-09-08 5:34 ` Haojian Zhuang
2 siblings, 1 reply; 13+ messages in thread
From: Mark F. Brown @ 2010-09-08 2:56 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
---
arch/arm/mach-mmp/teton_bga.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mmp/teton_bga.c b/arch/arm/mach-mmp/teton_bga.c
index bbeda5c..8e5801c 100644
--- a/arch/arm/mach-mmp/teton_bga.c
+++ b/arch/arm/mach-mmp/teton_bga.c
@@ -22,6 +22,7 @@
#include <mach/gpio.h>
#include <linux/input.h>
#include <plat/pxa27x_keypad.h>
+#include <linux/i2c.h>
#include "common.h"
@@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[] __initdata = {
GPIO110_KP_MKIN0,
GPIO111_KP_MKOUT7,
GPIO112_KP_MKOUT6,
+
+ /* i2c bus */
+ GPIO105_CI2C_SDA,
+ GPIO106_CI2C_SCL,
};
static unsigned int teton_bga_matrix_key_map[] = {
@@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data teton_bga_keypad_info __initdata = {
.debounce_interval = 30,
};
+static struct i2c_board_info teton_bga_i2c_info[] __initdata = {
+ { I2C_BOARD_INFO("ds1337", 0x68), },
+};
+
static void __init teton_bga_init(void)
{
mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
@@ -59,6 +68,7 @@ static void __init teton_bga_init(void)
/* on-chip devices */
pxa168_add_uart(1);
pxa168_add_keypad(&teton_bga_keypad_info);
+ pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(teton_bga_i2c_info));
}
MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
--
1.7.0.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
2010-09-08 2:56 ` [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337 Mark F. Brown
@ 2010-09-08 5:34 ` Haojian Zhuang
2010-09-08 15:54 ` Marek Vasut
0 siblings, 1 reply; 13+ messages in thread
From: Haojian Zhuang @ 2010-09-08 5:34 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 8, 2010 at 10:56 AM, Mark F. Brown <mark.brown314@gmail.com> wrote:
> Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
> ---
> ?arch/arm/mach-mmp/teton_bga.c | ? 10 ++++++++++
> ?1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-mmp/teton_bga.c b/arch/arm/mach-mmp/teton_bga.c
> index bbeda5c..8e5801c 100644
> --- a/arch/arm/mach-mmp/teton_bga.c
> +++ b/arch/arm/mach-mmp/teton_bga.c
> @@ -22,6 +22,7 @@
> ?#include <mach/gpio.h>
> ?#include <linux/input.h>
> ?#include <plat/pxa27x_keypad.h>
> +#include <linux/i2c.h>
>
> ?#include "common.h"
>
> @@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[] __initdata = {
> ? ? ? ?GPIO110_KP_MKIN0,
> ? ? ? ?GPIO111_KP_MKOUT7,
> ? ? ? ?GPIO112_KP_MKOUT6,
> +
> + ? ? ? /* i2c bus */
> + ? ? ? GPIO105_CI2C_SDA,
> + ? ? ? GPIO106_CI2C_SCL,
> ?};
>
> ?static unsigned int teton_bga_matrix_key_map[] = {
> @@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data teton_bga_keypad_info __initdata = {
> ? ? ? ?.debounce_interval ? ? ?= 30,
> ?};
>
> +static struct i2c_board_info teton_bga_i2c_info[] __initdata = {
> + ? ? ? { I2C_BOARD_INFO("ds1337", 0x68), },
> +};
> +
I don't have the schematic of teton. But RTC chips should always has
an irq pin. Is it also connected in your platform?
> ?static void __init teton_bga_init(void)
> ?{
> ? ? ? ?mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
> @@ -59,6 +68,7 @@ static void __init teton_bga_init(void)
> ? ? ? ?/* on-chip devices */
> ? ? ? ?pxa168_add_uart(1);
> ? ? ? ?pxa168_add_keypad(&teton_bga_keypad_info);
> + ? ? ? pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(teton_bga_i2c_info));
> ?}
>
> ?MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at ?http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
2010-09-08 2:56 ` [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform Mark F. Brown
@ 2010-09-08 5:36 ` Haojian Zhuang
2010-09-08 15:51 ` Marek Vasut
1 sibling, 0 replies; 13+ messages in thread
From: Haojian Zhuang @ 2010-09-08 5:36 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 8, 2010 at 10:56 AM, Mark F. Brown <mark.brown314@gmail.com> wrote:
> Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
> ---
> ?arch/arm/mach-mmp/Kconfig ? ? | ? ?7 ++++++
> ?arch/arm/mach-mmp/Makefile ? ?| ? ?1 +
> ?arch/arm/mach-mmp/teton_bga.c | ? 47 +++++++++++++++++++++++++++++++++++++++++
> ?3 files changed, 55 insertions(+), 0 deletions(-)
> ?create mode 100644 arch/arm/mach-mmp/teton_bga.c
>
> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
> index 6ab843e..0711d3b 100644
> --- a/arch/arm/mach-mmp/Kconfig
> +++ b/arch/arm/mach-mmp/Kconfig
> @@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER
> ? ? ? ? ?PXA910-based development board. Since MMP2 is compatible to
> ? ? ? ? ?ARMv6 architecture.
>
> +config MACH_TETON_BGA
> + ? ? ? bool "Marvell's PXA168 Teton BGA Development Board"
> + ? ? ? select CPU_PXA168
> + ? ? ? help
> + ? ? ? ? Say 'Y' here if you want to support the Marvell PXA168-based
> + ? ? ? ? Teton BGA Development Board.
> +
> ?endmenu
>
> ?config CPU_PXA168
> diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
> index 8b66d06..751cdbf 100644
> --- a/arch/arm/mach-mmp/Makefile
> +++ b/arch/arm/mach-mmp/Makefile
> @@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) ? += tavorevb.o
> ?obj-$(CONFIG_MACH_TTC_DKB) ? ? += ttc_dkb.o
> ?obj-$(CONFIG_MACH_FLINT) ? ? ? += flint.o
> ?obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o
> +obj-$(CONFIG_MACH_TETON_BGA) ? += teton_bga.o
> diff --git a/arch/arm/mach-mmp/teton_bga.c b/arch/arm/mach-mmp/teton_bga.c
> new file mode 100644
> index 0000000..014cc37
> --- /dev/null
> +++ b/arch/arm/mach-mmp/teton_bga.c
> @@ -0,0 +1,47 @@
> +/*
> + * ?linux/arch/arm/mach-mmp/teton_bga.c
> + *
> + * ?Support for the Marvell PXA168 Teton BGA Development Platform.
> + *
> + * ?This code is based on aspenite.c
> + *
> + * ?This program is free software; you can redistribute it and/or modify
> + * ?it under the terms of the GNU General Public License version 2 as
> + * ?publishhed by the Free Software Foundation.
> + */
> +
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/platform_device.h>
> +
> +#include <asm/mach-types.h>
> +#include <asm/mach/arch.h>
> +#include <mach/addr-map.h>
> +#include <mach/mfp-pxa168.h>
> +#include <mach/pxa168.h>
> +#include <mach/gpio.h>
> +
> +#include "common.h"
> +
> +static unsigned long teton_bga_pin_config[] __initdata = {
> + ? ? ? /* UART1 */
> + ? ? ? GPIO107_UART1_TXD,
> + ? ? ? GPIO108_UART1_RXD,
> +};
> +
> +static void __init teton_bga_init(void)
> +{
> + ? ? ? mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
> +
> + ? ? ? /* on-chip devices */
> + ? ? ? pxa168_add_uart(1);
> +}
> +
> +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
> + ? ? ? .phys_io ? ? ? ?= APB_PHYS_BASE,
> + ? ? ? .io_pg_offst ? ?= (APB_VIRT_BASE >> 18) & 0xfffc,
> + ? ? ? .map_io ? ? ? ? = mmp_map_io,
> + ? ? ? .init_irq ? ? ? = pxa168_init_irq,
> + ? ? ? .timer ? ? ? ? ?= &pxa168_timer,
> + ? ? ? .init_machine ? = teton_bga_init,
> +MACHINE_END
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at ?http://www.tux.org/lkml/
>
Acked
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
2010-09-08 2:56 ` [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform Mark F. Brown
2010-09-08 5:36 ` Haojian Zhuang
@ 2010-09-08 15:51 ` Marek Vasut
2010-09-08 23:42 ` Mark F. Brown
1 sibling, 1 reply; 13+ messages in thread
From: Marek Vasut @ 2010-09-08 15:51 UTC (permalink / raw)
To: linux-arm-kernel
Dne St 8. z??? 2010 04:56:45 Mark F. Brown napsal(a):
---------------------------
Description is missing here
---------------------------
> Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
> ---
> arch/arm/mach-mmp/Kconfig | 7 ++++++
> arch/arm/mach-mmp/Makefile | 1 +
> arch/arm/mach-mmp/teton_bga.c | 47
> +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55
> insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/mach-mmp/teton_bga.c
>
> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
> index 6ab843e..0711d3b 100644
> --- a/arch/arm/mach-mmp/Kconfig
> +++ b/arch/arm/mach-mmp/Kconfig
> @@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER
> PXA910-based development board. Since MMP2 is compatible to
> ARMv6 architecture.
>
> +config MACH_TETON_BGA
> + bool "Marvell's PXA168 Teton BGA Development Board"
> + select CPU_PXA168
> + help
> + Say 'Y' here if you want to support the Marvell PXA168-based
> + Teton BGA Development Board.
> +
> endmenu
>
> config CPU_PXA168
> diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
> index 8b66d06..751cdbf 100644
> --- a/arch/arm/mach-mmp/Makefile
> +++ b/arch/arm/mach-mmp/Makefile
> @@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o
> obj-$(CONFIG_MACH_TTC_DKB) += ttc_dkb.o
> obj-$(CONFIG_MACH_FLINT) += flint.o
> obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o
> +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o
> diff --git a/arch/arm/mach-mmp/teton_bga.c b/arch/arm/mach-mmp/teton_bga.c
> new file mode 100644
> index 0000000..014cc37
> --- /dev/null
> +++ b/arch/arm/mach-mmp/teton_bga.c
> @@ -0,0 +1,47 @@
> +/*
> + * linux/arch/arm/mach-mmp/teton_bga.c
> + *
> + * Support for the Marvell PXA168 Teton BGA Development Platform.
Authoring information of this file are missing. Also, MAINTAINERS entry is
missing.
> + *
> + * This code is based on aspenite.c
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * publishhed by the Free Software Foundation.
> + */
> +
> +#include <linux/init.h>
> +#include <linux/kernel.h>
> +#include <linux/platform_device.h>
> +
> +#include <asm/mach-types.h>
> +#include <asm/mach/arch.h>
> +#include <mach/addr-map.h>
> +#include <mach/mfp-pxa168.h>
> +#include <mach/pxa168.h>
> +#include <mach/gpio.h>
use ... #include <linux/gpio.h>
> +
> +#include "common.h"
> +
> +static unsigned long teton_bga_pin_config[] __initdata = {
> + /* UART1 */
> + GPIO107_UART1_TXD,
> + GPIO108_UART1_RXD,
> +};
> +
> +static void __init teton_bga_init(void)
> +{
> + mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
> +
> + /* on-chip devices */
> + pxa168_add_uart(1);
Don't we have enum for these magic numbers on pxa168 ?
> +}
> +
> +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
> + .phys_io = APB_PHYS_BASE,
> + .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc,
> + .map_io = mmp_map_io,
> + .init_irq = pxa168_init_irq,
> + .timer = &pxa168_timer,
> + .init_machine = teton_bga_init,
> +MACHINE_END
Cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
2010-09-08 5:34 ` Haojian Zhuang
@ 2010-09-08 15:54 ` Marek Vasut
[not found] ` <AANLkTinGE=wxCcnSBiZQFeJxDG21DMd6KEcckavVuTbE@mail.gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: Marek Vasut @ 2010-09-08 15:54 UTC (permalink / raw)
To: linux-arm-kernel
Dne St 8. z??? 2010 07:34:24 Haojian Zhuang napsal(a):
> On Wed, Sep 8, 2010 at 10:56 AM, Mark F. Brown <mark.brown314@gmail.com>
wrote:
> > Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
> > ---
> > arch/arm/mach-mmp/teton_bga.c | 10 ++++++++++
> > 1 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-mmp/teton_bga.c
> > b/arch/arm/mach-mmp/teton_bga.c index bbeda5c..8e5801c 100644
> > --- a/arch/arm/mach-mmp/teton_bga.c
> > +++ b/arch/arm/mach-mmp/teton_bga.c
> > @@ -22,6 +22,7 @@
> > #include <mach/gpio.h>
> > #include <linux/input.h>
> > #include <plat/pxa27x_keypad.h>
> > +#include <linux/i2c.h>
> >
> > #include "common.h"
> >
> > @@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[] __initdata
> > = { GPIO110_KP_MKIN0,
> > GPIO111_KP_MKOUT7,
> > GPIO112_KP_MKOUT6,
> > +
> > + /* i2c bus */
> > + GPIO105_CI2C_SDA,
> > + GPIO106_CI2C_SCL,
> > };
> >
> > static unsigned int teton_bga_matrix_key_map[] = {
> > @@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data
> > teton_bga_keypad_info __initdata = { .debounce_interval = 30,
> > };
> >
> > +static struct i2c_board_info teton_bga_i2c_info[] __initdata = {
> > + { I2C_BOARD_INFO("ds1337", 0x68), },
> > +};
> > +
>
> I don't have the schematic of teton. But RTC chips should always has
> an irq pin. Is it also connected in your platform?
I think this one doesn't, but I haven't checked.
Cheers
>
> > static void __init teton_bga_init(void)
> > {
> > mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
> > @@ -59,6 +68,7 @@ static void __init teton_bga_init(void)
> > /* on-chip devices */
> > pxa168_add_uart(1);
> > pxa168_add_keypad(&teton_bga_keypad_info);
> > + pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(teton_bga_i2c_info));
> > }
> >
> > MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
> > --
> > 1.7.0.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> > in the body of a message to majordomo at vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337
[not found] ` <AANLkTinGE=wxCcnSBiZQFeJxDG21DMd6KEcckavVuTbE@mail.gmail.com>
@ 2010-09-08 21:09 ` Marek Vasut
0 siblings, 0 replies; 13+ messages in thread
From: Marek Vasut @ 2010-09-08 21:09 UTC (permalink / raw)
To: linux-arm-kernel
Dne St 8. z??? 2010 19:05:02 Mark F. Brown napsal(a):
> On Wed, Sep 8, 2010 at 11:54 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > Dne St 8. z??? 2010 07:34:24 Haojian Zhuang napsal(a):
> >> On Wed, Sep 8, 2010 at 10:56 AM, Mark F. Brown <mark.brown314@gmail.com>
> >
> > wrote:
> >> > Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
> >> > ---
> >> > arch/arm/mach-mmp/teton_bga.c | 10 ++++++++++
> >> > 1 files changed, 10 insertions(+), 0 deletions(-)
> >> >
> >> > diff --git a/arch/arm/mach-mmp/teton_bga.c
> >> > b/arch/arm/mach-mmp/teton_bga.c index bbeda5c..8e5801c 100644
> >> > --- a/arch/arm/mach-mmp/teton_bga.c
> >> > +++ b/arch/arm/mach-mmp/teton_bga.c
> >> > @@ -22,6 +22,7 @@
> >> > #include <mach/gpio.h>
> >> > #include <linux/input.h>
> >> > #include <plat/pxa27x_keypad.h>
> >> > +#include <linux/i2c.h>
> >> >
> >> > #include "common.h"
> >> >
> >> > @@ -35,6 +36,10 @@ static unsigned long teton_bga_pin_config[]
> >> > __initdata = { GPIO110_KP_MKIN0,
> >> > GPIO111_KP_MKOUT7,
> >> > GPIO112_KP_MKOUT6,
> >> > +
> >> > + /* i2c bus */
> >> > + GPIO105_CI2C_SDA,
> >> > + GPIO106_CI2C_SCL,
> >> > };
> >> >
> >> > static unsigned int teton_bga_matrix_key_map[] = {
> >> > @@ -52,6 +57,10 @@ static struct pxa27x_keypad_platform_data
> >> > teton_bga_keypad_info __initdata = { .debounce_interval = 30,
> >> > };
> >> >
> >> > +static struct i2c_board_info teton_bga_i2c_info[] __initdata = {
> >> > + { I2C_BOARD_INFO("ds1337", 0x68), },
> >> > +};
> >> > +
> >>
> >> I don't have the schematic of teton. But RTC chips should always has
> >> an irq pin. Is it also connected in your platform?
> >
> > I think this one doesn't, but I haven't checked.
> >
> > Cheers
> >
> >> > static void __init teton_bga_init(void)
> >> > {
> >> > mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
> >> > @@ -59,6 +68,7 @@ static void __init teton_bga_init(void)
> >> > /* on-chip devices */
> >> > pxa168_add_uart(1);
> >> > pxa168_add_keypad(&teton_bga_keypad_info);
> >> > + pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(teton_bga_i2c_info));
> >> > }
> >> >
> >> > MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development
> >> > Platform") --
> >> > 1.7.0.4
> >> >
> >> > --
> >> > To unsubscribe from this list: send the line "unsubscribe
> >> > linux-kernel" in the body of a message to majordomo at vger.kernel.org
> >> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >> > Please read the FAQ at http://www.tux.org/lkml/
> >>
> >> _______________________________________________
> >> linux-arm-kernel mailing list
> >> linux-arm-kernel at lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> It actually does have an alarm pin and it is connected as well. I did
> not include it, because I have not tested the alarm functionality yet.
> I was going to add it in a later patch. I did test the hardware clock
> to system clock syncing.
Fix the CC please. And be careful not to screw this up again next time.
Please add the alarm pin too. Thanks
Cheers
>
> Regards,
> -- Mark
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
2010-09-08 15:51 ` Marek Vasut
@ 2010-09-08 23:42 ` Mark F. Brown
2010-09-09 1:21 ` Marek Vasut
0 siblings, 1 reply; 13+ messages in thread
From: Mark F. Brown @ 2010-09-08 23:42 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 8, 2010 at 11:51 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Dne St 8. z??? 2010 04:56:45 Mark F. Brown napsal(a):
>
> ---------------------------
> Description is missing here
> ---------------------------
>
>> Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
>> ---
>> ?arch/arm/mach-mmp/Kconfig ? ? | ? ?7 ++++++
>> ?arch/arm/mach-mmp/Makefile ? ?| ? ?1 +
>> ?arch/arm/mach-mmp/teton_bga.c | ? 47
>> +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55
>> insertions(+), 0 deletions(-)
>> ?create mode 100644 arch/arm/mach-mmp/teton_bga.c
>>
>> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
>> index 6ab843e..0711d3b 100644
>> --- a/arch/arm/mach-mmp/Kconfig
>> +++ b/arch/arm/mach-mmp/Kconfig
>> @@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER
>> ? ? ? ? PXA910-based development board. Since MMP2 is compatible to
>> ? ? ? ? ARMv6 architecture.
>>
>> +config MACH_TETON_BGA
>> + ? ? bool "Marvell's PXA168 Teton BGA Development Board"
>> + ? ? select CPU_PXA168
>> + ? ? help
>> + ? ? ? Say 'Y' here if you want to support the Marvell PXA168-based
>> + ? ? ? Teton BGA Development Board.
>> +
>> ?endmenu
>>
>> ?config CPU_PXA168
>> diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
>> index 8b66d06..751cdbf 100644
>> --- a/arch/arm/mach-mmp/Makefile
>> +++ b/arch/arm/mach-mmp/Makefile
>> @@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o
>> ?obj-$(CONFIG_MACH_TTC_DKB) ? += ttc_dkb.o
>> ?obj-$(CONFIG_MACH_FLINT) ? ? += flint.o
>> ?obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o
>> +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o
>> diff --git a/arch/arm/mach-mmp/teton_bga.c b/arch/arm/mach-mmp/teton_bga.c
>> new file mode 100644
>> index 0000000..014cc37
>> --- /dev/null
>> +++ b/arch/arm/mach-mmp/teton_bga.c
>> @@ -0,0 +1,47 @@
>> +/*
>> + * ?linux/arch/arm/mach-mmp/teton_bga.c
>> + *
>> + * ?Support for the Marvell PXA168 Teton BGA Development Platform.
>
> Authoring information of this file are missing. Also, MAINTAINERS entry is
> missing.
>> + *
>> + * ?This code is based on aspenite.c
>> + *
>> + * ?This program is free software; you can redistribute it and/or modify
>> + * ?it under the terms of the GNU General Public License version 2 as
>> + * ?publishhed by the Free Software Foundation.
>> + */
>> +
>> +#include <linux/init.h>
>> +#include <linux/kernel.h>
>> +#include <linux/platform_device.h>
>> +
>> +#include <asm/mach-types.h>
>> +#include <asm/mach/arch.h>
>> +#include <mach/addr-map.h>
>> +#include <mach/mfp-pxa168.h>
>> +#include <mach/pxa168.h>
>> +#include <mach/gpio.h>
>
> use ... #include <linux/gpio.h>
>
>> +
>> +#include "common.h"
>> +
>> +static unsigned long teton_bga_pin_config[] __initdata = {
>> + ? ? /* UART1 */
>> + ? ? GPIO107_UART1_TXD,
>> + ? ? GPIO108_UART1_RXD,
>> +};
>> +
>> +static void __init teton_bga_init(void)
>> +{
>> + ? ? mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
>> +
>> + ? ? /* on-chip devices */
>> + ? ? pxa168_add_uart(1);
>
> Don't we have enum for these magic numbers on pxa168 ?
>> +}
>> +
>> +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
>> + ? ? .phys_io ? ? ? ?= APB_PHYS_BASE,
>> + ? ? .io_pg_offst ? ?= (APB_VIRT_BASE >> 18) & 0xfffc,
>> + ? ? .map_io ? ? ? ? = mmp_map_io,
>> + ? ? .init_irq ? ? ? = pxa168_init_irq,
>> + ? ? .timer ? ? ? ? ?= &pxa168_timer,
>> + ? ? .init_machine ? = teton_bga_init,
>> +MACHINE_END
>
> Cheers
>
I am assuming you mean the magic number for .io_pg_offst:
.io_pg_offst ? ?= (APB_VIRT_BASE >> 18) & 0xfffc,
It seems all of the other platforms in arch/arm are configuring it
this way. Do you really want me to change this?
Regards,
-- Mark
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
2010-09-08 23:42 ` Mark F. Brown
@ 2010-09-09 1:21 ` Marek Vasut
2010-09-09 7:39 ` Eric Miao
0 siblings, 1 reply; 13+ messages in thread
From: Marek Vasut @ 2010-09-09 1:21 UTC (permalink / raw)
To: linux-arm-kernel
Dne ?t 9. z??? 2010 01:42:36 Mark F. Brown napsal(a):
> On Wed, Sep 8, 2010 at 11:51 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > Dne St 8. z??? 2010 04:56:45 Mark F. Brown napsal(a):
> >
> > ---------------------------
> > Description is missing here
> > ---------------------------
> >
> >> Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
> >> ---
> >> arch/arm/mach-mmp/Kconfig | 7 ++++++
> >> arch/arm/mach-mmp/Makefile | 1 +
> >> arch/arm/mach-mmp/teton_bga.c | 47
> >> +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55
> >> insertions(+), 0 deletions(-)
> >> create mode 100644 arch/arm/mach-mmp/teton_bga.c
> >>
> >> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
> >> index 6ab843e..0711d3b 100644
> >> --- a/arch/arm/mach-mmp/Kconfig
> >> +++ b/arch/arm/mach-mmp/Kconfig
> >> @@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER
> >> PXA910-based development board. Since MMP2 is compatible to
> >> ARMv6 architecture.
> >>
> >> +config MACH_TETON_BGA
> >> + bool "Marvell's PXA168 Teton BGA Development Board"
> >> + select CPU_PXA168
> >> + help
> >> + Say 'Y' here if you want to support the Marvell PXA168-based
> >> + Teton BGA Development Board.
> >> +
> >> endmenu
> >>
> >> config CPU_PXA168
> >> diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
> >> index 8b66d06..751cdbf 100644
> >> --- a/arch/arm/mach-mmp/Makefile
> >> +++ b/arch/arm/mach-mmp/Makefile
> >> @@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o
> >> obj-$(CONFIG_MACH_TTC_DKB) += ttc_dkb.o
> >> obj-$(CONFIG_MACH_FLINT) += flint.o
> >> obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o
> >> +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o
> >> diff --git a/arch/arm/mach-mmp/teton_bga.c
> >> b/arch/arm/mach-mmp/teton_bga.c new file mode 100644
> >> index 0000000..014cc37
> >> --- /dev/null
> >> +++ b/arch/arm/mach-mmp/teton_bga.c
> >> @@ -0,0 +1,47 @@
> >> +/*
> >> + * linux/arch/arm/mach-mmp/teton_bga.c
> >> + *
> >> + * Support for the Marvell PXA168 Teton BGA Development Platform.
> >
> > Authoring information of this file are missing. Also, MAINTAINERS entry
> > is missing.
> >
> >> + *
> >> + * This code is based on aspenite.c
> >> + *
> >> + * This program is free software; you can redistribute it and/or
> >> modify + * it under the terms of the GNU General Public License
> >> version 2 as + * publishhed by the Free Software Foundation.
> >> + */
> >> +
> >> +#include <linux/init.h>
> >> +#include <linux/kernel.h>
> >> +#include <linux/platform_device.h>
> >> +
> >> +#include <asm/mach-types.h>
> >> +#include <asm/mach/arch.h>
> >> +#include <mach/addr-map.h>
> >> +#include <mach/mfp-pxa168.h>
> >> +#include <mach/pxa168.h>
> >> +#include <mach/gpio.h>
> >
> > use ... #include <linux/gpio.h>
> >
> >> +
> >> +#include "common.h"
> >> +
> >> +static unsigned long teton_bga_pin_config[] __initdata = {
> >> + /* UART1 */
> >> + GPIO107_UART1_TXD,
> >> + GPIO108_UART1_RXD,
> >> +};
> >> +
> >> +static void __init teton_bga_init(void)
> >> +{
> >> + mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
> >> +
> >> + /* on-chip devices */
> >> + pxa168_add_uart(1);
> >
> > Don't we have enum for these magic numbers on pxa168 ?
> >
> >> +}
> >> +
> >> +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
> >> + .phys_io = APB_PHYS_BASE,
> >> + .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc,
> >> + .map_io = mmp_map_io,
> >> + .init_irq = pxa168_init_irq,
> >> + .timer = &pxa168_timer,
> >> + .init_machine = teton_bga_init,
> >> +MACHINE_END
> >
> > Cheers
>
> I am assuming you mean the magic number for .io_pg_offst:
> .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc,
Nope, sorry, I meant this:
+ pxa168_add_uart(1);
The (1) seems weird, but whatever. I don't have any pxa168 device.
> It seems all of the other platforms in arch/arm are configuring it
> this way. Do you really want me to change this?
>
> Regards,
> -- Mark
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
2010-09-09 1:21 ` Marek Vasut
@ 2010-09-09 7:39 ` Eric Miao
2010-09-09 18:11 ` Marek Vasut
0 siblings, 1 reply; 13+ messages in thread
From: Eric Miao @ 2010-09-09 7:39 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Sep 9, 2010 at 9:21 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Dne ?t 9. z??? 2010 01:42:36 Mark F. Brown napsal(a):
>> On Wed, Sep 8, 2010 at 11:51 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> > Dne St 8. z??? 2010 04:56:45 Mark F. Brown napsal(a):
>> >
>> > ---------------------------
>> > Description is missing here
>> > ---------------------------
>> >
>> >> Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
>> >> ---
>> >> ?arch/arm/mach-mmp/Kconfig ? ? | ? ?7 ++++++
>> >> ?arch/arm/mach-mmp/Makefile ? ?| ? ?1 +
>> >> ?arch/arm/mach-mmp/teton_bga.c | ? 47
>> >> +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55
>> >> insertions(+), 0 deletions(-)
>> >> ?create mode 100644 arch/arm/mach-mmp/teton_bga.c
>> >>
>> >> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
>> >> index 6ab843e..0711d3b 100644
>> >> --- a/arch/arm/mach-mmp/Kconfig
>> >> +++ b/arch/arm/mach-mmp/Kconfig
>> >> @@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER
>> >> ? ? ? ? PXA910-based development board. Since MMP2 is compatible to
>> >> ? ? ? ? ARMv6 architecture.
>> >>
>> >> +config MACH_TETON_BGA
>> >> + ? ? bool "Marvell's PXA168 Teton BGA Development Board"
>> >> + ? ? select CPU_PXA168
>> >> + ? ? help
>> >> + ? ? ? Say 'Y' here if you want to support the Marvell PXA168-based
>> >> + ? ? ? Teton BGA Development Board.
>> >> +
>> >> ?endmenu
>> >>
>> >> ?config CPU_PXA168
>> >> diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
>> >> index 8b66d06..751cdbf 100644
>> >> --- a/arch/arm/mach-mmp/Makefile
>> >> +++ b/arch/arm/mach-mmp/Makefile
>> >> @@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o
>> >> ?obj-$(CONFIG_MACH_TTC_DKB) ? += ttc_dkb.o
>> >> ?obj-$(CONFIG_MACH_FLINT) ? ? += flint.o
>> >> ?obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o
>> >> +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o
>> >> diff --git a/arch/arm/mach-mmp/teton_bga.c
>> >> b/arch/arm/mach-mmp/teton_bga.c new file mode 100644
>> >> index 0000000..014cc37
>> >> --- /dev/null
>> >> +++ b/arch/arm/mach-mmp/teton_bga.c
>> >> @@ -0,0 +1,47 @@
>> >> +/*
>> >> + * ?linux/arch/arm/mach-mmp/teton_bga.c
>> >> + *
>> >> + * ?Support for the Marvell PXA168 Teton BGA Development Platform.
>> >
>> > Authoring information of this file are missing. Also, MAINTAINERS entry
>> > is missing.
>> >
>> >> + *
>> >> + * ?This code is based on aspenite.c
>> >> + *
>> >> + * ?This program is free software; you can redistribute it and/or
>> >> modify + * ?it under the terms of the GNU General Public License
>> >> version 2 as + * ?publishhed by the Free Software Foundation.
>> >> + */
>> >> +
>> >> +#include <linux/init.h>
>> >> +#include <linux/kernel.h>
>> >> +#include <linux/platform_device.h>
>> >> +
>> >> +#include <asm/mach-types.h>
>> >> +#include <asm/mach/arch.h>
>> >> +#include <mach/addr-map.h>
>> >> +#include <mach/mfp-pxa168.h>
>> >> +#include <mach/pxa168.h>
>> >> +#include <mach/gpio.h>
>> >
>> > use ... #include <linux/gpio.h>
>> >
>> >> +
>> >> +#include "common.h"
>> >> +
>> >> +static unsigned long teton_bga_pin_config[] __initdata = {
>> >> + ? ? /* UART1 */
>> >> + ? ? GPIO107_UART1_TXD,
>> >> + ? ? GPIO108_UART1_RXD,
>> >> +};
>> >> +
>> >> +static void __init teton_bga_init(void)
>> >> +{
>> >> + ? ? mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
>> >> +
>> >> + ? ? /* on-chip devices */
>> >> + ? ? pxa168_add_uart(1);
>> >
>> > Don't we have enum for these magic numbers on pxa168 ?
>> >
>> >> +}
>> >> +
>> >> +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development Platform")
>> >> + ? ? .phys_io ? ? ? ?= APB_PHYS_BASE,
>> >> + ? ? .io_pg_offst ? ?= (APB_VIRT_BASE >> 18) & 0xfffc,
>> >> + ? ? .map_io ? ? ? ? = mmp_map_io,
>> >> + ? ? .init_irq ? ? ? = pxa168_init_irq,
>> >> + ? ? .timer ? ? ? ? ?= &pxa168_timer,
>> >> + ? ? .init_machine ? = teton_bga_init,
>> >> +MACHINE_END
>> >
>> > Cheers
>>
>> I am assuming you mean the magic number for .io_pg_offst:
>> ?.io_pg_offst ? ?= (APB_VIRT_BASE >> 18) & 0xfffc,
>
> Nope, sorry, I meant this:
>
> + ? ? pxa168_add_uart(1);
>
> The (1) seems weird, but whatever. I don't have any pxa168 device.
>
Actually the parameter means the device ID, so pxa168_add_uart(1)
means to add UART1 on pxa168, so it's quite straight-forward.
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform
2010-09-09 7:39 ` Eric Miao
@ 2010-09-09 18:11 ` Marek Vasut
0 siblings, 0 replies; 13+ messages in thread
From: Marek Vasut @ 2010-09-09 18:11 UTC (permalink / raw)
To: linux-arm-kernel
Dne ?t 9. z??? 2010 09:39:15 Eric Miao napsal(a):
> On Thu, Sep 9, 2010 at 9:21 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > Dne ?t 9. z??? 2010 01:42:36 Mark F. Brown napsal(a):
> >> On Wed, Sep 8, 2010 at 11:51 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> > Dne St 8. z??? 2010 04:56:45 Mark F. Brown napsal(a):
> >> >
> >> > ---------------------------
> >> > Description is missing here
> >> > ---------------------------
> >> >
> >> >> Signed-off-by: Mark F. Brown <mark.brown314@gmail.com>
> >> >> ---
> >> >> arch/arm/mach-mmp/Kconfig | 7 ++++++
> >> >> arch/arm/mach-mmp/Makefile | 1 +
> >> >> arch/arm/mach-mmp/teton_bga.c | 47
> >> >> +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55
> >> >> insertions(+), 0 deletions(-)
> >> >> create mode 100644 arch/arm/mach-mmp/teton_bga.c
> >> >>
> >> >> diff --git a/arch/arm/mach-mmp/Kconfig b/arch/arm/mach-mmp/Kconfig
> >> >> index 6ab843e..0711d3b 100644
> >> >> --- a/arch/arm/mach-mmp/Kconfig
> >> >> +++ b/arch/arm/mach-mmp/Kconfig
> >> >> @@ -57,6 +57,13 @@ config MACH_MARVELL_JASPER
> >> >> PXA910-based development board. Since MMP2 is compatible to
> >> >> ARMv6 architecture.
> >> >>
> >> >> +config MACH_TETON_BGA
> >> >> + bool "Marvell's PXA168 Teton BGA Development Board"
> >> >> + select CPU_PXA168
> >> >> + help
> >> >> + Say 'Y' here if you want to support the Marvell PXA168-based
> >> >> + Teton BGA Development Board.
> >> >> +
> >> >> endmenu
> >> >>
> >> >> config CPU_PXA168
> >> >> diff --git a/arch/arm/mach-mmp/Makefile b/arch/arm/mach-mmp/Makefile
> >> >> index 8b66d06..751cdbf 100644
> >> >> --- a/arch/arm/mach-mmp/Makefile
> >> >> +++ b/arch/arm/mach-mmp/Makefile
> >> >> @@ -17,3 +17,4 @@ obj-$(CONFIG_MACH_TAVOREVB) += tavorevb.o
> >> >> obj-$(CONFIG_MACH_TTC_DKB) += ttc_dkb.o
> >> >> obj-$(CONFIG_MACH_FLINT) += flint.o
> >> >> obj-$(CONFIG_MACH_MARVELL_JASPER) += jasper.o
> >> >> +obj-$(CONFIG_MACH_TETON_BGA) += teton_bga.o
> >> >> diff --git a/arch/arm/mach-mmp/teton_bga.c
> >> >> b/arch/arm/mach-mmp/teton_bga.c new file mode 100644
> >> >> index 0000000..014cc37
> >> >> --- /dev/null
> >> >> +++ b/arch/arm/mach-mmp/teton_bga.c
> >> >> @@ -0,0 +1,47 @@
> >> >> +/*
> >> >> + * linux/arch/arm/mach-mmp/teton_bga.c
> >> >> + *
> >> >> + * Support for the Marvell PXA168 Teton BGA Development Platform.
> >> >
> >> > Authoring information of this file are missing. Also, MAINTAINERS
> >> > entry is missing.
> >> >
> >> >> + *
> >> >> + * This code is based on aspenite.c
> >> >> + *
> >> >> + * This program is free software; you can redistribute it and/or
> >> >> modify + * it under the terms of the GNU General Public License
> >> >> version 2 as + * publishhed by the Free Software Foundation.
> >> >> + */
> >> >> +
> >> >> +#include <linux/init.h>
> >> >> +#include <linux/kernel.h>
> >> >> +#include <linux/platform_device.h>
> >> >> +
> >> >> +#include <asm/mach-types.h>
> >> >> +#include <asm/mach/arch.h>
> >> >> +#include <mach/addr-map.h>
> >> >> +#include <mach/mfp-pxa168.h>
> >> >> +#include <mach/pxa168.h>
> >> >> +#include <mach/gpio.h>
> >> >
> >> > use ... #include <linux/gpio.h>
> >> >
> >> >> +
> >> >> +#include "common.h"
> >> >> +
> >> >> +static unsigned long teton_bga_pin_config[] __initdata = {
> >> >> + /* UART1 */
> >> >> + GPIO107_UART1_TXD,
> >> >> + GPIO108_UART1_RXD,
> >> >> +};
> >> >> +
> >> >> +static void __init teton_bga_init(void)
> >> >> +{
> >> >> + mfp_config(ARRAY_AND_SIZE(teton_bga_pin_config));
> >> >> +
> >> >> + /* on-chip devices */
> >> >> + pxa168_add_uart(1);
> >> >
> >> > Don't we have enum for these magic numbers on pxa168 ?
> >> >
> >> >> +}
> >> >> +
> >> >> +MACHINE_START(TETON_BGA, "PXA168-based Teton BGA Development
> >> >> Platform") + .phys_io = APB_PHYS_BASE,
> >> >> + .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc,
> >> >> + .map_io = mmp_map_io,
> >> >> + .init_irq = pxa168_init_irq,
> >> >> + .timer = &pxa168_timer,
> >> >> + .init_machine = teton_bga_init,
> >> >> +MACHINE_END
> >> >
> >> > Cheers
> >>
> >> I am assuming you mean the magic number for .io_pg_offst:
> >> .io_pg_offst = (APB_VIRT_BASE >> 18) & 0xfffc,
> >
> > Nope, sorry, I meant this:
> >
> > + pxa168_add_uart(1);
> >
> > The (1) seems weird, but whatever. I don't have any pxa168 device.
>
> Actually the parameter means the device ID, so pxa168_add_uart(1)
> means to add UART1 on pxa168, so it's quite straight-forward.
Ah ok, sorry about the confusion.
Can we see new version of this patch with my previous comments addressed ?
Thanks, Cheers
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2010-09-09 18:11 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-08 2:56 [PATCH 0/3] ARM: pxa168: Added Teton BGA Board Support Mark F. Brown
2010-09-08 2:56 ` [PATCH 1/3] ARM: pxa168: added support for Teton BGA platform Mark F. Brown
2010-09-08 5:36 ` Haojian Zhuang
2010-09-08 15:51 ` Marek Vasut
2010-09-08 23:42 ` Mark F. Brown
2010-09-09 1:21 ` Marek Vasut
2010-09-09 7:39 ` Eric Miao
2010-09-09 18:11 ` Marek Vasut
2010-09-08 2:56 ` [PATCH 2/3] ARM: pxa168/teton bga: added keypad support Mark F. Brown
2010-09-08 2:56 ` [PATCH 3/3] ARM: pxa168/teton bga: add board support for i2c and rtc-ds1337 Mark F. Brown
2010-09-08 5:34 ` Haojian Zhuang
2010-09-08 15:54 ` Marek Vasut
[not found] ` <AANLkTinGE=wxCcnSBiZQFeJxDG21DMd6KEcckavVuTbE@mail.gmail.com>
2010-09-08 21:09 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).