From: jassisinghbrar@gmail.com (Jassi Brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S5PV210: Add audio support to Goni and Aquila board
Date: Thu, 30 Sep 2010 16:06:00 +0900 [thread overview]
Message-ID: <AANLkTi=ibP77PvqzJCaQC++=WRkfgNYHfsRiCM38+4hc@mail.gmail.com> (raw)
In-Reply-To: <4C8D8233.2060602@samsung.com>
On Mon, Sep 13, 2010 at 10:45 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> This patch the I2C board information for the WM8994 used in the Goni/Aquila
> as audio codec and adds the I2C/I2S platform drivers. Additionlly, to
> control power consumption have registerd the voltage consumer of WM8994
> to the regulator framework.
>
> Additionally, I explain the constraints of the regulator of WM8994 codec.
> All these consumer supply of WM8994 codec connected the regulator(VCC_1.8V)
> on a circuit diagram. "VCC_1.8V" regulator is always enabled, because it is
> used to many devices on Goni/Aquila board. This is required especially
> when there are many devices physically attached to "VCC_1.8V" and some of
> they did not "register" as consumers to "VCC_1.8V". "VCC_1.8V" might be
> turned off by those who are registered while "unregistered" are still active.
>
> Signed-off-by : Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by : Joonyoung Shim <jy0922.shim@samsung.com>
> Signed-off-by : Kyungmin Park <kyungmin.park@samsung.com>
> ---
> ?arch/arm/mach-s5pv210/mach-aquila.c | ?170 +++++++++++++++++++++++++++++++++++
> ?arch/arm/mach-s5pv210/mach-goni.c ? | ?157 ++++++++++++++++++++++++++++++++
The contents seem ok (at least the audio related).
But it would have been better if you had broken the patch into three
a) Regulator support adding (90% of the code and should have been
CC'd to Mark and Liam as well)
b) I2C related.
c) Audio related
Preferably further divided for each machine.
next prev parent reply other threads:[~2010-09-30 7:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 1:45 [PATCH] ARM: S5PV210: Add audio support to Goni and Aquila board Chanwoo Choi
2010-09-17 1:30 ` Chanwoo Choi
2010-09-17 1:47 ` Kukjin Kim
2010-09-30 7:06 ` Jassi Brar [this message]
2010-10-01 4:07 ` Chanwoo Choi
-- strict thread matches above, loose matches on Subject: below --
2010-07-28 8:49 Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=ibP77PvqzJCaQC++=WRkfgNYHfsRiCM38+4hc@mail.gmail.com' \
--to=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).