From: ccross@google.com (Colin Cross)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 9/9] [ARM] tegra: Add cpufreq support
Date: Fri, 30 Jul 2010 12:56:33 -0700 [thread overview]
Message-ID: <AANLkTi=jvQtCZ8=rsWDuLNpPLvKh54PdWvLDFZefZWDD@mail.gmail.com> (raw)
In-Reply-To: <20100730131124.GA3117@isilmar-3.linta.de>
On Fri, Jul 30, 2010 at 6:11 AM, Dominik Brodowski
<linux@dominikbrodowski.net> wrote:
> Hey,
>
> just a few minor comments:
>
> On Thu, Jul 29, 2010 at 05:29:30PM -0700, Colin Cross wrote:
>> +int tegra_verify_speed(struct cpufreq_policy *policy)
> static int
Done
>> +unsigned int tegra_getspeed(unsigned int cpu)
> static unsined int
Done
>> + ? ? for_each_online_cpu(freqs.cpu)
>> + ? ? ? ? ? ? cpufreq_notify_transition(&freqs, CPUFREQ_PRECHANGE);
>> +
>> +#ifdef CONFIG_CPU_FREQ_DEBUG
>> + ? ? printk(KERN_DEBUG "cpufreq-tegra: transition: %u --> %u\n",
>> + ? ? ? ? ? ?freqs.old, freqs.new);
>> +#endif
> What about using cpufreq_debug_printk(CPUFREQ_DEBUG_DRIVER, ... ) here?
>
>> +
>> + ? ? ret = clk_set_rate_cansleep(cpu_clk, freqs.new * 1000);
> "can sleep"? For how long?
Adjusting the CPU clock may require changing the voltage through the
regulator api, which locks a mutex, and eventually through I2C, which
sleeps on I2C completion.
next prev parent reply other threads:[~2010-07-30 19:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 0:29 [PATCH 0/9] [ARM] tegra: Additional core support for Tegra2 SOCs Colin Cross
2010-07-30 0:29 ` [PATCH 1/9] [ARM] tegra: update iomap Colin Cross
2010-07-30 0:29 ` [PATCH 2/9] [ARM] tegra: Add legacy irq support Colin Cross
2010-07-30 0:29 ` [PATCH 3/9] [ARM] tegra: add suspend and mirror irqs to legacy controller Colin Cross
2010-07-30 0:29 ` [PATCH 4/9] [ARM] tegra: pinmux: add safe values, move tegra2, add suspend Colin Cross
2010-07-30 0:29 ` [PATCH 5/9] [ARM] tegra: gpio: Add suspend and wake support Colin Cross
2010-07-30 0:29 ` [PATCH 6/9] [ARM] tegra: Add support for reading fuses Colin Cross
2010-07-30 0:29 ` [PATCH 7/9] [ARM] tegra: clock: Add dvfs support, bug fixes, and cleanups Colin Cross
2010-07-30 0:29 ` [PATCH 8/9] [ARM] tegra: common: Update common clock init table Colin Cross
2010-07-30 0:29 ` [PATCH 9/9] [ARM] tegra: Add cpufreq support Colin Cross
2010-07-30 13:11 ` Dominik Brodowski
2010-07-30 19:56 ` Colin Cross [this message]
2010-07-30 20:20 ` Mark Brown
2010-07-30 20:33 ` Colin Cross
2010-07-30 21:14 ` Mark Brown
2010-08-25 21:24 ` [PATCH 0/9] [ARM] tegra: Additional core support for Tegra2 SOCs Erik Gilling
2010-09-01 22:14 ` Erik Gilling
2010-09-02 8:48 ` Russell King - ARM Linux
2010-09-02 10:20 ` Erik Gilling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=jvQtCZ8=rsWDuLNpPLvKh54PdWvLDFZefZWDD@mail.gmail.com' \
--to=ccross@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).