* [PATCH v3 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set
@ 2010-09-22 16:43 kishore kadiyala
2010-09-22 18:05 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: kishore kadiyala @ 2010-09-22 16:43 UTC (permalink / raw)
To: linux-arm-kernel
From: Benoit Cousson <b-cousson@ti.com>
Avoid possible crash if CONFIG_MMC_OMAP_HS is not set
Signed-off-by: Benoit Cousson <b-cousson@ti.com>
Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
---
arch/arm/mach-omap2/board-4430sdp.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
index a49f285..ac8541c 100644
--- a/arch/arm/mach-omap2/board-4430sdp.c
+++ b/arch/arm/mach-omap2/board-4430sdp.c
@@ -240,8 +240,14 @@ static int omap4_twl6030_hsmmc_late_init(struct device *dev)
static __init void omap4_twl6030_hsmmc_set_late_init(struct device *dev)
{
- struct omap_mmc_platform_data *pdata = dev->platform_data;
+ struct omap_mmc_platform_data *pdata;
+ /* dev can be null if CONFIG_MMC_OMAP_HS is not set */
+ if (!dev) {
+ pr_err("Failed omap4_twl6030_hsmmc_set_late_init\n");
+ return;
+ }
+ pdata = dev->platform_data;
pdata->init = omap4_twl6030_hsmmc_late_init;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v3 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set
2010-09-22 16:43 [PATCH v3 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set kishore kadiyala
@ 2010-09-22 18:05 ` Sergei Shtylyov
2010-09-24 16:24 ` kishore kadiyala
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2010-09-22 18:05 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
kishore kadiyala wrote:
> From: Benoit Cousson <b-cousson@ti.com>
> Avoid possible crash if CONFIG_MMC_OMAP_HS is not set
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
> ---
> arch/arm/mach-omap2/board-4430sdp.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c
> index a49f285..ac8541c 100644
> --- a/arch/arm/mach-omap2/board-4430sdp.c
> +++ b/arch/arm/mach-omap2/board-4430sdp.c
> @@ -240,8 +240,14 @@ static int omap4_twl6030_hsmmc_late_init(struct device *dev)
>
> static __init void omap4_twl6030_hsmmc_set_late_init(struct device *dev)
> {
> - struct omap_mmc_platform_data *pdata = dev->platform_data;
> + struct omap_mmc_platform_data *pdata;
>
> + /* dev can be null if CONFIG_MMC_OMAP_HS is not set */
> + if (!dev) {
> + pr_err("Failed omap4_twl6030_hsmmc_set_late_init\n");
pr_err("Failed %s\n", __func__);
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v3 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set
2010-09-22 18:05 ` Sergei Shtylyov
@ 2010-09-24 16:24 ` kishore kadiyala
0 siblings, 0 replies; 3+ messages in thread
From: kishore kadiyala @ 2010-09-24 16:24 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 22, 2010 at 11:35 PM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> Hello.
>
> kishore kadiyala wrote:
>
>> From: Benoit Cousson <b-cousson@ti.com>
>
>> Avoid possible crash if CONFIG_MMC_OMAP_HS is not set
>
>> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
>> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
>> ---
>> ?arch/arm/mach-omap2/board-4430sdp.c | ? ?8 +++++++-
>> ?1 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/board-4430sdp.c
>> b/arch/arm/mach-omap2/board-4430sdp.c
>> index a49f285..ac8541c 100644
>> --- a/arch/arm/mach-omap2/board-4430sdp.c
>> +++ b/arch/arm/mach-omap2/board-4430sdp.c
>> @@ -240,8 +240,14 @@ static int omap4_twl6030_hsmmc_late_init(struct
>> device *dev)
>>
>> ?static __init void omap4_twl6030_hsmmc_set_late_init(struct device *dev)
>> ?{
>> - ? ? ? struct omap_mmc_platform_data *pdata = dev->platform_data;
>> + ? ? ? struct omap_mmc_platform_data *pdata;
>>
>> + ? ? ? /* dev can be null if CONFIG_MMC_OMAP_HS is not set */
>> + ? ? ? if (!dev) {
>> + ? ? ? ? ? ? ? pr_err("Failed omap4_twl6030_hsmmc_set_late_init\n");
>
> ? pr_err("Failed %s\n", __func__);
OK , will have as mentioned
>
> WBR, Sergei
Regards,
Kishore
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-24 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-22 16:43 [PATCH v3 2/4] omap4 hsmmc: Fix the init if CONFIG_MMC_OMAP_HS is not set kishore kadiyala
2010-09-22 18:05 ` Sergei Shtylyov
2010-09-24 16:24 ` kishore kadiyala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).