From: zt.tmzt@gmail.com (zt.tmzt at gmail.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 16/20] video: msm: Set the EBI1 clock to 128MHz when performing blits
Date: Sat, 19 Mar 2011 21:31:45 -0400 [thread overview]
Message-ID: <AANLkTikQstS3jBLc63_AnmtB5rHFghG+yE73Ffbk4Gqu@mail.gmail.com> (raw)
In-Reply-To: <1300485562-27560-1-git-send-email-carlv@codeaurora.org>
How long does it take to ramp up the clock, are there blit operations where
the clock change could take longer than the blit (such as partial updates)?
--
Timothy Meade
tmzt on freenode
On Mar 18, 2011 5:59 PM, "Carl Vanderlip" <carlv@codeaurora.org> wrote:
> This makes sure that the MDP (locked to AXI) and the AXI/ABI1 run at the
> maximum frequency during blit operations.
>
> Authors:
> Dima Zavin <dima@android.com>
> Rebecca Schultz Zavin <rebecca@android.com>
> Colin Cross <ccross@android.com>
>
> Signed-off-by: Carl Vanderlip <carlv@codeaurora.org>
> ---
> drivers/video/msm/mdp.c | 11 +++++++++++
> drivers/video/msm/mdp_hw.h | 1 +
> 2 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c
> index b03204d..0bb19fa 100644
> --- a/drivers/video/msm/mdp.c
> +++ b/drivers/video/msm/mdp.c
> @@ -52,6 +52,7 @@ static int locked_enable_mdp_irq(struct mdp_info *mdp,
uint32_t mask)
> }
> /* if the mdp irq is not already enabled enable it */
> if (!mdp_irq_mask) {
> + clk_set_rate(mdp->ebi1_clk, 128000000);
> clk_enable(mdp->clk);
> enable_irq(mdp->irq);
> }
> @@ -656,6 +657,13 @@ int mdp_probe(struct platform_device *pdev)
> goto error_get_mdp_clk;
> }
>
> + mdp->ebi1_clk = clk_get(NULL, "ebi1_clk");
> + if (IS_ERR(mdp->ebi1_clk)) {
> + pr_err("mdp: failed to get ebi1 clk\n");
> + ret = PTR_ERR(mdp->ebi1_clk);
> + goto error_get_ebi1_clk;
> + }
> +
> ret = request_irq(mdp->irq, mdp_isr, IRQF_DISABLED, "msm_mdp", mdp);
> if (ret)
> goto error_request_irq;
> @@ -681,6 +689,9 @@ int mdp_probe(struct platform_device *pdev)
> error_device_register:
> free_irq(mdp->irq, mdp);
> error_request_irq:
> + clk_put(mdp->ebi1_clk);
> +error_get_ebi1_clk:
> + clk_put(mdp->clk);
> error_get_mdp_clk:
> error_mddi_pmdh_register:
> iounmap(mdp->base);
> diff --git a/drivers/video/msm/mdp_hw.h b/drivers/video/msm/mdp_hw.h
> index fdf9e5e..7485a9e 100644
> --- a/drivers/video/msm/mdp_hw.h
> +++ b/drivers/video/msm/mdp_hw.h
> @@ -46,6 +46,7 @@ struct mdp_info {
> char * __iomem base;
> int irq;
> struct clk *clk;
> + struct clk *ebi1_clk;
> struct mdp_out_interface out_if[MSM_MDP_NUM_INTERFACES];
> int format;
> int pack_pattern;
> --
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm"
in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110319/77063af8/attachment-0001.html>
next prev parent reply other threads:[~2011-03-20 1:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 21:47 [PATCH 00/20] video: msm: Adding Support for MDP3.1 Carl Vanderlip
2011-03-18 21:51 ` [PATCH 01/20] video: msm: Fix typo 'mpd'->'mdp' Carl Vanderlip
2011-03-21 4:24 ` Janorkar, Mayuresh
2011-03-22 0:08 ` Carl Vanderlip
2011-03-18 21:53 ` [PATCH 02/20] video: msm: add spinlock to mdp_info struct Carl Vanderlip
2011-03-18 21:53 ` [PATCH 03/20] video: msm: add locked_enable_mdp_irq function Carl Vanderlip
2011-03-18 21:54 ` [PATCH 04/20] video: msm: Move clk to mdp_info struct Carl Vanderlip
2011-03-18 21:54 ` [PATCH 05/20] video: msm: Setup framework for multiple output interfaces Carl Vanderlip
2011-03-18 21:55 ` [PATCH 06/20] video: msm: Simplify mdp_blit function Carl Vanderlip
2011-03-18 21:56 ` [PATCH 07/20] video: msm: Allow users to request a larger x and y virtual fb Carl Vanderlip
2011-03-21 4:40 ` Janorkar, Mayuresh
2011-03-21 16:41 ` Russell King - ARM Linux
2011-03-22 0:21 ` Carl Vanderlip
2011-03-18 21:56 ` [PATCH 08/20] video: msm: Refactor mdp_regs Carl Vanderlip
2011-03-21 5:17 ` Janorkar, Mayuresh
2011-03-21 17:23 ` Bryan Huntsman
2011-03-21 17:28 ` Brian Swetland
2011-03-18 21:57 ` [PATCH 09/20] video: msm: Split out MDP2.2 HW specific code Carl Vanderlip
2011-03-20 9:22 ` Russell King - ARM Linux
2011-03-22 0:26 ` Carl Vanderlip
2011-03-21 5:15 ` Janorkar, Mayuresh
2011-03-23 13:11 ` Daniel Walker
2011-03-23 19:18 ` Dima Zavin
2011-03-23 20:42 ` Carl Vanderlip
2011-03-23 22:47 ` David Brown
2011-03-18 21:57 ` [PATCH 10/20] video: msm: Separate more MDP " Carl Vanderlip
2011-03-18 21:57 ` [PATCH 11/20] video: msm: Add MDP FB DMA configuration Carl Vanderlip
2011-03-21 5:18 ` Janorkar, Mayuresh
2011-03-18 21:58 ` [PATCH 12/20] video: msm: Add IRQ callback for MDP interface Carl Vanderlip
2011-03-18 21:58 ` [PATCH 13/20] video: msm: Debugging for send_blit Carl Vanderlip
2011-03-21 5:20 ` Janorkar, Mayuresh
2011-03-18 21:58 ` [PATCH 14/20] video: msm: Write IRQ mask to MDP registers Carl Vanderlip
2011-03-18 21:59 ` [PATCH 15/20] video: msm: convert printk to pr_* Carl Vanderlip
2011-03-21 5:22 ` Janorkar, Mayuresh
2011-03-21 13:33 ` Sergei Shtylyov
2011-03-18 21:59 ` [PATCH 16/20] video: msm: Set the EBI1 clock to 128MHz when performing blits Carl Vanderlip
2011-03-20 1:31 ` zt.tmzt at gmail.com [this message]
2011-03-21 20:31 ` Stephen Boyd
2011-03-18 21:59 ` [PATCH 17/20] video: msm: Prevent framebuffer glitch during initialization Carl Vanderlip
2011-03-21 13:39 ` Sergei Shtylyov
2011-03-21 23:49 ` Carl Vanderlip
2011-03-18 21:59 ` [PATCH 18/20] video: msm: Prevent DMA lockups when switching bit depths Carl Vanderlip
2011-03-21 13:42 ` Sergei Shtylyov
2011-03-18 21:59 ` [PATCH 19/20] video: msm: Separate calculation of base and offset Carl Vanderlip
2011-03-18 22:00 ` [PATCH 20/20] video: msm: Add support for MDP 3.1 (qsd8k) Carl Vanderlip
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikQstS3jBLc63_AnmtB5rHFghG+yE73Ffbk4Gqu@mail.gmail.com \
--to=zt.tmzt@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).