From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm/pxa: buildfix for pam27x without fb
Date: Tue, 4 Jan 2011 12:00:51 +0800 [thread overview]
Message-ID: <AANLkTikfjwMEaUVCsLMHrtCyBo+GzoyPdLkFMoJY-_bi@mail.gmail.com> (raw)
In-Reply-To: <201101032308.00036.marek.vasut@gmail.com>
On Tue, Jan 4, 2011 at 6:07 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> On Monday 03 January 2011 16:57:27 Eric Miao wrote:
>> On Thu, Dec 30, 2010 at 4:33 AM, Sebastian Andrzej Siewior
>>
>> <bigeasy@linutronix.de> wrote:
>> > |arch/arm/mach-pxa/palmld.c: In function ?palmld_init?:
>> > |arch/arm/mach-pxa/palmld.c:330: error: ?palm_320x480_lcd_mode?
>> > |undeclared (first use in this function) arch/arm/mach-pxa/palmld.c:330:
>> > |error: (Each undeclared identifier is reported only once
>> > |arch/arm/mach-pxa/palmld.c:330: error: for each function it appears
>> > |in.)
>> >
>> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>>
>> Marek,
>>
>> I need your ack please.
>
> I don't like it being done with preprocessor macro. Maybe we should rather pull
> palm_320x320_new_lcd_mode and others outside the #if defined() ?
>
Yeah, that will be at least a bit more consistent.
>>
>> > ---
>> > ?arch/arm/mach-pxa/include/mach/palm27x.h | ? ?2 +-
>> > ?1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/arch/arm/mach-pxa/include/mach/palm27x.h
>> > b/arch/arm/mach-pxa/include/mach/palm27x.h index 0a5e5ea..7b7927c 100644
>> > --- a/arch/arm/mach-pxa/include/mach/palm27x.h
>> > +++ b/arch/arm/mach-pxa/include/mach/palm27x.h
>> > @@ -34,7 +34,7 @@ extern struct pxafb_mode_info
>> > palm_320x320_new_lcd_mode; extern void __init palm27x_lcd_init(int
>> > power,
>> > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct pxafb_mode_info *mode);
>> > ?#else
>> > -static inline void palm27x_lcd_init(int power, struct pxafb_mode_info
>> > *mode) {} +#define palm27x_lcd_init(power, mode) ?do { } while (0)
>> > ?#endif
>> >
>> > ?#if ? ?defined(CONFIG_USB_GADGET_PXA27X) || \
>> > --
>> > 1.7.3.2
>
next prev parent reply other threads:[~2011-01-04 4:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 20:33 [PATCH 1/2] arm/pxa: fix build of it8152 Sebastian Andrzej Siewior
2010-12-29 20:33 ` [PATCH 2/2] arm/pxa: buildfix for pam27x without fb Sebastian Andrzej Siewior
2011-01-03 15:57 ` Eric Miao
2011-01-03 22:07 ` Marek Vasut
2011-01-04 4:00 ` Eric Miao [this message]
2010-12-30 7:56 ` [PATCH 1/2] arm/pxa: fix build of it8152 Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikfjwMEaUVCsLMHrtCyBo+GzoyPdLkFMoJY-_bi@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).