From: kyungmin.park@samsung.com (Kyungmin Park)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: Samsung: Don't use the mach/gpio.h directly
Date: Tue, 3 Aug 2010 14:30:59 +0900 [thread overview]
Message-ID: <AANLkTikiP9ac5H7_rqtE6ZQoZaDr+a=bGYuSb8hMysgw@mail.gmail.com> (raw)
In-Reply-To: <00f101cb32ca$0852fc70$18f8f550$%kim@samsung.com>
On Tue, Aug 3, 2010 at 2:09 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Kyungmin Park wrote:
>>
>> Use the linux/gpio.h. also fix the build error since new C preprocessor
> directives.
>
> Cc'ed Ben Dooks.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> ?arch/arm/plat-samsung/gpiolib.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/plat-samsung/gpiolib.c
> b/arch/arm/plat-samsung/gpiolib.c
>> index 8a8ba8b..c354089 100644
>> --- a/arch/arm/plat-samsung/gpiolib.c
>> +++ b/arch/arm/plat-samsung/gpiolib.c
>> @@ -18,7 +18,7 @@
>> ?#include <linux/kernel.h>
>> ?#include <linux/irq.h>
>> ?#include <linux/io.h>
>> -#include <mach/gpio.h>
>> +#include <linux/gpio.h>
>
> Only here?
No a lots of places.
>
> If required, should be fixed all.
> And...as I said, then I will fix...
No problem.
>
>> ?#include <plat/gpio-core.h>
>> ?#include <plat/gpio-cfg.h>
>> ?#include <plat/gpio-cfg-helpers.h>
>> --
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2010-08-03 5:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 0:25 [PATCH 2/3] ARM: Samsung: Don't use the mach/gpio.h directly Kyungmin Park
2010-08-03 5:09 ` Kukjin Kim
2010-08-03 5:30 ` Kyungmin Park [this message]
2010-08-04 14:11 ` Ben Dooks
2010-08-04 22:33 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikiP9ac5H7_rqtE6ZQoZaDr+a=bGYuSb8hMysgw@mail.gmail.com' \
--to=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).