* [PATCH 2/3] ARM: Samsung: Don't use the mach/gpio.h directly
@ 2010-08-02 0:25 Kyungmin Park
2010-08-03 5:09 ` Kukjin Kim
2010-08-04 14:11 ` Ben Dooks
0 siblings, 2 replies; 5+ messages in thread
From: Kyungmin Park @ 2010-08-02 0:25 UTC (permalink / raw)
To: linux-arm-kernel
Use the linux/gpio.h. also fix the build error since new C preprocessor directives.
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/plat-samsung/gpiolib.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-samsung/gpiolib.c b/arch/arm/plat-samsung/gpiolib.c
index 8a8ba8b..c354089 100644
--- a/arch/arm/plat-samsung/gpiolib.c
+++ b/arch/arm/plat-samsung/gpiolib.c
@@ -18,7 +18,7 @@
#include <linux/kernel.h>
#include <linux/irq.h>
#include <linux/io.h>
-#include <mach/gpio.h>
+#include <linux/gpio.h>
#include <plat/gpio-core.h>
#include <plat/gpio-cfg.h>
#include <plat/gpio-cfg-helpers.h>
--
1.5.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] ARM: Samsung: Don't use the mach/gpio.h directly
2010-08-02 0:25 [PATCH 2/3] ARM: Samsung: Don't use the mach/gpio.h directly Kyungmin Park
@ 2010-08-03 5:09 ` Kukjin Kim
2010-08-03 5:30 ` Kyungmin Park
2010-08-04 14:11 ` Ben Dooks
1 sibling, 1 reply; 5+ messages in thread
From: Kukjin Kim @ 2010-08-03 5:09 UTC (permalink / raw)
To: linux-arm-kernel
Kyungmin Park wrote:
>
> Use the linux/gpio.h. also fix the build error since new C preprocessor
directives.
Cc'ed Ben Dooks.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/gpiolib.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/gpiolib.c
b/arch/arm/plat-samsung/gpiolib.c
> index 8a8ba8b..c354089 100644
> --- a/arch/arm/plat-samsung/gpiolib.c
> +++ b/arch/arm/plat-samsung/gpiolib.c
> @@ -18,7 +18,7 @@
> #include <linux/kernel.h>
> #include <linux/irq.h>
> #include <linux/io.h>
> -#include <mach/gpio.h>
> +#include <linux/gpio.h>
Only here?
If required, should be fixed all.
And...as I said, then I will fix...
> #include <plat/gpio-core.h>
> #include <plat/gpio-cfg.h>
> #include <plat/gpio-cfg-helpers.h>
> --
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/3] ARM: Samsung: Don't use the mach/gpio.h directly
2010-08-03 5:09 ` Kukjin Kim
@ 2010-08-03 5:30 ` Kyungmin Park
0 siblings, 0 replies; 5+ messages in thread
From: Kyungmin Park @ 2010-08-03 5:30 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Aug 3, 2010 at 2:09 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Kyungmin Park wrote:
>>
>> Use the linux/gpio.h. also fix the build error since new C preprocessor
> directives.
>
> Cc'ed Ben Dooks.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> ?arch/arm/plat-samsung/gpiolib.c | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/plat-samsung/gpiolib.c
> b/arch/arm/plat-samsung/gpiolib.c
>> index 8a8ba8b..c354089 100644
>> --- a/arch/arm/plat-samsung/gpiolib.c
>> +++ b/arch/arm/plat-samsung/gpiolib.c
>> @@ -18,7 +18,7 @@
>> ?#include <linux/kernel.h>
>> ?#include <linux/irq.h>
>> ?#include <linux/io.h>
>> -#include <mach/gpio.h>
>> +#include <linux/gpio.h>
>
> Only here?
No a lots of places.
>
> If required, should be fixed all.
> And...as I said, then I will fix...
No problem.
>
>> ?#include <plat/gpio-core.h>
>> ?#include <plat/gpio-cfg.h>
>> ?#include <plat/gpio-cfg-helpers.h>
>> --
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/3] ARM: Samsung: Don't use the mach/gpio.h directly
2010-08-02 0:25 [PATCH 2/3] ARM: Samsung: Don't use the mach/gpio.h directly Kyungmin Park
2010-08-03 5:09 ` Kukjin Kim
@ 2010-08-04 14:11 ` Ben Dooks
2010-08-04 22:33 ` Kukjin Kim
1 sibling, 1 reply; 5+ messages in thread
From: Ben Dooks @ 2010-08-04 14:11 UTC (permalink / raw)
To: linux-arm-kernel
On 02/08/10 01:25, Kyungmin Park wrote:
> Use the linux/gpio.h. also fix the build error since new C preprocessor directives.
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Ben Dooks <ben-linux@fluff.org>
> ---
> arch/arm/plat-samsung/gpiolib.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/gpiolib.c b/arch/arm/plat-samsung/gpiolib.c
> index 8a8ba8b..c354089 100644
> --- a/arch/arm/plat-samsung/gpiolib.c
> +++ b/arch/arm/plat-samsung/gpiolib.c
> @@ -18,7 +18,7 @@
> #include <linux/kernel.h>
> #include <linux/irq.h>
> #include <linux/io.h>
> -#include <mach/gpio.h>
> +#include <linux/gpio.h>
> #include <plat/gpio-core.h>
> #include <plat/gpio-cfg.h>
> #include <plat/gpio-cfg-helpers.h>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/3] ARM: Samsung: Don't use the mach/gpio.h directly
2010-08-04 14:11 ` Ben Dooks
@ 2010-08-04 22:33 ` Kukjin Kim
0 siblings, 0 replies; 5+ messages in thread
From: Kukjin Kim @ 2010-08-04 22:33 UTC (permalink / raw)
To: linux-arm-kernel
Ben Dooks wrote:
>
> On 02/08/10 01:25, Kyungmin Park wrote:
> > Use the linux/gpio.h. also fix the build error since new C preprocessor
directives.
> >
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> Acked-by: Ben Dooks <ben-linux@fluff.org>
Ok...will apply this into my tree.
> > ---
> > arch/arm/plat-samsung/gpiolib.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/plat-samsung/gpiolib.c
b/arch/arm/plat-samsung/gpiolib.c
> > index 8a8ba8b..c354089 100644
> > --- a/arch/arm/plat-samsung/gpiolib.c
> > +++ b/arch/arm/plat-samsung/gpiolib.c
> > @@ -18,7 +18,7 @@
> > #include <linux/kernel.h>
> > #include <linux/irq.h>
> > #include <linux/io.h>
> > -#include <mach/gpio.h>
> > +#include <linux/gpio.h>
> > #include <plat/gpio-core.h>
> > #include <plat/gpio-cfg.h>
> > #include <plat/gpio-cfg-helpers.h>
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-08-04 22:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-02 0:25 [PATCH 2/3] ARM: Samsung: Don't use the mach/gpio.h directly Kyungmin Park
2010-08-03 5:09 ` Kukjin Kim
2010-08-03 5:30 ` Kyungmin Park
2010-08-04 14:11 ` Ben Dooks
2010-08-04 22:33 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).