[PATCH] ARM: COLIBRI PXA320: fix UCB1400 irq autoprobing

[urx.forever@gmail.com (Yuri Ludkevich)]

2010/8/18 Daniel Mack <daniel@caiaq.de>

> On Wed, Aug 11, 2010 at 11:26:20PM +0200, Marek Vasut wrote:
> > Dne St 11. srpna 2010 16:33:45 Daniel Mack napsal(a):
> > > Hi Yuri,
> > >
> > > thanks for the patch.
> > >
> > > On Wed, Aug 11, 2010 at 04:54:13PM +0400, Yuri Ludkevich wrote:
> > > > Ads properly initialization to GPIO4 ( alt. fn. #1, nCS3; because
> GPIO4
> > > > and GPIO4_2 cannot be
> > > > configured as GPIO simultaneously ) so GPIO4_2 which used as irq line
> > > > from UCB1400 may be
> > > > detected while irq autoprobing routine.
> > >
> > > This looks fine to me, but Marek wanted to rework the board support in
> > > order to unify the GPIO configs for better readability. Marek, is there
> > > any tree which contains your changes already?
> > >
> > I hope there will be tomorrow ...
>
> Yuri, could you check out Marek's tree from
>
>  git://git.kernel.org/pub/scm/linux/kernel/git/marex/pxa-linux-2.6.gitwork
>
> (not that "work" ist the branch you'll need to work on).
>
> You'll see that colibri-pxa320.c looks a lot different now, so your
> patch should be a one-liner now.
>
> Also, more testing of this code is certainly appreciated :)
>
>

I have looked at code and I have couple of questions about colibri-pxa320.c
and colibri-evalboard.c:
Why colibri_pxa320_evalboard_pin_config[] placed in colibri-pxa320.c, not in
evalboard?
Why there is no defconfig for colibri pxa320?

BTW: we have our own board which very similar to colibri evalboard - same
RTC, UCB1400 as sound and touch controller. But we have USB hub onboard, do
not use FFUART and use 800x600 screen - so we make our own file with board
init stuff. May be colibri_pxa320_evalboard_pin_config[] and
pxafb_mode_info/pxa_fb_mach info structures also can be moved to evalboard
file?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100820/875e20ce/attachment-0001.html>