From: mcuos.com@gmail.com (Wan ZongShun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] RTC/pxa: remove unnecessary private ops->ioctl()
Date: Mon, 7 Jun 2010 16:57:32 +0800 [thread overview]
Message-ID: <AANLkTilJntnk11OZJt5oeKv4bk5qv8nlDnuGHc2hTGOt@mail.gmail.com> (raw)
In-Reply-To: <877hmbcjqu.fsf@free.fr>
2010/6/7 Robert Jarzmik <robert.jarzmik@free.fr>:
> Wan ZongShun <mcuos.com@gmail.com> writes:
>> Please, do not implement private ops->ioctl() unless absolutely necessary.
>> pxa series RTC driver's ioctl() is unnecessary, since RTC subsystem has implement
>> the ioctl() very well,so we can only use the API of '.alarm_irq_enable' and
>> '.update_irq_enable' to do enable irq action.
>>
>> Signed-off-by: Wan ZongShun <mcuos.com@gmail.com>
> Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> This is not an urgent fix, but a cleanup. Whoever gets it in (Alessandro through
> rtc tree, Eric through arm/pxa tree, or Andrew) is to be defined.
>
I will ping Andrew to apply it as soon as I get the owner's ACK.
> I would go for Alessandro, as he handles the RTC tree.
>
> Cheers.
>
> --
> Robert
>
> PS: Removed alsa-devel list, as this is not alsa material
Yes, I think I am careless for this. sorry.
>
--
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel at lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
* linux-arm-NUC900 mailing list
mail addr:NUC900 at googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com at gmail.com
next prev parent reply other threads:[~2010-06-07 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 14:29 [PATCH] RTC/pxa: remove unnecessary private ops->ioctl() Wan ZongShun
2010-06-07 8:47 ` Robert Jarzmik
2010-06-07 8:57 ` Wan ZongShun [this message]
2010-06-07 9:31 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilJntnk11OZJt5oeKv4bk5qv8nlDnuGHc2hTGOt@mail.gmail.com \
--to=mcuos.com@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).