From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] MTD/pxa: use resource_size(res) for pxa2xx-flash
Date: Sat, 5 Jun 2010 15:15:12 +0800 [thread overview]
Message-ID: <AANLkTilaptn-GhkoNC-CWLNP4XsTY7v-QCAypsF_BeKo@mail.gmail.com> (raw)
In-Reply-To: <4C09F359.1000100@gmail.com>
2010/6/5 Wan ZongShun <mcuos.com@gmail.com>:
> The size calculation is end - start + 1. But,sometimes, the '1' can
> be forgotten carelessly, witch will have potential risk, so use resource_size
> should be good habit.
>
> Signed-off-by :Wan ZongShun <mcuos.com@gmail.com>
Acked.
>
> ---
> ?drivers/mtd/maps/pxa2xx-flash.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
> index 43f8bb8..6ed9a2d 100644
> --- a/drivers/mtd/maps/pxa2xx-flash.c
> +++ b/drivers/mtd/maps/pxa2xx-flash.c
> @@ -79,7 +79,7 @@ static int __devinit pxa2xx_flash_probe(struct platform_device *pdev)
> ? ? ? ?info->map.name = (char *) flash->name;
> ? ? ? ?info->map.bankwidth = flash->width;
> ? ? ? ?info->map.phys = res->start;
> - ? ? ? info->map.size = res->end - res->start + 1;
> + ? ? ? info->map.size = resource_size(res);
> ? ? ? ?info->parts = flash->parts;
> ? ? ? ?info->nr_parts = flash->nr_parts;
>
> --
> 1.6.3.3
>
prev parent reply other threads:[~2010-06-05 7:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 6:48 [PATCH 3/3] MTD/pxa: use resource_size(res) for pxa2xx-flash Wan ZongShun
2010-06-05 7:15 ` Eric Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilaptn-GhkoNC-CWLNP4XsTY7v-QCAypsF_BeKo@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).