From mboxrd@z Thu Jan 1 00:00:00 1970 From: eric.y.miao@gmail.com (Eric Miao) Date: Sat, 5 Jun 2010 15:15:12 +0800 Subject: [PATCH 3/3] MTD/pxa: use resource_size(res) for pxa2xx-flash In-Reply-To: <4C09F359.1000100@gmail.com> References: <4C09F359.1000100@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org 2010/6/5 Wan ZongShun : > The size calculation is end - start + 1. But,sometimes, the '1' can > be forgotten carelessly, witch will have potential risk, so use resource_size > should be good habit. > > Signed-off-by :Wan ZongShun Acked. > > --- > ?drivers/mtd/maps/pxa2xx-flash.c | ? ?2 +- > ?1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c > index 43f8bb8..6ed9a2d 100644 > --- a/drivers/mtd/maps/pxa2xx-flash.c > +++ b/drivers/mtd/maps/pxa2xx-flash.c > @@ -79,7 +79,7 @@ static int __devinit pxa2xx_flash_probe(struct platform_device *pdev) > ? ? ? ?info->map.name = (char *) flash->name; > ? ? ? ?info->map.bankwidth = flash->width; > ? ? ? ?info->map.phys = res->start; > - ? ? ? info->map.size = res->end - res->start + 1; > + ? ? ? info->map.size = resource_size(res); > ? ? ? ?info->parts = flash->parts; > ? ? ? ?info->nr_parts = flash->nr_parts; > > -- > 1.6.3.3 >