From: kmpark@infradead.org (Kyungmin Park)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific
Date: Wed, 21 Jul 2010 22:31:34 +0900 [thread overview]
Message-ID: <AANLkTilt7F6CYZfuAqPmZrksCojoScij105wicbRd8DN@mail.gmail.com> (raw)
In-Reply-To: <009301cb28d0$6db6b470$49241d50$%kim@samsung.com>
On Wed, Jul 21, 2010 at 9:29 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Kyungmin Park wrote:
>>
>> I don't see the Samsung SoCs don't have RTC feature.
>>
> Yes, you're right...
> But it doesn't mean the RTC driver can support every Samsung SoCs now.
Vice versa, if there's problem, we can fix it easily. No need to
modify Kconfig anymore, just fix it driver itself.
>
>> I think S3C_RTC only depends on PLAT_SAMSUNG so PLAT_SAMSUNG select
>> HAVE_S3C_RTC is enough.
>
> So I think, this is not bad.
>
>>
>> Thank you,
>> Kyungmin Park
>>
>> On Wed, Jul 21, 2010 at 6:00 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
>> > From: Atul Dahiya <atul.dahiya@samsung.com>
>> >
>> > This patch moves the dependency of RTC driver from MACH_XXX(board) to
>> > ARCH_XXX(SoC). This will enable all machines using Samsung S5P6440,
>> S5PC100
>> > and S5PV210 SoCs to use RTC driver by default.
>> >
>> > Signed-off-by: Atul Dahiya <atul.dahiya@samsung.com>
>> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
>> > ---
>> > ?arch/arm/Kconfig ? ? ? ? ? ? ?| ? ?3 +++
>> > ?arch/arm/mach-s5p6440/Kconfig | ? ?1 -
>> > ?arch/arm/mach-s5pc100/Kconfig | ? ?1 -
>> > ?arch/arm/mach-s5pv210/Kconfig | ? ?2 --
>> > ?4 files changed, 3 insertions(+), 4 deletions(-)
>> >
>> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> > index 98922f7..ea668a4 100644
>> > --- a/arch/arm/Kconfig
>> > +++ b/arch/arm/Kconfig
>> > @@ -672,6 +672,7 @@ config ARCH_S5P6440
>> > ? ? ? ?select GENERIC_GPIO
>> > ? ? ? ?select HAVE_CLK
>> > ? ? ? ?select ARCH_USES_GETTIMEOFFSET
>> > + ? ? ? select HAVE_S3C_RTC
>> > ? ? ? ?help
>> > ? ? ? ? ?Samsung S5P6440 CPU based systems
>> >
>> > @@ -691,6 +692,7 @@ config ARCH_S5PC100
>> > ? ? ? ?select CPU_V7
>> > ? ? ? ?select ARM_L1_CACHE_SHIFT_6
>> > ? ? ? ?select ARCH_USES_GETTIMEOFFSET
>> > + ? ? ? select HAVE_S3C_RTC
>> > ? ? ? ?help
>> > ? ? ? ? ?Samsung S5PC100 series based systems
>> >
>> > @@ -701,6 +703,7 @@ config ARCH_S5PV210
>> > ? ? ? ?select HAVE_CLK
>> > ? ? ? ?select ARM_L1_CACHE_SHIFT_6
>> > ? ? ? ?select ARCH_USES_GETTIMEOFFSET
>> > + ? ? ? select HAVE_S3C_RTC
>> > ? ? ? ?help
>> > ? ? ? ? ?Samsung S5PV210/S5PC110 series based systems
>> >
>> > diff --git a/arch/arm/mach-s5p6440/Kconfig
> b/arch/arm/mach-s5p6440/Kconfig
>> > index b2d4716..de8f08d 100644
>> > --- a/arch/arm/mach-s5p6440/Kconfig
>> > +++ b/arch/arm/mach-s5p6440/Kconfig
>> > @@ -20,7 +20,6 @@ config MACH_SMDK6440
>> > ? ? ? ?select SAMSUNG_DEV_ADC
>> > ? ? ? ?select S3C_DEV_RTC
>> > ? ? ? ?select S3C_DEV_WDT
>> > - ? ? ? select HAVE_S3C_RTC
>> > ? ? ? ?select HAVE_S3C2410_WATCHDOG
>> > ? ? ? ?help
>> > ? ? ? ? ?Machine support for the Samsung SMDK6440
>> > diff --git a/arch/arm/mach-s5pc100/Kconfig
> b/arch/arm/mach-s5pc100/Kconfig
>> > index 2602895..e9c3d98 100644
>> > --- a/arch/arm/mach-s5pc100/Kconfig
>> > +++ b/arch/arm/mach-s5pc100/Kconfig
>> > @@ -48,7 +48,6 @@ config MACH_SMDKC100
>> > ? ? ? ?select S5PC100_SETUP_FB_24BPP
>> > ? ? ? ?select S5PC100_SETUP_I2C1
>> > ? ? ? ?select S5PC100_SETUP_SDHCI
>> > - ? ? ? select HAVE_S3C_RTC
>> > ? ? ? ?help
>> > ? ? ? ? ?Machine support for the Samsung SMDKC100
>> >
>> > diff --git a/arch/arm/mach-s5pv210/Kconfig
> b/arch/arm/mach-s5pv210/Kconfig
>> > index 04597cc..7f029d1 100644
>> > --- a/arch/arm/mach-s5pv210/Kconfig
>> > +++ b/arch/arm/mach-s5pv210/Kconfig
>> > @@ -75,7 +75,6 @@ config MACH_SMDKV210
>> > ? ? ? ?select SAMSUNG_DEV_TS
>> > ? ? ? ?select S3C_DEV_RTC
>> > ? ? ? ?select S3C_DEV_WDT
>> > - ? ? ? select HAVE_S3C_RTC
>> > ? ? ? ?select HAVE_S3C2410_WATCHDOG
>> > ? ? ? ?help
>> > ? ? ? ? ?Machine support for Samsung SMDKV210
>> > @@ -86,7 +85,6 @@ config MACH_SMDKC110
>> > ? ? ? ?select ARCH_SPARSEMEM_ENABLE
>> > ? ? ? ?select S3C_DEV_RTC
>> > ? ? ? ?select S3C_DEV_WDT
>> > - ? ? ? select HAVE_S3C_RTC
>> > ? ? ? ?select HAVE_S3C2410_WATCHDOG
>> > ? ? ? ?help
>> > ? ? ? ? ?Machine support for Samsung SMDKC110
>> > --
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>
prev parent reply other threads:[~2010-07-21 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 9:00 [PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific Kukjin Kim
2010-07-21 10:07 ` Kyungmin Park
2010-07-21 12:29 ` Kukjin Kim
2010-07-21 13:31 ` Kyungmin Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTilt7F6CYZfuAqPmZrksCojoScij105wicbRd8DN@mail.gmail.com \
--to=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).