From: linus.ml.walleij@gmail.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: PL330: Accept revisions of the dmac
Date: Sun, 5 Sep 2010 11:14:37 +0200 [thread overview]
Message-ID: <AANLkTimC5Ru-cTGVynnCu2NntHrHa9pB1HSGWEEJNZT7@mail.gmail.com> (raw)
In-Reply-To: <1283502656-15445-1-git-send-email-jassisinghbrar@gmail.com>
2010/9/3 Jassi Brar <jassisinghbrar@gmail.com>:
> -#define PERIPH_ID_VAL ?((PART << 0) | (DESIGNER << 12) \
> - ? ? ? ? ? ? ? ? ? ? ? ? | (REVISION << 20) | (INTEG_CFG << 24))
> +#define PERIPH_ID_VAL ?((PART << 0) | (DESIGNER << 12))
>
> ?#define PCELL_ID_VAL ? 0xb105f00d
Jassi, this kind of macros already exist in <linux/amba/bus.h>
can't you just #include that and use these instead?
Notice that you have the ID encoded in drivers/dma/pl330.c as
well so can you also update the mask/add a few ID:s to
pl330_ids[] in that file when you change this?
Yours,
Linus Walleij
next prev parent reply other threads:[~2010-09-05 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 8:30 [PATCH] ARM: PL330: Accept revisions of the dmac Jassi Brar
2010-09-03 22:43 ` Kukjin Kim
2010-09-04 1:32 ` Jassi Brar
2010-09-05 9:14 ` Linus Walleij [this message]
2010-09-05 9:53 ` Jassi Brar
2010-09-06 8:35 ` Linus Walleij
2010-09-06 23:27 ` Jassi Brar
2010-09-07 21:39 ` Linus Walleij
2010-10-05 12:31 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimC5Ru-cTGVynnCu2NntHrHa9pB1HSGWEEJNZT7@mail.gmail.com \
--to=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).