From: linus.ml.walleij@gmail.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Improve MMC performance on Versatile Express
Date: Tue, 1 Feb 2011 15:29:06 +0100 [thread overview]
Message-ID: <AANLkTimEBz6UK0X45cA2ihZddfcSTNqEPTJa=zGc+84S@mail.gmail.com> (raw)
In-Reply-To: <20110121222930.GF23151@n2100.arm.linux.org.uk>
2011/1/21 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> On Fri, Jan 21, 2011 at 05:20:57PM -0500, Nicolas Pitre wrote:
>> The only solution in that case is to give top priority to the FIFO IRQ
>> and never disable IRQs when in interrupt context, except for that FIFO
>> servicing handler which should keep IRQs masked out throughout. ?In any
>> case this would certainly be only a hack for badly misdesigned hardware.
>
> Not possible anymore. ?The kernel's IRQ handling has changed such that
> generic code now ensures that IRQs are disabled irrespective of the
> IRQF_DISABLED flag. ?All IRQ handlers are called with IRQs disabled,
> and they remain that way until they call local_irq_enable().
Then the only way of assuring low latency on this one IRQ would
be to convert the IRQ handlers for all the *other* hardware in the
Vexpress to request_threaded_irq(), and that's what the RealTime
folks do all the time I believe.
[Pawel Moll]
> (...) so far the only time when problem happens is the timeout caused
> by ISP1761 handler.
Have you considered switching the ISP1761 handler to
request_threaded_irq() with IRQF_ONESHOT | IRQF_NO_SUSPEND
so it runs in process context with that IRQ masked off, until completion?
Linus Walleij
next prev parent reply other threads:[~2011-02-01 14:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 13:59 [PATCH] arm: Improve MMC performance on Versatile Express Pawel Moll
2011-01-21 15:09 ` Sergei Shtylyov
2011-01-21 19:59 ` Nicolas Pitre
2011-01-21 21:51 ` Russell King - ARM Linux
2011-01-21 22:20 ` Nicolas Pitre
2011-01-21 22:29 ` Russell King - ARM Linux
2011-02-01 14:29 ` Linus Walleij [this message]
2011-02-01 17:25 ` Pawel Moll
2011-01-24 12:27 ` Pawel Moll
2011-01-24 13:35 ` Russell King - ARM Linux
2011-01-24 16:13 ` Pawel Moll
2011-01-24 16:24 ` Russell King - ARM Linux
2011-01-24 16:30 ` Russell King - ARM Linux
2011-01-24 16:39 ` Pawel Moll
2011-01-24 16:53 ` Russell King - ARM Linux
2011-01-24 17:03 ` Russell King - ARM Linux
2011-01-24 17:54 ` Pawel Moll
2011-01-24 18:09 ` Russell King - ARM Linux
2011-01-24 19:59 ` Pawel Moll
2011-01-24 23:10 ` Russell King - ARM Linux
2011-02-01 11:18 ` Russell King - ARM Linux
2011-02-01 13:34 ` Pawel Moll
2011-02-01 14:28 ` Russell King - ARM Linux
2011-02-01 17:25 ` Pawel Moll
2011-02-03 14:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimEBz6UK0X45cA2ihZddfcSTNqEPTJa=zGc+84S@mail.gmail.com' \
--to=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).