From: kmpark@infradead.org (Kyungmin Park)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] ARM: S5PC110: gpio_to_irq support on external interrupt
Date: Tue, 17 Aug 2010 14:51:30 +0900 [thread overview]
Message-ID: <AANLkTimL2And_8-vBvQUSJerYUhKFyH3ycr761Q3UQEx@mail.gmail.com> (raw)
In-Reply-To: <20100805072544.GA22271@july>
I think it's also bug fix since current external IRQ can't support
'gpio_to_irq' feature.
I hope it's included at this rc window.
On Thu, Aug 5, 2010 at 4:25 PM, Kyungmin Park <kmpark@infradead.org> wrote:
> From: Kyungmin Park <kyungmin.park@samsung.com>
>
> Using group field, it can calculate the related irq number easily.
> Also if don't support gpio_to_irq, it can't use the gpio functionaliy fully.
> e.g., can't use the gpio-keys and so on
>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> ?arch/arm/mach-s5pv210/gpiolib.c | ? 12 ++++++++++++
> ?1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s5pv210/gpiolib.c b/arch/arm/mach-s5pv210/gpiolib.c
> index f6a32c4..bd24c81 100644
> --- a/arch/arm/mach-s5pv210/gpiolib.c
> +++ b/arch/arm/mach-s5pv210/gpiolib.c
> @@ -246,6 +246,15 @@ static struct s3c_gpio_chip s5pv210_gpio_4bit[] = {
> ? ? ? ?},
> ?};
>
> +static int s5pv210_extint_to_irq(struct gpio_chip *gpio, unsigned int offset)
> +{
> + ? ? ? struct s3c_gpio_chip *chip = to_s3c_gpio(gpio);
> + ? ? ? int irq;
> +
> + ? ? ? irq = (chip->group * 8) + offset;
> + ? ? ? return IRQ_EINT(irq);
> +}
> +
> ?static __init int s5pv210_gpiolib_init(void)
> ?{
> ? ? ? ?struct s3c_gpio_chip *chip = s5pv210_gpio_4bit;
> @@ -257,6 +266,9 @@ static __init int s5pv210_gpiolib_init(void)
> ? ? ? ? ? ? ? ? ? ? ? ?chip->config = &gpio_cfg;
> ? ? ? ? ? ? ? ?if (chip->config == &gpio_cfg_extint) {
> ? ? ? ? ? ? ? ? ? ? ? ?chip->base = S5PV210_BANK_BASE(extint) + EXTINT_OFFSET;
> + ? ? ? ? ? ? ? ? ? ? ? /* Assign the external GPIO interrupt group number */
> + ? ? ? ? ? ? ? ? ? ? ? chip->group = extint;
> + ? ? ? ? ? ? ? ? ? ? ? chip->chip.to_irq = s5pv210_extint_to_irq;
> ? ? ? ? ? ? ? ? ? ? ? ?extint++;
> ? ? ? ? ? ? ? ?}
> ? ? ? ? ? ? ? ?if (chip->base == NULL)
> --
> 1.5.3.3
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
prev parent reply other threads:[~2010-08-17 5:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-05 7:25 [PATCH 3/5] ARM: S5PC110: gpio_to_irq support on external interrupt Kyungmin Park
2010-08-17 5:51 ` Kyungmin Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimL2And_8-vBvQUSJerYUhKFyH3ycr761Q3UQEx@mail.gmail.com \
--to=kmpark@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).