linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: yong.shen@linaro.org (Yong Shen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM i.MX53 enable LOCO board bootup
Date: Wed, 12 Jan 2011 10:46:24 +0800	[thread overview]
Message-ID: <AANLkTimODoRu8JSOs5ChOp8i3LUoUP4ZKn=aDHnVU6pL@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimW54m2f+Z21F+9dLw78WOS24W4yc00D5rztM0C@mail.gmail.com>

Hi Fabio,

Below is my reply to Baruch, I meant to keep this code here to show
the reset process clearly.
>> +     if (ret) {
>> +             printk(KERN_ERR"failed to get GPIO_FEC_PHY_RESET: %d\n", ret);
>> +             return;
>> +     }
>> +     gpio_direction_output(SMD_FEC_PHY_RST, 0);
>> +     gpio_set_value(SMD_FEC_PHY_RST, 0);
>
> This seems to be redundant. gpio_direction_output() has already set the value
> to 0.

You are right. But, gpio_set_value is meant to be here to show the
process of fec reset: first pull low and then pull high. And
gpio_direction_output here is for direction configuration although it
has the ability of configure output value.

thanks
Yong

  reply	other threads:[~2011-01-12  2:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-11  6:23 [PATCH 0/2] ARM i.MX53 enable SMD and LOCO board bootup yong.shen at freescale.com
2011-01-11  6:23 ` [PATCH 1/2] ARM i.MX53 enable SMD " yong.shen at freescale.com
2011-01-11  6:23 ` [PATCH 2/2] ARM i.MX53 enable LOCO " yong.shen at freescale.com
2011-01-11 14:39   ` Fabio Estevam
2011-01-12  2:46     ` Yong Shen [this message]
2011-01-12  7:29       ` Uwe Kleine-König
2011-01-11  7:23 ` [PATCH 0/2] ARM i.MX53 enable SMD and " Baruch Siach
2011-01-11  7:54   ` Yong Shen
2011-01-11  8:25     ` Baruch Siach
2011-01-11  8:58       ` Yong Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimODoRu8JSOs5ChOp8i3LUoUP4ZKn=aDHnVU6pL@mail.gmail.com' \
    --to=yong.shen@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).