linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: claude.youn@gmail.com (Seungwhan Youn)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration
Date: Mon, 27 Dec 2010 10:31:09 +0900	[thread overview]
Message-ID: <AANLkTimPj554qSkpydNQWWbkX71qpZ9CwNfU+EmUATWw@mail.gmail.com> (raw)
In-Reply-To: <20101224114904.GA15926@opensource.wolfsonmicro.com>

On Fri, Dec 24, 2010 at 8:49 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Fri, Dec 24, 2010 at 03:42:18PM +0900, Seungwhan Youn wrote:
>
>> ? ? ? select S3C_DEV_HSMMC
>> + ? ? select SMDK_HAS_WM9710_AC97 if ASOC_SAMSUNG
>> ? ? ? help
>
> There's no need for the ifs here - since the actual machine driver is a
> user visible control and the SMDK_HAS_ are just dependencies for that
> it's more normal to just select the symbol.

The 'if' seems to be necessary, otherwise we get 'unmet direct
dependency' warning message and the menuconfig shows messed up.

  reply	other threads:[~2010-12-27  1:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-24  6:26 [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Seungwhan Youn
2010-12-24  6:36 ` [PATCH 1/4] ARM: Kconfig: Add audio support dependency Seungwhan Youn
2011-01-02 14:05   ` Mark Brown
2011-01-03  1:37     ` [alsa-devel] " Seungwhan Youn
2011-01-03  2:28   ` Kukjin Kim
2010-12-24  6:42 ` [PATCH 2/4] ARM: SAMSUNG: Add SMDK audio configuration Seungwhan Youn
2010-12-24 11:49   ` Mark Brown
2010-12-27  1:31     ` Seungwhan Youn [this message]
2011-01-02 14:01   ` Mark Brown
2011-01-03  1:30     ` [alsa-devel] " Seungwhan Youn
2010-12-24  6:46 ` [PATCH 3/4] ASoC: SAMSUNG: Modify to indepedant depends on configuration Seungwhan Youn
2010-12-24  6:57 ` [PATCH 4/4] ASoC: SAMSUNG: Apply modifications for SMDK audio configuations Seungwhan Youn
2010-12-24  7:56 ` [alsa-devel] [PATCH 0/4] Modify configures to support Samsung ASoC dependancyless Jassi Brar
2010-12-24 11:43   ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTimPj554qSkpydNQWWbkX71qpZ9CwNfU+EmUATWw@mail.gmail.com \
    --to=claude.youn@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).