From: jassisinghbrar@gmail.com (Jassi Brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH 3/10] ARM: S5PC100: Add SCLK_SPDIF clock
Date: Tue, 5 Oct 2010 09:29:09 +0900 [thread overview]
Message-ID: <AANLkTimZLQLRP33e_1ZbHOLYOToHXjhyjY09F9gb7q+b@mail.gmail.com> (raw)
In-Reply-To: <20101004183041.GD2835@opensource.wolfsonmicro.com>
On Tue, Oct 5, 2010 at 3:30 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Mon, Oct 04, 2010 at 08:42:25PM +0900, Seungwhan Youn wrote:
>> This patch add SCLK_SPDIF clock to support source clock of S/PDIF
>> on S5PC100.
>>
>> Signed-off-by: Seungwhan Youn <sw.youn@samsung.com>
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> but...
>
>> +static int s5pc100_spdif_set_rate(struct clk *clk, unsigned long rate)
>> +{
>> + ? ? struct clk *pclk;
>> + ? ? int ret;
>
> This and the get() look like they're generic (they just proxy the
> operation on to the parent clock, which I imagine applies to a bunch of
> other clocks too.
Yes, that should apply to all Mux-Out and PAD 'clocks'.
I plan to submit a patch to have that feature in Samsung clock API --
call parent's operators
if the clock doesn't have one.
Since that might be a controversial change and hence delays in
acceptance (if at all),
we decided to do that for the devices that need it for now.
next prev parent reply other threads:[~2010-10-05 0:29 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 11:25 [PATCH 0/10] Add S/PDIF common driver for Samsung SoCs Seungwhan Youn
2010-10-04 11:31 ` [PATCH 1/10] ARM: S5PC100: Add S/PDIF platform device Seungwhan Youn
2010-10-04 18:23 ` Mark Brown
2010-10-08 9:54 ` Kukjin Kim
2010-10-04 11:39 ` [PATCH 2/10] ARM: S5PC100: Modify SCLK_AUDIO{0,1,2} clock as sysclks Seungwhan Youn
2010-10-04 18:28 ` Mark Brown
2010-10-08 9:57 ` Kukjin Kim
2010-10-04 11:42 ` [PATCH 3/10] ARM: S5PC100: Add SCLK_SPDIF clock Seungwhan Youn
2010-10-04 18:30 ` Mark Brown
2010-10-05 0:29 ` Jassi Brar [this message]
2010-10-08 10:11 ` Kukjin Kim
2010-10-08 10:45 ` Seungwhan Youn
2010-10-08 10:51 ` Kukjin Kim
2010-10-04 11:46 ` [PATCH 4/10] ARM: S5PV210: Add S/PDIF platform device Seungwhan Youn
2010-10-04 18:38 ` Mark Brown
2010-10-08 10:14 ` Kukjin Kim
2010-10-04 11:52 ` [PATCH 5/10] ARM: S5PV210: Add SCLK_SPDIF clock Seungwhan Youn
2010-10-04 18:39 ` Mark Brown
2010-10-05 0:30 ` [alsa-devel] " Jassi Brar
2010-10-08 10:16 ` Kukjin Kim
2010-10-08 10:51 ` Seungwhan Youn
2010-10-04 11:57 ` [PATCH 6/10] ARM: S5PV210: Add audio clocks as sysclk Seungwhan Youn
2010-10-04 18:42 ` Mark Brown
2010-10-08 10:18 ` Kukjin Kim
2010-10-04 12:05 ` [PATCH 7/10] ARM: S5PV210: Fix wrong EPLL rate getting on setup clocks Seungwhan Youn
2010-10-08 10:37 ` Kukjin Kim
2010-10-08 10:55 ` Seungwhan Youn
2010-10-04 12:07 ` [PATCH 8/10] ARM: S5PV210: Add EPLL clock operations Seungwhan Youn
2010-10-08 10:29 ` Kukjin Kim
2010-10-08 10:53 ` Seungwhan Youn
2010-10-04 12:13 ` [PATCH 9/10] ASoC: SAMSUNG: Add S/PDIF CPU driver Seungwhan Youn
2010-10-04 22:02 ` Mark Brown
2010-10-05 2:08 ` Seungwhan Youn
2010-10-04 12:16 ` [PATCH 10/10] ASoC: SAMSUNG: Add Machine driver for S/PDIF PCM audio Seungwhan Youn
2010-10-04 22:42 ` Mark Brown
2010-10-05 1:10 ` [alsa-devel] " Jassi Brar
2010-10-05 2:19 ` Jassi Brar
2010-10-05 4:43 ` Mark Brown
2010-10-05 5:39 ` Jassi Brar
2010-10-05 5:59 ` Mark Brown
2010-10-05 7:09 ` Jassi Brar
2010-10-05 7:39 ` Seungwhan Youn
2010-10-06 6:34 ` Kukjin Kim
2010-10-07 1:33 ` Seungwhan Youn
2010-10-08 9:07 ` Seungwhan Youn
2010-10-08 9:48 ` Kukjin Kim
2010-10-09 1:52 ` Jassi Brar
2010-10-11 10:47 ` Mark Brown
2010-10-12 1:27 ` Jassi Brar
2010-10-12 3:25 ` Seungwhan Youn
2010-10-05 16:54 ` Mark Brown
2010-10-04 13:35 ` [alsa-devel] [PATCH 0/10] Add S/PDIF common driver for Samsung SoCs Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimZLQLRP33e_1ZbHOLYOToHXjhyjY09F9gb7q+b@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).