From mboxrd@z Thu Jan  1 00:00:00 1970
From: jassisinghbrar@gmail.com (Jassi Brar)
Date: Fri, 2 Jul 2010 16:10:53 +0900
Subject: [PATCH 29/33] Removing dead SND_SOC_SMDK2443_WM9710
In-Reply-To: <20100701132515.GC32541@faui48a.informatik.uni-erlangen.de>
References: <cover.1277911345.git.siccegge@cs.fau.de>
	<e5391de6858597bbfd43874aed124a73f74850b5.1277911346.git.siccegge@cs.fau.de>
	<AANLkTinZa7_TEjYFTu9V6obndpVvMmHppaOArM1AJg_t@mail.gmail.com>
	<20100701132515.GC32541@faui48a.informatik.uni-erlangen.de>
Message-ID: <AANLkTimtrIdkBbAJDfBj5a_Y8n6MnvBN2FlTztSB610X@mail.gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Thu, Jul 1, 2010 at 10:25 PM, Christoph Egger <siccegge@cs.fau.de> wrote:
> On Thu, Jul 01, 2010 at 09:55:47PM +0900, Jassi Brar wrote:
>> On Thu, Jul 1, 2010 at 1:03 AM, Christoph Egger <siccegge@cs.fau.de> wrote:
>> > SND_SOC_SMDK2443_WM9710 doesn't exist in Kconfig, therefore removing
>> > all references for it from the source code.
>> I'd rather have the code compiled unconditionally.
>
> OK that would be done by the patch below
>
> ----
> From: Christoph Egger <siccegge@cs.fau.de>
> Date: Wed, 30 Jun 2010 17:18:52 +0200
> Subject: [PATCH 29/33] Removing dead SND_SOC_SMDK2443_WM9710
>
> SND_SOC_SMDK2443_WM9710 doesn't exist in Kconfig, therefore removing
> all references for it from the source code, building the parts
> unconditionally
>
> Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
> ---
> ?arch/arm/mach-s3c2443/mach-smdk2443.c | ? ?4 ----
> ?1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s3c2443/mach-smdk2443.c b/arch/arm/mach-s3c2443/mach-smdk2443.c
> index 4c863d3..764144a 100644
> --- a/arch/arm/mach-s3c2443/mach-smdk2443.c
> +++ b/arch/arm/mach-s3c2443/mach-smdk2443.c
> @@ -106,9 +106,7 @@ static struct platform_device *smdk2443_devices[] __initdata = {
> ? ? ? ?&s3c_device_wdt,
> ? ? ? ?&s3c_device_i2c0,
> ? ? ? ?&s3c_device_hsmmc0,
> -#ifdef CONFIG_SND_SOC_SMDK2443_WM9710
> ? ? ? ?&s3c_device_ac97,
> -#endif
This is ok provided 2440 support is included.

> ?};
>
> ?static void __init smdk2443_map_io(void)
> @@ -122,9 +120,7 @@ static void __init smdk2443_machine_init(void)
> ?{
> ? ? ? ?s3c_i2c0_set_platdata(NULL);
>
> -#ifdef CONFIG_SND_SOC_SMDK2443_WM9710
> ? ? ? ?s3c24xx_ac97_setup_gpio(S3C24XX_AC97_GPE0);
> -#endif
This gpio setup is nowhere implemented. So might as well discard it.