From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmci: call flush_dcache_page() outside of atomic kmap
Date: Sun, 2 Jan 2011 10:50:46 +0530 [thread overview]
Message-ID: <AANLkTin0LrGBGDkMOaxQ4qw3Zbw_RLRzQSRd1EzHbpF7@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=tt+thNTaPQCTYukpX6b0ZF5zVixDH27ZNwDMV@mail.gmail.com>
On Sun, Jan 2, 2011 at 10:41 AM, Rabin Vincent <rabin@rab.in> wrote:
> On Sun, Jan 2, 2011 at 10:08 AM, Rabin Vincent <rabin@rab.in> wrote:
>> On Sun, Jan 2, 2011 at 3:43 AM, Russell King - ARM Linux
>> <linux@arm.linux.org.uk> wrote:
>>> Err, hang on. ?The sg iter API uses flush_kernel_dcache_page(), not
>>> flush_dcache_page(). ?flush_kernel_dcache_page() is not expected to
>>> touch userspace mappings.
>>>
>>> On ARM, we don't implement flush_kernel_dcache_page() because it's
>>> not required (see commit f8b63c1.) ?Essentially, because we now consider
>>> freshly created page cache pages dirty, we always flush them before we
>>> map them into userspace, so a call to flush_kernel_dcache_page() has
>>> nothing to do.
>>
>> This email thread was never about the flush_kernel_dcache_page() in the
>> sg_miter API. ?It's about the flush_dcache_page() in MMCI.
>
> This flush_dcache_page() can also be removed because of what you mention
> above, right?
prev parent reply other threads:[~2011-01-02 5:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-01 10:36 [PATCH] mmci: call flush_dcache_page() outside of atomic kmap Rabin Vincent
2011-01-01 12:05 ` Russell King - ARM Linux
2011-01-01 14:28 ` Rabin Vincent
2011-01-01 22:13 ` Russell King - ARM Linux
2011-01-02 4:38 ` Rabin Vincent
2011-01-02 5:11 ` Rabin Vincent
2011-01-02 5:20 ` Rabin Vincent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin0LrGBGDkMOaxQ4qw3Zbw_RLRzQSRd1EzHbpF7@mail.gmail.com \
--to=rabin@rab.in \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).