From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa: fix cpu_is_pxa*() not expanded to zero when not configured
Date: Tue, 7 Sep 2010 17:48:26 +0800 [thread overview]
Message-ID: <AANLkTin3MmcouwsFmTsgZvkxBiryuNNrrU2qQ7aCuLmZ@mail.gmail.com> (raw)
In-Reply-To: <4C86075C.30802@ru.mvista.com>
On Tue, Sep 7, 2010 at 5:35 PM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> Hello.
>
> On 07-09-2010 8:09, Eric Miao wrote:
>
>> Could you give this a run?
>
>> diff --git a/arch/arm/mach-pxa/include/mach/hardware.h
>> b/arch/arm/mach-pxa/include/mach/hardware.h
>> index 7f64d24..b036500 100644
>> --- a/arch/arm/mach-pxa/include/mach/hardware.h
>> +++ b/arch/arm/mach-pxa/include/mach/hardware.h
>> @@ -264,23 +264,35 @@
>> ? *<= 0x2 for pxa21x/pxa25x/pxa26x/pxa27x
>> ? * == 0x3 for pxa300/pxa310/pxa320
>> ? */
>> +#if defined(CONFIG_PXA25x) || defined(CONFIG_PXA27x)
>> ?#define __cpu_is_pxa2xx(id) ? ? ? ? ? ? ? ? ? ? ? ? ? \
>> ? ? ? ?({ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
>> ? ? ? ? ? ? ? ?unsigned int _id = (id)>> ?13& ?0x7; ? ?\
>> ? ? ? ? ? ? ? ?_id<= 0x2; ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?\
>> ? ? ? ? })
>> +#else
>> +#define __cpu_is_pxa2xx(id) ? ?(0)
>
> ? Why enclose 0 in parens?
>
Just one of some coding style habits. Constant in parens in #define
will always be a bit safer.
> WBR, Sergei
>
prev parent reply other threads:[~2010-09-07 9:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 4:09 [PATCH] pxa: fix cpu_is_pxa*() not expanded to zero when not configured Eric Miao
2010-09-07 4:13 ` Marek Vasut
2010-09-07 9:35 ` Sergei Shtylyov
2010-09-07 9:48 ` Eric Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin3MmcouwsFmTsgZvkxBiryuNNrrU2qQ7aCuLmZ@mail.gmail.com \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).