From: omar.ramirez@ti.com (Ramirez Luna, Omar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/5] OMAP4: hwmod data: add mailbox data
Date: Tue, 15 Feb 2011 15:55:41 -0600 [thread overview]
Message-ID: <AANLkTinA2a60TSM7qDC1LQiRaUTs0DR3bDMv+oVsVOE0@mail.gmail.com> (raw)
In-Reply-To: <4D5943A9.8010205@ti.com>
Hi Benoit,
On Mon, Feb 14, 2011 at 9:00 AM, Cousson, Benoit <b-cousson@ti.com> wrote:
>> +static struct omap_hwmod_irq_info omap44xx_mailbox_irqs[] = {
>> + ? ? ? { .name = "mbox", .irq = 26 + OMAP44XX_IRQ_GIC_START, },
>
> The original entry was unnamed since it is an unique entry and thus does not
> need to be differentiate on this platform.
>
> ? ? ? ?{ .irq = 26 + OMAP44XX_IRQ_GIC_START },
>
> Do you really need to have a name here? The strategy being to provide a name
> only if more than one entry exist.
> It is perfectibility doable, I'm just trying to understand your rational.
It is this way instead of plain platform_get_irq because omap2420 has
two interrupt sources to MPU and mailbox driver uses
platform_get_irq_byname to get the irq number.
Regards,
Omar
next prev parent reply other threads:[~2011-02-15 21:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-02 19:27 [PATCH v5 0/5] omap: mailbox: hwmod support Omar Ramirez Luna
2011-02-02 19:27 ` [PATCH v5 1/5] OMAP2: hwmod data: add mailbox data Omar Ramirez Luna
2011-02-02 19:27 ` [PATCH v5 2/5] OMAP3: " Omar Ramirez Luna
2011-02-02 19:27 ` [PATCH v5 3/5] OMAP4: " Omar Ramirez Luna
2011-02-14 15:00 ` Cousson, Benoit
2011-02-15 21:55 ` Ramirez Luna, Omar [this message]
2011-02-15 22:05 ` Cousson, Benoit
2011-02-16 0:13 ` Ramirez Luna, Omar
2011-02-17 23:39 ` Tony Lindgren
2011-02-18 0:24 ` Ramirez Luna, Omar
2011-02-02 19:27 ` [PATCH v5 4/5] OMAP: mailbox: build device using omap_device/omap_hwmod Omar Ramirez Luna
2011-02-02 19:27 ` [PATCH v5 5/5] OMAP: mailbox: use runtime pm for clk and sysc handling Omar Ramirez Luna
2011-02-08 23:44 ` [PATCH v5 0/5] omap: mailbox: hwmod support Kevin Hilman
2011-02-09 18:32 ` Tony Lindgren
2011-02-10 6:01 ` Hiroshi DOYU
2011-02-11 16:37 ` Kevin Hilman
2011-02-10 5:34 ` Poddar, Sourav
2011-02-10 21:12 ` Kevin Hilman
2011-02-11 23:01 ` Kevin Hilman
2011-02-15 20:56 ` Ramirez Luna, Omar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinA2a60TSM7qDC1LQiRaUTs0DR3bDMv+oVsVOE0@mail.gmail.com \
--to=omar.ramirez@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).