From: linus.ml.walleij@gmail.com (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MMC: move regulator handling closer to core v3
Date: Thu, 9 Sep 2010 09:03:17 +0200 [thread overview]
Message-ID: <AANLkTinADjBaOcfdtGRZK0WdMs0xt+PLWGE7NUBndRr_@mail.gmail.com> (raw)
In-Reply-To: <20100908155114.880463fc.akpm@linux-foundation.org>
2010/9/9 Andrew Morton <akpm@linux-foundation.org>:
> On Sun, ?5 Sep 2010 11:05:38 +0200
> Linus Walleij <linus.walleij@stericsson.com> wrote:
>> + ? ? if (host->vcc) {
>> + ? ? ? ? ? ? int ret;
>> +
>> + ? ? ? ? ? ? if (power_mode == MMC_POWER_UP)
>> + ? ? ? ? ? ? ? ? ? ? ret = mmc_regulator_set_ocr(host->mmc, host->vcc, vdd);
>> + ? ? ? ? ? ? else if (power_mode == MMC_POWER_OFF)
>> + ? ? ? ? ? ? ? ? ? ? ret = mmc_regulator_set_ocr(host->mmc, host->vcc, 0);
>> + ? ? }
>
> There's no point in copying the return value into a local then ignoring
> it. ?mmc_regulator_set_ocr() can return a negative errno so we should
> test for that, clean up and propagate the error.
OK I'll fix.
> The same comments apply to mmci_set_ios().
OK.
Yours,
Linus Walleij
prev parent reply other threads:[~2010-09-09 7:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 9:05 [PATCH] MMC: move regulator handling closer to core v3 Linus Walleij
2010-09-08 22:51 ` Andrew Morton
2010-09-09 6:01 ` Adrian Hunter
2010-09-09 9:38 ` Mark Brown
2010-09-09 12:56 ` Adrian Hunter
2010-09-09 13:12 ` Mark Brown
2010-09-10 10:05 ` Adrian Hunter
2010-09-10 10:37 ` Mark Brown
2010-09-09 7:03 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinADjBaOcfdtGRZK0WdMs0xt+PLWGE7NUBndRr_@mail.gmail.com \
--to=linus.ml.walleij@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).