From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-pm] [PATCH] amba: move to pm ops
Date: Mon, 21 Feb 2011 13:06:59 +0530 [thread overview]
Message-ID: <AANLkTinFpX_uRzrVN+ZpuOLyM-QJovyK14Lb5bQSdTwh@mail.gmail.com> (raw)
In-Reply-To: <s5hr5b6wo7z.wl%tiwai@suse.de>
On Thu, Feb 17, 2011 at 23:14, Takashi Iwai <tiwai@suse.de> wrote:
> At Thu, 17 Feb 2011 13:19:46 +0530,
> Rabin Vincent wrote:
>>
>> Support pm_ops in the AMBA bus instead of the legacy ops. ? pm_ops is needed
>> for runtime pm, and there is also a general move to convert drivers to
>> dev_pm_ops rather than bus specific PM ops in order to facilitate core
>> development.
>>
>> Since there are only 6 AMBA drivers using suspend/resume, convert them all in
>> one go and directly use the GENERIC_SUBSYS_PM_OPS in the bus.
>>
>> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> Cc: Chris Ball <cjb@laptop.org>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Takashi Iwai <tiwai@suse.de>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: Greg Kroah-Hartman <gregkh@suse.de>
>> Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
>
> For sound/arm/aaci.c,
>
> ?Acked-by: Takashi Iwai <tiwai@suse.de>
>
> Though, this would result in a zero-filled *_pm struct when
> CONFIG_PM_* isn't set? ?It's a few bytes wastes ;)
Thank you for the ack. However, in v2 of the patch I've done a
different implementation in the bus code that doesn't necessitate
the conversion of all the drivers together, so this part is
dropped. I will take this comment into consideration if I do
end up converting all the drivers. Thanks.
next prev parent reply other threads:[~2011-02-21 7:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 7:49 [PATCH] amba: move to pm ops Rabin Vincent
2011-02-17 17:44 ` Takashi Iwai
2011-02-21 7:36 ` Rabin Vincent [this message]
2011-02-21 7:02 ` [PATCHv2] amba: support " Rabin Vincent
2011-02-21 20:26 ` [linux-pm] " Rafael J. Wysocki
2011-02-22 5:41 ` [PATCHv3] " Rabin Vincent
2011-02-22 14:17 ` Linus Walleij
2011-02-22 20:02 ` Rafael J. Wysocki
2011-02-22 20:15 ` Russell King - ARM Linux
2011-02-22 20:28 ` Rafael J. Wysocki
2011-02-22 5:44 ` [linux-pm] [PATCHv2] " Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinFpX_uRzrVN+ZpuOLyM-QJovyK14Lb5bQSdTwh@mail.gmail.com \
--to=rabin@rab.in \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).