From mboxrd@z Thu Jan 1 00:00:00 1970 From: rabin@rab.in (Rabin Vincent) Date: Mon, 21 Feb 2011 13:06:59 +0530 Subject: [linux-pm] [PATCH] amba: move to pm ops In-Reply-To: References: <1297928986-31171-1-git-send-email-rabin.vincent@stericsson.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Feb 17, 2011 at 23:14, Takashi Iwai wrote: > At Thu, 17 Feb 2011 13:19:46 +0530, > Rabin Vincent wrote: >> >> Support pm_ops in the AMBA bus instead of the legacy ops. ? pm_ops is needed >> for runtime pm, and there is also a general move to convert drivers to >> dev_pm_ops rather than bus specific PM ops in order to facilitate core >> development. >> >> Since there are only 6 AMBA drivers using suspend/resume, convert them all in >> one go and directly use the GENERIC_SUBSYS_PM_OPS in the bus. >> >> Cc: Dmitry Torokhov >> Cc: Chris Ball >> Cc: Grant Likely >> Cc: Takashi Iwai >> Cc: Linus Walleij >> Cc: Greg Kroah-Hartman >> Signed-off-by: Rabin Vincent > > For sound/arm/aaci.c, > > ?Acked-by: Takashi Iwai > > Though, this would result in a zero-filled *_pm struct when > CONFIG_PM_* isn't set? ?It's a few bytes wastes ;) Thank you for the ack. However, in v2 of the patch I've done a different implementation in the bus code that doesn't necessitate the conversion of all the drivers together, so this part is dropped. I will take this comment into consideration if I do end up converting all the drivers. Thanks.