From: ccross@google.com (Colin Cross)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [ARM] tegra: Add i2c support
Date: Thu, 2 Sep 2010 15:17:41 -0700 [thread overview]
Message-ID: <AANLkTinQ9nWP2a1bdhAv+r58nHoYKzgttj--7H+aOnqB@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimd2D+_xQ_CH-e+jgn+rZgMpJY6Zkc-SSVdFzMt@mail.gmail.com>
On Thu, Sep 2, 2010 at 2:54 PM, Colin Cross <ccross@google.com> wrote:
> On Tue, Aug 10, 2010 at 7:57 AM, Mike Rapoport <mike@compulab.co.il> wrote:
>> Hi Colin,
>> Two more comments.
>>
>> Colin Cross wrote:
>>>
>>> From: Colin Cross <ccross@android.com>
>>>
>>> CC: linux-i2c at vger.kernel.org
>>> Signed-off-by: Colin Cross <ccross@android.com>
>>> ---
>>> ?drivers/i2c/busses/Kconfig ? ? | ? ?7 +
>>> ?drivers/i2c/busses/Makefile ? ?| ? ?1 +
>>> ?drivers/i2c/busses/i2c-tegra.c | ?665
>>> ++++++++++++++++++++++++++++++++++++++++
>>> ?include/linux/i2c-tegra.h ? ? ?| ? 25 ++
>>
>> This should probably go to arch/arm/mach-tegra/include/mach/ to minimize the
>> pollution in include/linux
> The existing standard seems to be to use include/linux
>
>>> ?4 files changed, 698 insertions(+), 0 deletions(-)
>>> ?create mode 100644 drivers/i2c/busses/i2c-tegra.c
>>> ?create mode 100644 include/linux/i2c-tegra.h
>>>
>>
>> [ snip ]
>>
>>> +
>>> +static int __init tegra_i2c_init_driver(void)
>>> +{
>>> + ? ? ? return platform_driver_register(&tegra_i2c_driver);
>>> +}
>>> +module_init(tegra_i2c_init_driver);
>>
>> subsys_initcall would be better here.
> This can be compiled as a module, subsys_initcall would break that.
I stand corrected - subsys_initcall becomes module_init if it's
compiled as a module. I'll fix it.
next prev parent reply other threads:[~2010-09-02 22:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 0:36 [PATCH] [ARM] tegra: Add i2c support Colin Cross
2010-07-30 12:36 ` Anand Gadiyar
2010-09-02 22:07 ` Colin Cross
2010-07-30 20:44 ` Mike Rapoport
2010-09-02 21:42 ` Colin Cross
2010-08-10 14:57 ` Mike Rapoport
2010-09-02 21:54 ` Colin Cross
2010-09-02 22:17 ` Colin Cross [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-02 22:21 Colin Cross
2010-12-22 0:11 ` Colin Cross
2011-01-31 22:48 ` Stephen Warren
2011-02-07 17:45 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinQ9nWP2a1bdhAv+r58nHoYKzgttj--7H+aOnqB@mail.gmail.com \
--to=ccross@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).