From: dacohen@gmail.com (David Cohen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP: IOMMU: add missing function declaration
Date: Mon, 14 Feb 2011 13:26:08 +0200 [thread overview]
Message-ID: <AANLkTinQOCG9dEwky53LRwEYO95ptchu6tsRF1iXmfLn@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikUMURq-=okRju5YJroMEShHH6_eEMSvrg11UxC@mail.gmail.com>
On Mon, Feb 14, 2011 at 12:36 AM, Varadarajan, Charulatha <charu@ti.com> wrote:
> On Sat, Feb 12, 2011 at 19:09, David Cohen <dacohen@gmail.com> wrote:
>> Function declaration 'iopgtable_lookup_entry' is missing from header
>> file.
>
> Is this done because of any error?
> You may add a comment on why this is required.
The function is exported by iommu module, but no other driver is using
it so far. So, it's wrong but currently we have only a sparse warning.
I can add this information to the patch description.
Br,
David
>
>>
>> Signed-off-by: David Cohen <dacohen@gmail.com>
>> ---
>> ?arch/arm/plat-omap/include/plat/iommu.h | ? ?2 ++
>> ?1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h
>> index 9e8c104..5a2475f 100644
>> --- a/arch/arm/plat-omap/include/plat/iommu.h
>> +++ b/arch/arm/plat-omap/include/plat/iommu.h
>> @@ -163,6 +163,8 @@ extern void flush_iotlb_range(struct iommu *obj, u32 start, u32 end);
>> ?extern void flush_iotlb_all(struct iommu *obj);
>>
>> ?extern int iopgtable_store_entry(struct iommu *obj, struct iotlb_entry *e);
>> +extern void iopgtable_lookup_entry(struct iommu *obj, u32 da, u32 **ppgd,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?u32 **ppte);
>> ?extern size_t iopgtable_clear_entry(struct iommu *obj, u32 iova);
>>
>> ?extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end);
>> --
>> 1.7.1
>>
>
prev parent reply other threads:[~2011-02-14 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 11:09 [PATCH] OMAP: IOMMU: add missing function declaration David Cohen
2011-02-13 22:36 ` Varadarajan, Charulatha
2011-02-14 11:26 ` David Cohen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinQOCG9dEwky53LRwEYO95ptchu6tsRF1iXmfLn@mail.gmail.com \
--to=dacohen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).