* [PATCH] OMAP: IOMMU: add missing function declaration
@ 2011-02-12 11:09 David Cohen
2011-02-13 22:36 ` Varadarajan, Charulatha
0 siblings, 1 reply; 3+ messages in thread
From: David Cohen @ 2011-02-12 11:09 UTC (permalink / raw)
To: linux-arm-kernel
Function declaration 'iopgtable_lookup_entry' is missing from header
file.
Signed-off-by: David Cohen <dacohen@gmail.com>
---
arch/arm/plat-omap/include/plat/iommu.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h
index 9e8c104..5a2475f 100644
--- a/arch/arm/plat-omap/include/plat/iommu.h
+++ b/arch/arm/plat-omap/include/plat/iommu.h
@@ -163,6 +163,8 @@ extern void flush_iotlb_range(struct iommu *obj, u32 start, u32 end);
extern void flush_iotlb_all(struct iommu *obj);
extern int iopgtable_store_entry(struct iommu *obj, struct iotlb_entry *e);
+extern void iopgtable_lookup_entry(struct iommu *obj, u32 da, u32 **ppgd,
+ u32 **ppte);
extern size_t iopgtable_clear_entry(struct iommu *obj, u32 iova);
extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] OMAP: IOMMU: add missing function declaration
2011-02-12 11:09 [PATCH] OMAP: IOMMU: add missing function declaration David Cohen
@ 2011-02-13 22:36 ` Varadarajan, Charulatha
2011-02-14 11:26 ` David Cohen
0 siblings, 1 reply; 3+ messages in thread
From: Varadarajan, Charulatha @ 2011-02-13 22:36 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Feb 12, 2011 at 19:09, David Cohen <dacohen@gmail.com> wrote:
> Function declaration 'iopgtable_lookup_entry' is missing from header
> file.
Is this done because of any error?
You may add a comment on why this is required.
>
> Signed-off-by: David Cohen <dacohen@gmail.com>
> ---
> ?arch/arm/plat-omap/include/plat/iommu.h | ? ?2 ++
> ?1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h
> index 9e8c104..5a2475f 100644
> --- a/arch/arm/plat-omap/include/plat/iommu.h
> +++ b/arch/arm/plat-omap/include/plat/iommu.h
> @@ -163,6 +163,8 @@ extern void flush_iotlb_range(struct iommu *obj, u32 start, u32 end);
> ?extern void flush_iotlb_all(struct iommu *obj);
>
> ?extern int iopgtable_store_entry(struct iommu *obj, struct iotlb_entry *e);
> +extern void iopgtable_lookup_entry(struct iommu *obj, u32 da, u32 **ppgd,
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?u32 **ppte);
> ?extern size_t iopgtable_clear_entry(struct iommu *obj, u32 iova);
>
> ?extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end);
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] OMAP: IOMMU: add missing function declaration
2011-02-13 22:36 ` Varadarajan, Charulatha
@ 2011-02-14 11:26 ` David Cohen
0 siblings, 0 replies; 3+ messages in thread
From: David Cohen @ 2011-02-14 11:26 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Feb 14, 2011 at 12:36 AM, Varadarajan, Charulatha <charu@ti.com> wrote:
> On Sat, Feb 12, 2011 at 19:09, David Cohen <dacohen@gmail.com> wrote:
>> Function declaration 'iopgtable_lookup_entry' is missing from header
>> file.
>
> Is this done because of any error?
> You may add a comment on why this is required.
The function is exported by iommu module, but no other driver is using
it so far. So, it's wrong but currently we have only a sparse warning.
I can add this information to the patch description.
Br,
David
>
>>
>> Signed-off-by: David Cohen <dacohen@gmail.com>
>> ---
>> ?arch/arm/plat-omap/include/plat/iommu.h | ? ?2 ++
>> ?1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/include/plat/iommu.h b/arch/arm/plat-omap/include/plat/iommu.h
>> index 9e8c104..5a2475f 100644
>> --- a/arch/arm/plat-omap/include/plat/iommu.h
>> +++ b/arch/arm/plat-omap/include/plat/iommu.h
>> @@ -163,6 +163,8 @@ extern void flush_iotlb_range(struct iommu *obj, u32 start, u32 end);
>> ?extern void flush_iotlb_all(struct iommu *obj);
>>
>> ?extern int iopgtable_store_entry(struct iommu *obj, struct iotlb_entry *e);
>> +extern void iopgtable_lookup_entry(struct iommu *obj, u32 da, u32 **ppgd,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?u32 **ppte);
>> ?extern size_t iopgtable_clear_entry(struct iommu *obj, u32 iova);
>>
>> ?extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end);
>> --
>> 1.7.1
>>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-14 11:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-12 11:09 [PATCH] OMAP: IOMMU: add missing function declaration David Cohen
2011-02-13 22:36 ` Varadarajan, Charulatha
2011-02-14 11:26 ` David Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).