Pending patches for s5pc110

Pending patches for s5pc110

[Kyungmin Park]

Hi,

No comments mean it's okay then we will prepare the patches to git pull.

Thank you,
Kyungmin Park

On Fri, Jun 4, 2010 at 8:53 AM, Kyungmin Park <kmpark@infradead.org> wrote:
> Hi ben,
>
> There's some pending patches for s5pc110.
> 1. aquila & goni support files.
> 2. keypad
> 3. s3c-fb - we have to implement FIMD and MIPI interface so please
> decide how to handle it.
> 4. etc.
>
> Do you want to re-post or any activities?
>
> Please give your plans or opinions.
>
> Thank you,
> Kyungmin Park
>

Pending patches for s5pc110

[Ben Dooks]

On Fri, Jun 11, 2010 at 01:25:18PM +0900, Kyungmin Park wrote:
> Hi,
> 
> No comments mean it's okay then we will prepare the patches to git pull.

No. no comments means that people either haven't had time to sort
them out or in fact ON HOLIDAY.
 
> Thank you,
> Kyungmin Park
> 
> On Fri, Jun 4, 2010 at 8:53 AM, Kyungmin Park <kmpark@infradead.org> wrote:
> > Hi ben,
> >
> > There's some pending patches for s5pc110.
> > 1. aquila & goni support files.

these two should have gone in already

> > 2. keypad

I think kukjin has been looking at this, best check with him.

> > 3. s3c-fb - we have to implement FIMD and MIPI interface so please
> > decide how to handle it.

since we've not had any chance to discuss what is going on here
I can't see how we are ready to submit anything.

> > 4. etc.
> >
> > Do you want to re-post or any activities?
> >
> > Please give your plans or opinions.
> >
> > Thank you,
> > Kyungmin Park
> >
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

Pending patches for s5pc110

[Kyungmin Park]

On Fri, Jun 11, 2010 at 2:15 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Fri, Jun 11, 2010 at 01:25:18PM +0900, Kyungmin Park wrote:
>> Hi,
>>
>> No comments mean it's okay then we will prepare the patches to git pull.
>
> No. no comments means that people either haven't had time to sort
> them out or in fact ON HOLIDAY.

but you usually missed our patches frequently. with this reason our
patches can't merge within proper merge window.

>
>> Thank you,
>> Kyungmin Park
>>
>> On Fri, Jun 4, 2010 at 8:53 AM, Kyungmin Park <kmpark@infradead.org> wrote:
>> > Hi ben,
>> >
>> > There's some pending patches for s5pc110.
>> > 1. aquila & goni support files.
>
> these two should have gone in already

I mean more aquila & goni patches. not basic support. e.g. OneNAND
support, FB support and so on.
>
>> > 2. keypad
>
> I think kukjin has been looking at this, best check with him.

It's already discussed. do you think it needs more comments?

>
>> > 3. s3c-fb - we have to implement FIMD and MIPI interface so please
>> > decide how to handle it.
>
> since we've not had any chance to discuss what is going on here
> I can't see how we are ready to submit anything.

It's basic functionality for s3c-fb. it's required for our target and
want to use it. even though someone don't use it.

I wonder some features are not used for other board. in this case it
should be merged if it doesn't break any previous board. Of course
with proper feedback. I think we answer your question doesn't it?

Thank you,
Kyungmin Park

>
>> > 4. etc.
>> >
>> > Do you want to re-post or any activities?
>> >
>> > Please give your plans or opinions.
>> >
>> > Thank you,
>> > Kyungmin Park
>> >
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
> --
> --
> Ben
>
> Q: ? ? ?What's a light-year?
> A: ? ? ?One-third less calories than a regular year.
>
>

Pending patches for s5pc110

[Kukjin Kim]

Kyungmin Park wrote:
> 
> On Fri, Jun 11, 2010 at 2:15 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> > On Fri, Jun 11, 2010 at 01:25:18PM +0900, Kyungmin Park wrote:
> >> Hi,
> >>
> >> No comments mean it's okay then we will prepare the patches to git pull.
> >
Maybe you already know no comments do not mean it's okay.

> > No. no comments means that people either haven't had time to sort
> > them out or in fact ON HOLIDAY.
> 
> but you usually missed our patches frequently. with this reason our
> patches can't merge within proper merge window.
> 
> >
> >> Thank you,
> >> Kyungmin Park
> >>
> >> On Fri, Jun 4, 2010 at 8:53 AM, Kyungmin Park <kmpark@infradead.org>
wrote:
> >> > Hi ben,
> >> >
> >> > There's some pending patches for s5pc110.
> >> > 1. aquila & goni support files.
> >
> > these two should have gone in already
> 
> I mean more aquila & goni patches. not basic support. e.g. OneNAND
> support, FB support and so on.
> >
> >> > 2. keypad
> >
> > I think kukjin has been looking at this, best check with him.
> 
> It's already discussed. do you think it needs more comments?
> 
You mean discussed to me?
Sorry, I can't remember when we discussed about that, what's my comments?

> >
> >> > 3. s3c-fb - we have to implement FIMD and MIPI interface so please
> >> > decide how to handle it.
> >
> > since we've not had any chance to discuss what is going on here
> > I can't see how we are ready to submit anything.
> 
> It's basic functionality for s3c-fb. it's required for our target and
> want to use it. even though someone don't use it.
> 
> I wonder some features are not used for other board. in this case it
> should be merged if it doesn't break any previous board. Of course
> with proper feedback. I think we answer your question doesn't it?
> 
> Thank you,
> Kyungmin Park
> 
> >
> >> > 4. etc.
> >> >
> >> > Do you want to re-post or any activities?
> >> >
> >> > Please give your plans or opinions.
> >> >
> >> > Thank you,
> >> > Kyungmin Park
> >> >
> >>


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Pending patches for s5pc110

[Ben Dooks]

On Fri, Jun 11, 2010 at 02:38:56PM +0900, Kyungmin Park wrote:
> On Fri, Jun 11, 2010 at 2:15 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> > On Fri, Jun 11, 2010 at 01:25:18PM +0900, Kyungmin Park wrote:
> >> Hi,
> >>
> >> No comments mean it's okay then we will prepare the patches to git pull.
> >
> > No. no comments means that people either haven't had time to sort
> > them out or in fact ON HOLIDAY.
> 
> but you usually missed our patches frequently. with this reason our
> patches can't merge within proper merge window.

I belive the last set where either being posted just-before or during
the last merge window. We already had far too much queueud up then and
we where trying to ensure that the already-queued entries where processed.

The last call for updates went out on 13th May, and the two machine
patches actually turned up on the 30th of May...

It is important that we get these merges ready at least a week in
advance of the merge window, otherwise there is _no_ time time to test
the merged trees, and even worse there is little time to correct any
mistakes... there where I belive two merge problems with trying to
rebuild trees at the last minute ready to send to Linus.

Unfortunately the S5PC100 moves did get overlooked (I think I may ended
up dropping off the samsung-soc list) and the ended up producing a lot
of the work involved in generating the pull request to RMK and then
Linus. (see http://thread.gmane.org/gmane.linux.kernel.samsung-soc/1427)

If we can organise ourselves better (and Kukjin will be taking over some
of this work) then maybe we will have a much better experience for the
next time.

> >
> >> Thank you,
> >> Kyungmin Park
> >>
> >> On Fri, Jun 4, 2010 at 8:53 AM, Kyungmin Park <kmpark@infradead.org> wrote:
> >> > Hi ben,
> >> >
> >> > There's some pending patches for s5pc110.
> >> > 1. aquila & goni support files.
> >
> > these two should have gone in already
> 
> I mean more aquila & goni patches. not basic support. e.g. OneNAND
> support, FB support and so on.

As above, I belive these where rather late on the horizon to be included.

> >> > 2. keypad
> >
> > I think kukjin has been looking at this, best check with him.
> 
> It's already discussed. do you think it needs more comments?

Me, no. I think if Kukjin has no problems then it is up to Dimitry
whether he wants to merge it.
 
> >
> >> > 3. s3c-fb - we have to implement FIMD and MIPI interface so please
> >> > decide how to handle it.
> >
> > since we've not had any chance to discuss what is going on here
> > I can't see how we are ready to submit anything.
> 
> It's basic functionality for s3c-fb. it's required for our target and
> want to use it. even though someone don't use it.
> 
> I wonder some features are not used for other board. in this case it
> should be merged if it doesn't break any previous board. Of course
> with proper feedback. I think we answer your question doesn't it?

The fb system is currently without a propler maintainer and Andrew Morton
has been doing the job of applying patches. I don't know the reasons for
the last round of development not going in, but it was probably due to it
being too late.. I've so far been unable to actually subscribe to the new
fb list to try and sort it out.

This however doesn't cover the fact that there's been no movement on
dicsussing what is needed to support FIMC addition to the framebuffer
driver.

Do you have even a list of things that you think are needed for this, or
any actual patches we could look at and discuss?

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

Pending patches for s5pc110

[Kyungmin Park]

On Fri, Jun 11, 2010 at 3:23 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Fri, Jun 11, 2010 at 02:38:56PM +0900, Kyungmin Park wrote:
>> On Fri, Jun 11, 2010 at 2:15 PM, Ben Dooks <ben-linux@fluff.org> wrote:
>> > On Fri, Jun 11, 2010 at 01:25:18PM +0900, Kyungmin Park wrote:
>> >> Hi,
>> >>
>> >> No comments mean it's okay then we will prepare the patches to git pull.
>> >
>> > No. no comments means that people either haven't had time to sort
>> > them out or in fact ON HOLIDAY.
>>
>> but you usually missed our patches frequently. with this reason our
>> patches can't merge within proper merge window.
>
> I belive the last set where either being posted just-before or during
> the last merge window. We already had far too much queueud up then and
> we where trying to ensure that the already-queued entries where processed.

Not tell this case, please see the s5pc110 patches last year. last
year we sent the s5pc110 related patches several times. but you don't
give any opinions and can't accept without any reason.

Well it's past story,  forget it.

Last question.

I think you share the s3c maintainer-ship with Kukjin. Can you explain
the criteria?

Thank you,
Kyungmin Park

>
> The last call for updates went out on 13th May, and the two machine
> patches actually turned up on the 30th of May...
>
> It is important that we get these merges ready at least a week in
> advance of the merge window, otherwise there is _no_ time time to test
> the merged trees, and even worse there is little time to correct any
> mistakes... there where I belive two merge problems with trying to
> rebuild trees at the last minute ready to send to Linus.
>
> Unfortunately the S5PC100 moves did get overlooked (I think I may ended
> up dropping off the samsung-soc list) and the ended up producing a lot
> of the work involved in generating the pull request to RMK and then
> Linus. (see http://thread.gmane.org/gmane.linux.kernel.samsung-soc/1427)
>
> If we can organise ourselves better (and Kukjin will be taking over some
> of this work) then maybe we will have a much better experience for the
> next time.
>
>> >
>> >> Thank you,
>> >> Kyungmin Park
>> >>
>> >> On Fri, Jun 4, 2010 at 8:53 AM, Kyungmin Park <kmpark@infradead.org> wrote:
>> >> > Hi ben,
>> >> >
>> >> > There's some pending patches for s5pc110.
>> >> > 1. aquila & goni support files.
>> >
>> > these two should have gone in already
>>
>> I mean more aquila & goni patches. not basic support. e.g. OneNAND
>> support, FB support and so on.
>
> As above, I belive these where rather late on the horizon to be included.
>
>> >> > 2. keypad
>> >
>> > I think kukjin has been looking at this, best check with him.
>>
>> It's already discussed. do you think it needs more comments?
>
> Me, no. I think if Kukjin has no problems then it is up to Dimitry
> whether he wants to merge it.
>
>> >
>> >> > 3. s3c-fb - we have to implement FIMD and MIPI interface so please
>> >> > decide how to handle it.
>> >
>> > since we've not had any chance to discuss what is going on here
>> > I can't see how we are ready to submit anything.
>>
>> It's basic functionality for s3c-fb. it's required for our target and
>> want to use it. even though someone don't use it.
>>
>> I wonder some features are not used for other board. in this case it
>> should be merged if it doesn't break any previous board. Of course
>> with proper feedback. I think we answer your question doesn't it?
>
> The fb system is currently without a propler maintainer and Andrew Morton
> has been doing the job of applying patches. I don't know the reasons for
> the last round of development not going in, but it was probably due to it
> being too late.. I've so far been unable to actually subscribe to the new
> fb list to try and sort it out.
>
> This however doesn't cover the fact that there's been no movement on
> dicsussing what is needed to support FIMC addition to the framebuffer
> driver.
>
> Do you have even a list of things that you think are needed for this, or
> any actual patches we could look at and discuss?
>
> --
> Ben
>
> Q: ? ? ?What's a light-year?
> A: ? ? ?One-third less calories than a regular year.
>
>

Pending patches for s5pc110

[Ben Dooks]

On Fri, Jun 11, 2010 at 04:07:58PM +0900, Kyungmin Park wrote:
> On Fri, Jun 11, 2010 at 3:23 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> > On Fri, Jun 11, 2010 at 02:38:56PM +0900, Kyungmin Park wrote:
> >> On Fri, Jun 11, 2010 at 2:15 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> >> > On Fri, Jun 11, 2010 at 01:25:18PM +0900, Kyungmin Park wrote:
> >> >> Hi,
> >> >>
> >> >> No comments mean it's okay then we will prepare the patches to git pull.
> >> >
> >> > No. no comments means that people either haven't had time to sort
> >> > them out or in fact ON HOLIDAY.
> >>
> >> but you usually missed our patches frequently. with this reason our
> >> patches can't merge within proper merge window.
> >
> > I belive the last set where either being posted just-before or during
> > the last merge window. We already had far too much queueud up then and
> > we where trying to ensure that the already-queued entries where processed.
> 
> Not tell this case, please see the s5pc110 patches last year. last
> year we sent the s5pc110 related patches several times. but you don't
> give any opinions and can't accept without any reason.

I gave you comments, or at least Marke should have got them for the
series sent in November, then there's nothing in my mailbox since
then.
 
> Well it's past story,  forget it.
> 
> Last question.
> 
> I think you share the s3c maintainer-ship with Kukjin. Can you explain
> the criteria?

Ok, here's the list:

1) SystemLSI are the best placed to see all the chips in development,
   since they're the ones making them. You are only dealing with a
   subset of their output (generally the S5PC100 and S5PC110) whereas
   there are many more devices in the line.

2) SystemLSI have spent time talking to me about what they need to do
   when maintaining a system and trying to acquire the necessary skills
   for managing a port.

This does not mean that you cannot be included at a later date.

As a note, that I have left myself in the maintainers entries for the
samsung series and will re-visit this once we see how well the transfer
goes in the next kernel release or two.
 
-- 
Ben

Pending patches for s5pc110

[Kyungmin Park]

On Fri, Jun 11, 2010 at 4:54 PM, Ben Dooks <ben-linux@fluff.org> wrote:
> On Fri, Jun 11, 2010 at 04:07:58PM +0900, Kyungmin Park wrote:
>> On Fri, Jun 11, 2010 at 3:23 PM, Ben Dooks <ben-linux@fluff.org> wrote:
>> > On Fri, Jun 11, 2010 at 02:38:56PM +0900, Kyungmin Park wrote:
>> >> On Fri, Jun 11, 2010 at 2:15 PM, Ben Dooks <ben-linux@fluff.org> wrote:
>> >> > On Fri, Jun 11, 2010 at 01:25:18PM +0900, Kyungmin Park wrote:
>> >> >> Hi,
>> >> >>
>> >> >> No comments mean it's okay then we will prepare the patches to git pull.
>> >> >
>> >> > No. no comments means that people either haven't had time to sort
>> >> > them out or in fact ON HOLIDAY.
>> >>
>> >> but you usually missed our patches frequently. with this reason our
>> >> patches can't merge within proper merge window.
>> >
>> > I belive the last set where either being posted just-before or during
>> > the last merge window. We already had far too much queueud up then and
>> > we where trying to ensure that the already-queued entries where processed.
>>
>> Not tell this case, please see the s5pc110 patches last year. last
>> year we sent the s5pc110 related patches several times. but you don't
>> give any opinions and can't accept without any reason.
>
> I gave you comments, or at least Marke should have got them for the
> series sent in November, then there's nothing in my mailbox since
> then.
>
>> Well it's past story, ?forget it.
>>
>> Last question.
>>
>> I think you share the s3c maintainer-ship with Kukjin. Can you explain
>> the criteria?
>
> Ok, here's the list:
>
> 1) SystemLSI are the best placed to see all the chips in development,
> ? since they're the ones making them. You are only dealing with a
> ? subset of their output (generally the S5PC100 and S5PC110) whereas
> ? there are many more devices in the line.
>
> 2) SystemLSI have spent time talking to me about what they need to do
> ? when maintaining a system and trying to acquire the necessary skills
> ? for managing a port.

That's enough.

>
> This does not mean that you cannot be included at a later date.
>
> As a note, that I have left myself in the maintainers entries for the
> samsung series and will re-visit this once we see how well the transfer
> goes in the next kernel release or two.

I see.

Just opinion I hope you're more focus on difficult issues such as
reserved memory handling at used
continuous memory management at multimedia IPs and clock & power
gating to reduce the power at Samsung SoCs.

Have good holiday.

Thank you,
Kyungmin Park