From mboxrd@z Thu Jan 1 00:00:00 1970 From: jean.pihet@newoldbits.com (Jean Pihet) Date: Thu, 16 Dec 2010 19:17:04 +0100 Subject: [PATCH v3] OMAP3: clean up ASM idle code In-Reply-To: <20101214224214.GB14990@atomide.com> References: <1292347603-17703-1-git-send-email-j-pihet@ti.com> <20101214224214.GB14990@atomide.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Tony, On Tue, Dec 14, 2010 at 11:42 PM, Tony Lindgren wrote: > Hi Jean, > > * jean.pihet at newoldbits.com [101214 09:28]: >> From: Jean Pihet >> >> This patch only contains clean-ups and cosmetic changes, >> no functional change. >> >> Clean up of the ASM code: >> - reorganized the code in logical sections: defines, API >> ? ?functions, internal functions and variables, >> - reworked and simplified the execution paths, for better >> ? ?readability and to avoid duplication of code, >> - added comments on the entry and exit points and the interaction >> ? ?with the ROM code for OFF mode restore, >> - reworked the existing comments for better readability, >> - reworked the code formating, alignment and white spaces, >> - added comments for the i443 erratum workarounds, >> - changed the hardcoded values in favor of existing macros >> ? ?from include files, >> - clean up of non used symbols. > > Can you please split it further, it's not obvious from reading it > that it does not change anything. That makes sense indeed. > How about first do one or more patches to move the code around. > Then rework the comments and formatting. I just re-sent the changes as a series '[PATCH 0/7 v4] OMAP3: clean up ASM sleep code'. The patches are now much more readable and it also allowed me to solve issues in a more generic way, cf. for example '[PATCH 2/7] OMAP2+: use global values for the SRAM PA addresses'. > > Thanks, > > Tony > Thanks, Jean