linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: per.fransson.ml@gmail.com (Per Fransson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Add call to non-crashing cores through IPI
Date: Mon, 22 Nov 2010 18:03:03 +0100	[thread overview]
Message-ID: <AANLkTinj5wnP4823bacK6rs3nQbw3qtqDDjYof2-ALUk@mail.gmail.com> (raw)
In-Reply-To: <20101122144040.GM31227@n2100.arm.linux.org.uk>

On the other hand, do we really need to enable the interrupts before
performing an ipi?
The important thing must be for them to be enabled on the
receiving/callee cores. It's not
as if we want the crashing core to be interruptable, is it?

I tried it and it seems to work fine.

/Per

On Mon, Nov 22, 2010 at 3:40 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Mon, Nov 22, 2010 at 03:31:24PM +0100, Per Fransson wrote:
>> On Mon, Nov 22, 2010 at 12:27 PM, Russell King - ARM Linux
>> <linux@arm.linux.org.uk> wrote:
>> > On Mon, Nov 22, 2010 at 10:47:40AM +0000, Russell King - ARM Linux wrote:
>> >> However, we do need smp_send_stop() to wait for a limited time for the
>> >> other CPUs to respond to the request.
>> >
>> > ARM: smp: make smp_send_stop() wait for secondary CPUs to stop
>> >
>> > Wait up to one second for secondary CPUs to respond to a request to
>> > stop. ?This avoids the sender CPU continuing and possibly destroying
>> > state before the recipients have had a chance to respond to the stop.
>> > However, if the recipients have crashed, we won't hang the sender
>> > CPU indefinitely.
>> >
>>
>> The point of the crash kernel functionality is to make it possible to grab a
>> snapshot of the system at the time of the crash. smp_send_stop() will
>> take the other cores offline, which makes the snapshot differ from the
>> crash state more than it has to. To be more concrete, any core dump
>> analysis tool which reads the cpu_online_mask to determine the number
>> of cpus in use will get an incorrect picture.
>
> Well, you can't go around randomly enabling interrupts to call functions
> that require interrupts to be enabled, so I guess it's not possible to
> save the state of the other cores.
>
> I guess you're going to have to come up with another solution.
>

  reply	other threads:[~2010-11-22 17:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19 10:08 [PATCH] Add call to non-crashing cores through IPI Per Fransson
2010-11-22  7:24 ` Mika Westerberg
2010-11-22  9:47   ` Maxim Uvarov
2010-11-22  9:53   ` Per Fransson
2010-11-22 10:47     ` Russell King - ARM Linux
2010-11-22 11:27       ` Russell King - ARM Linux
2010-11-22 13:07         ` Santosh Shilimkar
2010-11-22 14:21           ` Russell King - ARM Linux
2010-11-22 17:25             ` Santosh Shilimkar
2010-11-22 14:31         ` Per Fransson
2010-11-22 14:40           ` Russell King - ARM Linux
2010-11-22 17:03             ` Per Fransson [this message]
2010-11-22 17:12               ` Catalin Marinas
2010-11-22 20:09                 ` Maxim Uvarov
2010-11-22 22:14                   ` Per Fransson
2010-11-22 22:30                     ` Per Fransson
2010-11-23  9:14                   ` Catalin Marinas
2010-11-23 10:57                     ` Per Fransson
2010-11-23 12:37                       ` Catalin Marinas
2010-11-23 12:41                         ` Mika Westerberg
2010-11-23 12:48                           ` Catalin Marinas
2010-11-23 13:01                             ` Maxim Uvarov
2010-11-23 16:31                               ` Per Fransson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTinj5wnP4823bacK6rs3nQbw3qtqDDjYof2-ALUk@mail.gmail.com \
    --to=per.fransson.ml@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).