From: eric.miao@canonical.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] dove: fix __io() definition to use bus based offset
Date: Thu, 29 Jul 2010 13:45:35 +0800 [thread overview]
Message-ID: <AANLkTinuXRH0XeD=3b0Wmq32SEEBxdevfj58EmSybcWu@mail.gmail.com> (raw)
[ARM] dove: fix __io() definition to use bus based offset
__io() should be based on DOVE_PCIE0_IO_BUS_BASE instead of _PHYS_BASE,
and use __typesafe_io() for consistency.
Cc: Nicolas Pitre <nico@fluxnic.net>
Cc: Lennert Buijtenhek <buytenh@wantstofly.org>
Cc: Saeed Bishara <saeed@marvell.com>
Signed-off-by: Eric Miao <eric.miao@canonical.com>
diff --git a/arch/arm/mach-dove/include/mach/io.h
b/arch/arm/mach-dove/include/mach/io.h
index 3b3e472..067435e 100644
--- a/arch/arm/mach-dove/include/mach/io.h
+++ b/arch/arm/mach-dove/include/mach/io.h
@@ -11,10 +11,9 @@
#include "dove.h"
-#define IO_SPACE_LIMIT 0xffffffff
-
-#define __io(a) ((void __iomem *)(((a) - DOVE_PCIE0_IO_PHYS_BASE) +\
- DOVE_PCIE0_IO_VIRT_BASE))
-#define __mem_pci(a) (a)
+#define IO_SPACE_LIMIT 0xffffffff
+#define __io(a) __typesafe_io((a) - DOVE_PCIE0_IO_BUS_BASE + \
+ DOVE_PCIE0_IO_VIRT_BASE)
+#define __mem_pci(a) (a)
#endif
next reply other threads:[~2010-07-29 5:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 5:45 Eric Miao [this message]
2010-07-29 15:26 ` [RFC] dove: fix __io() definition to use bus based offset Arnd Bergmann
2010-07-29 15:34 ` Eric Miao
2010-07-29 15:49 ` Arnd Bergmann
2010-08-01 11:39 ` Saeed Bishara
2010-07-31 11:08 ` Russell King - ARM Linux
2010-07-31 19:21 ` Arnd Bergmann
2010-07-31 20:47 ` Russell King - ARM Linux
2010-08-02 10:59 ` Arnd Bergmann
2010-08-02 11:24 ` Russell King - ARM Linux
2010-08-02 15:44 ` Arnd Bergmann
2010-08-03 9:08 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTinuXRH0XeD=3b0Wmq32SEEBxdevfj58EmSybcWu@mail.gmail.com' \
--to=eric.miao@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).