From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 769ABC433EF for ; Sat, 9 Apr 2022 00:11:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vOWyIjxiM0F6jgMtKg3aSFFCzwPhV3blcuxKMiVkaPA=; b=UMPiYTU8+XswQt T+AUkS8gnJaCpsivOnTHdhyUgaZa/d9egEhIMaeMAaLNNYQavnnQgCpDzhSsGUoCN/5Ymx6XC9O8W 6mgmEzk/1oFTkMP08LsVf7OPs0onrOJIVU7RoBhbsbLUUO0lAgyHCdNMa3Z56qCU1ZhvroW9xjRq+ Q82XUejE5MWQYtjBqcKHwMQch7noii+swxtdm39p2u+35n95Ytquy4hACp2+jjlEtLDfqYx6a4dmF YKMrb77qDehImv7h1R+/qyS7GrLx2hiNbj+jYcE0jyLfnpw7zabjHD8UVNXFC0X3lkvUWLGpRcCnw DS9B2KermvFCYevtKgaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncygS-001XyW-VZ; Sat, 09 Apr 2022 00:10:33 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ncygP-001Xxd-L9 for linux-arm-kernel@lists.infradead.org; Sat, 09 Apr 2022 00:10:31 +0000 Received: by mail-wr1-x432.google.com with SMTP id r13so15049485wrr.9 for ; Fri, 08 Apr 2022 17:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Em4XLbKn3weeywAuYbLh67KeJT9mzRe61DWplVcKypI=; b=naC9lKldrkSC7zCNFHhRAhqGVylvW15bkJQAqbkOKBWu7ygsCW7RbzcCayG3jCmi15 Z17Hl61Nd70wx+plx5gpgJccrGheKPucirRczR2qSH+bdSOFKkTGLaimnmt0QSIedPHd 6LEfWoxB4+vmvFcRQ2FzmnD1Upp7GVpVposZ5+MgKTU7z7mzymjGpbjC6pJH3Iw0jnP5 zUSwfuNlHPdZqjAs9DNOxxJUJbDhZKsK1ztu+U13BmJefTSRslhyvZL4HW9w+ZkAX4q6 eLRdyeLZk35841OgOMea3Ei245zZ0hZuxWYVq9No4cTXAde0yllcDHtvWhaglNko2x70 ezYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Em4XLbKn3weeywAuYbLh67KeJT9mzRe61DWplVcKypI=; b=TEnk99+w5ITCPwFCc5DvnTYVeDSplw7xy+FkvzT7bwi/Zszzdtj9aGZ74kKgqLY2Ua tFOshFHJvNA6aJGjN4TV/t+C/i2hbEJfG+00AaWxj1abRnqb79uJPkKLPsa5r10deUR9 RwyWwbWssmNur+KWugNmy5Lc36GGxPfIlhW038LePbfXdawqZlASOO3md0BXpz8u7gFg puH3Qf1U7oXamnP7huYSvFlSd6xxaYiCp26lo/xAgqtUPIwXKAlOt4er0AY2W07AB41F ggLmcpKoXttNpORH6exsQom1F+9EmAzupDPumGnC3Mc0POZ3S3EEn6rbiboKTyyBzhV+ vsAA== X-Gm-Message-State: AOAM532ccr+xF8LnpmJKwOEIp1oAahD1lJJ5fZwQWixAp10AGKWhWK1s NEignfcjQ93KYQgJTjYLSE8= X-Google-Smtp-Source: ABdhPJzmLwsA1+SOQhHbzMNFbQhPfQg3DyyzoBI32JG9626vpPcnl/Yxmvz41FJyi8uwyoDEhq0KAw== X-Received: by 2002:a5d:558f:0:b0:206:c79:8d46 with SMTP id i15-20020a5d558f000000b002060c798d46mr16261274wrv.628.1649463027998; Fri, 08 Apr 2022 17:10:27 -0700 (PDT) Received: from smtpclient.apple ([185.238.38.242]) by smtp.gmail.com with ESMTPSA id c186-20020a1c35c3000000b0038e6c6fc860sm11450767wma.37.2022.04.08.17.10.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Apr 2022 17:10:27 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: [PATCH net-next 11/15] sfc: Remove usage of list iterator for list_add() after the loop body From: Jakob Koschel In-Reply-To: <4520e9c5-8871-b281-f621-ac737e64333b@gmail.com> Date: Sat, 9 Apr 2022 02:10:24 +0200 Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, Ariel Elior , Manish Chopra , Martin Habets , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jiri Pirko , Casper Andersson , Bjarni Jonasson , Colin Ian King , Michael Walle , Christophe JAILLET , Arnd Bergmann , Eric Dumazet , Di Zhu , Xu Wang , Netdev , LKML , Linux ARM , linuxppc-dev , Mike Rapoport , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." Message-Id: References: <20220407102900.3086255-1-jakobkoschel@gmail.com> <20220407102900.3086255-12-jakobkoschel@gmail.com> <4520e9c5-8871-b281-f621-ac737e64333b@gmail.com> To: Edward Cree X-Mailer: Apple Mail (2.3696.80.82.1.1) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220408_171029_738888_B3BA7DA2 X-CRM114-Status: GOOD ( 34.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gRWR3YXJkLAoKPiBPbiA3LiBBcHIgMjAyMiwgYXQgMTk6NDIsIEVkd2FyZCBDcmVlIDxl Y3JlZS54aWxpbnhAZ21haWwuY29tPiB3cm90ZToKPiAKPiBPbiAwNy8wNC8yMDIyIDExOjI4LCBK YWtvYiBLb3NjaGVsIHdyb3RlOgo+PiBJbiBwcmVwYXJhdGlvbiB0byBsaW1pdCB0aGUgc2NvcGUg b2YgYSBsaXN0IGl0ZXJhdG9yIHRvIHRoZSBsaXN0Cj4+IHRyYXZlcnNhbCBsb29wLCB1c2UgYSBk ZWRpY2F0ZWQgcG9pbnRlciB0byBwb2ludCB0byB0aGUgZm91bmQgZWxlbWVudCBbMV0uCj4+IAo+ PiBCZWZvcmUsIHRoZSBjb2RlIGltcGxpY2l0bHkgdXNlZCB0aGUgaGVhZCB3aGVuIG5vIGVsZW1l bnQgd2FzIGZvdW5kCj4+IHdoZW4gdXNpbmcgJnBvcy0+bGlzdC4gU2luY2UgdGhlIG5ldyB2YXJp YWJsZSBpcyBvbmx5IHNldCBpZiBhbgo+PiBlbGVtZW50IHdhcyBmb3VuZCwgdGhlIGxpc3RfYWRk KCkgaXMgcGVyZm9ybWVkIHdpdGhpbiB0aGUgbG9vcAo+PiBhbmQgb25seSBkb25lIGFmdGVyIHRo ZSBsb29wIGlmIGl0IGlzIGRvbmUgb24gdGhlIGxpc3QgaGVhZCBkaXJlY3RseS4KPj4gCj4+IExp bms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC9DQUhrLT13Z1JyX0Q4Q0ItRDlLZy1jPUVI cmVBc2s1U3FYUHdyOVk3azlzQTZjV1hKNndAbWFpbC5nbWFpbC5jb20vIFsxXQo+PiBTaWduZWQt b2ZmLWJ5OiBKYWtvYiBLb3NjaGVsIDxqYWtvYmtvc2NoZWxAZ21haWwuY29tPgo+IAo+IFRoZSBj b21taXQgbWVzc2FnZSBkb2Vzbid0IGFjY3VyYXRlbHkgZGVzY3JpYmUgdGhlIHBhdGNoOyBpdCBz dGF0ZXMKPiB0aGF0ICJ0aGUgbGlzdF9hZGQoKSBpcyBwZXJmb3JtZWQgd2l0aGluIHRoZSBsb29w Iiwgd2hpY2ggZG9lc24ndAo+IGFwcGVhciB0byBiZSB0aGUgY2FzZS4KCnlvdSdyZSByaWdodCwg SSd2ZSBjaGFuZ2VkIHRoZSBjb2RlIGxhc3QgbWludXRlLiBJJ2xsIG1ha2Ugc3VyZQp0aGUgY2hh bmdlbG9nIHJlZmxlY3RzIHRoZSBhY3R1YWwgYmVoYXZpb3VyIGhlcmUuIFRoYW5rcyBmb3IgdGhl CmlucHV0IQoKPiBBbHNvIGl0IHNlZW1zIGEgYml0IHN1YnRsZSB0byB1c2UgYGhlYWRgIGFzIGJv dGggdGhlIGhlYWQgb2YgdGhlCj4gbGlzdCB0byBpdGVyYXRlIG92ZXIgYW5kIHRoZSBmb3VuZCBl bnRyeS9nYXAgdG8gaW5zZXJ0IGJlZm9yZTsgYQo+IGNvbW1lbnQgZXhwbGFpbmluZyB0aGF0IHdv dWxkbid0IGdvIGFtaXNzLgoKQWxzbyBhIGdvb2QgcG9pbnQsIEknbGwgYWRkIGEgY29tbWVudCBh cyB3ZWxsLCBvciBwZXJoYXBzIHVzaW5nCmEgc2VwYXJhdGUgJ3N0cnVjdCBsaXN0X2hlYWQgKnBv cycgdmFyaWFibGUgaXMgZXZlbiBjbGVhbmVyLgoKPiAoSSdkIHF1ZXN0aW9uIHdoZXRoZXIgdGhp cyBjaGFuZ2UgaXMgcmVhbGx5IGFuIGltcHJvdmVtZW50IGluIHRoaXMKPiBjYXNlLCB3aGVyZSB0 aGUgaXRlcmF0b3IgcmVhbGx5IGRvZXMgaG9sZCB0aGUgdGhpbmcgd2Ugd2FudCBhdCB0aGUKPiBl bmQgb2YgdGhlIHNlYXJjaCBhbmQgc28gdGhlcmUncyBubyBpZihmb3VuZCkgc3BlY2lhbC1jYXNp bmcg4oCUCj4gd2UncmUgbm90IGV2ZW4gYWJ1c2luZyB0aGUgdHlwZSBzeXN0ZW0sIGJlY2F1c2Ug ZWZ4LT5yc3NfY29udGV4dAo+IGlzIG9mIHRoZSBzYW1lIHR5cGUgYXMgYWxsIHRoZSBsaXN0IGVu dHJpZXMsIHNvIGN0eCByZWFsbHkgaXMgYQo+IHZhbGlkIHBvaW50ZXIgYW5kIHRoZXJlIHNob3Vs ZG4ndCBiZSBhbnkgaXNzdWVzIHdpdGggc3BlY3VsYXRpdmUKPiBhY2Nlc3NlcyBvciB3aGF0ZXZl ciDigJQgYnV0IGl0IHNlZW1zIExpbnVzIGhhcyBhbHJlYWR5IHByb25vdW5jZWQKPiBpbiBmYXZv dXIgb2YgdGhlIHNjb3BlIGxpbWl0aW5nLCBhbmQgZmFyIGJlIGl0IGZyb20gbWUgdG8gZ2FpbnNh eQo+IGhpbS4pCgpTbywgc2luY2UgdGhlIGhlYWQgaXMgaW5jbHVkZWQgaW4gdGhlIHN0cnVjdCBv ZiB0aGUgc2FtZSB0eXBlIGFzCnRoZSBlbGVtZW50LCBpdCByZWFsbHkgZG9lc24ndCBtYWtlIG11 Y2ggb2YgYSBkaWZmZXJlbmNlIGhlcmUuCkl0IHdpbGwgYWx3YXlzIGJlIHNhZmUgdG8gdXNlLgoK QnV0IHRoaXMgaXMgdGhlIHZlcnkgcmFyZSBleGNlcHRpb24uIFRoZXJlIGFyZSBvdGhlciBiZW5l Zml0cyBvZgphdm9pZGluZyB0aGUgdXNlIG9mIGxpc3QgaXRlcmF0b3IgYWZ0ZXIgdGhlIGxvb3Au IE9uZSBvZiB0aGVtCmlzIHNjb3BlIGxpbWl0aW5nIGJ1dCB5b3UgYWxzbyBtaWdodCB3YW50IHRv IHNldCB0aGUgaXRlcmF0b3IKdmFyaWFibGUgdG8gYSAic2FmZSB2YWx1ZSIgYmVmb3JlIHRoZSBw cm9jZXNzb3IgbWlnaHQgZXhlY3V0ZSBhbiBhZGRpdGlvbmFsCml0ZXJhdGlvbiBpbiBzcGVjdWxh dGl2ZSBleGVjdXRpb24gb24gdGhlICdib2d1cycgaGVhZCBlbGVtZW50LgoKSWYgeW91IGRvIHRo ZXNlIGtpbmQgb2YgcGF0Y2hlcyBvbiB0aGUgbGlzdCBtYWNyb3MsIHlvdSBuZWVkIHRvIG1ha2Ug c3VyZQp0aGV5IHdvcmsgZm9yIGFsbCB0aGUgdXNlcywgaW5jbHVkaW5nIHRoZSBzYWZlIG9uZXMg KGxpa2UgdGhpcyBvbmUpLgoKPiAKPiAtZWQKPiAKPj4gLS0tCj4+IGRyaXZlcnMvbmV0L2V0aGVy bmV0L3NmYy9yeF9jb21tb24uYyB8IDYgKysrKy0tCj4+IDEgZmlsZSBjaGFuZ2VkLCA0IGluc2Vy dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQv ZXRoZXJuZXQvc2ZjL3J4X2NvbW1vbi5jIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvc2ZjL3J4X2Nv bW1vbi5jCj4+IGluZGV4IDFiMjJjN2JlMDA4OC4uYTg4MjIxNTJmZjgzIDEwMDY0NAo+PiAtLS0g YS9kcml2ZXJzL25ldC9ldGhlcm5ldC9zZmMvcnhfY29tbW9uLmMKPj4gKysrIGIvZHJpdmVycy9u ZXQvZXRoZXJuZXQvc2ZjL3J4X2NvbW1vbi5jCj4+IEBAIC01NjMsOCArNTYzLDEwIEBAIHN0cnVj dCBlZnhfcnNzX2NvbnRleHQgKmVmeF9hbGxvY19yc3NfY29udGV4dF9lbnRyeShzdHJ1Y3QgZWZ4 X25pYyAqZWZ4KQo+PiAKPj4gCS8qIFNlYXJjaCBmb3IgZmlyc3QgZ2FwIGluIHRoZSBudW1iZXJp bmcgKi8KPj4gCWxpc3RfZm9yX2VhY2hfZW50cnkoY3R4LCBoZWFkLCBsaXN0KSB7Cj4+IC0JCWlm IChjdHgtPnVzZXJfaWQgIT0gaWQpCj4+ICsJCWlmIChjdHgtPnVzZXJfaWQgIT0gaWQpIHsKPj4g KwkJCWhlYWQgPSAmY3R4LT5saXN0Owo+PiAJCQlicmVhazsKPj4gKwkJfQo+PiAJCWlkKys7Cj4+ IAkJLyogQ2hlY2sgZm9yIHdyYXAuICBJZiB0aGlzIGhhcHBlbnMsIHdlIGhhdmUgbmVhcmx5IDJe MzIKPj4gCQkgKiBhbGxvY2F0ZWQgUlNTIGNvbnRleHRzLCB3aGljaCBzZWVtcyB1bmxpa2VseS4K Pj4gQEAgLTU4Miw3ICs1ODQsNyBAQCBzdHJ1Y3QgZWZ4X3Jzc19jb250ZXh0ICplZnhfYWxsb2Nf cnNzX2NvbnRleHRfZW50cnkoc3RydWN0IGVmeF9uaWMgKmVmeCkKPj4gCj4+IAkvKiBJbnNlcnQg dGhlIG5ldyBlbnRyeSBpbnRvIHRoZSBnYXAgKi8KPj4gCW5ldy0+dXNlcl9pZCA9IGlkOwo+PiAt CWxpc3RfYWRkX3RhaWwoJm5ldy0+bGlzdCwgJmN0eC0+bGlzdCk7Cj4+ICsJbGlzdF9hZGRfdGFp bCgmbmV3LT5saXN0LCBoZWFkKTsKPj4gCXJldHVybiBuZXc7Cj4+IH0KPj4gCj4+IAo+IAoKVGhh bmtzLApKYWtvYgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK