From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Nori, Sekhar) Date: Tue, 22 Mar 2011 15:13:46 +0530 Subject: [PATCH v3 1/7] mfd: add pruss mfd driver. In-Reply-To: References: <1299592667-21367-1-git-send-email-subhasish@mistralsolutions.com> <1299592667-21367-2-git-send-email-subhasish@mistralsolutions.com> <20110318123917.GC27129@sirena.org.uk> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Mar 22, 2011 at 15:05:07, Nori, Sekhar wrote: > Hi Mark, > > On Fri, Mar 18, 2011 at 18:09:17, Mark Brown wrote: > > On Fri, Mar 18, 2011 at 05:29:39PM +0530, Nori, Sekhar wrote: > > > > > PRUSS as an IP is not really tied to the DA8xx SoC architecture. > > > So, can you please name the files ti-pruss* or even just pruss if > > > MFD folks are okay with it? > > > > This... > > > > > > +EXPORT_SYMBOL(pruss_get_clk_freq); > > > > > This looks strange. Why do we need this? There > > > is clk_get_rate() API in the kernel would would > > > seem more suitable. > > > > ...unfortunately conflicts with this - currently all clock API > > implementations are unique to the platform and there's no way of adding > > clocks that works over multiple platforms. > > Hmm, I guess I have a limited view of this. We do have drivers which > use clock API and work across OMAP and DaVinci series of ARM SoCs. > The clock implementation in this case is under mach-omap and mach-davinci This should have read "under plat-omap/mach-omap2 and mach-davinci" Thanks, Sekhar