From: weitway@gmail.com (Jason Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mx53/loco: add pwm backlight device
Date: Wed, 13 Apr 2011 07:43:23 +0800 [thread overview]
Message-ID: <BANLkTi=+1EzK5ZxaAsRRT-e9HzyR3SRUqw@mail.gmail.com> (raw)
In-Reply-To: <20110404160855.GF13963@pengutronix.de>
hi, Uwe,
Thanks for your comments, I will resend this series patches.
2011/4/5 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> On Fri, Mar 04, 2011 at 10:51:26AM +0800, Jason Chen wrote:
>> Signed-off-by: Jason Chen <b02280@freescale.com>
>> ---
>> ?arch/arm/mach-mx5/Kconfig ? ? ? ? ? | ? ?1 +
>> ?arch/arm/mach-mx5/board-mx53_loco.c | ? 11 +++++++++++
>> ?arch/arm/mach-mx5/devices-imx53.h ? | ? ?4 ++++
>> ?3 files changed, 16 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-mx5/Kconfig b/arch/arm/mach-mx5/Kconfig
>> index f065a0d..baf5223 100644
>> --- a/arch/arm/mach-mx5/Kconfig
>> +++ b/arch/arm/mach-mx5/Kconfig
>> @@ -162,6 +162,7 @@ config MACH_MX53_LOCO
>> ? ? ? select IMX_HAVE_PLATFORM_IMX2_WDT
>> ? ? ? select IMX_HAVE_PLATFORM_IMX_I2C
>> ? ? ? select IMX_HAVE_PLATFORM_IMX_UART
>> + ? ? select IMX_HAVE_PLATFORM_MXC_PWM
>> ? ? ? help
>> ? ? ? ? Include support for MX53 LOCO platform. This includes specific
>> ? ? ? ? configurations for the board and its peripherals.
>> diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
>> index 160899e..3b0b200 100644
>> --- a/arch/arm/mach-mx5/board-mx53_loco.c
>> +++ b/arch/arm/mach-mx5/board-mx53_loco.c
>> @@ -23,6 +23,7 @@
>> ?#include <linux/fec.h>
>> ?#include <linux/delay.h>
>> ?#include <linux/gpio.h>
>> +#include <linux/pwm_backlight.h>
>>
>> ?#include <mach/common.h>
>> ?#include <mach/hardware.h>
>> @@ -203,6 +204,13 @@ static const struct imxi2c_platform_data mx53_loco_i2c_data __initconst = {
>> ? ? ? .bitrate = 100000,
>> ?};
>>
>> +static struct platform_pwm_backlight_data loco_pwm_backlight_data = {
>> + ? ? .pwm_id = 1,
>> + ? ? .max_brightness = 255,
>> + ? ? .dft_brightness = 128,
>> + ? ? .pwm_period_ns = 50000,
>> +};
>> +
>> ?static void __init mx53_loco_board_init(void)
>> ?{
>> ? ? ? mxc_iomux_v3_setup_multiple_pads(mx53_loco_pads,
>> @@ -213,6 +221,9 @@ static void __init mx53_loco_board_init(void)
>> ? ? ? imx53_add_imx2_wdt(0, NULL);
>> ? ? ? imx53_add_imx_i2c(0, &mx53_loco_i2c_data);
>> ? ? ? imx53_add_imx_i2c(1, &mx53_loco_i2c_data);
>> +
>> + ? ? imx53_add_mxc_pwm(1);
> can you please resend this with the series adding this function when
> addressing the comments I just gave.
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. ? ? ? ? ? ? ? ? ? ? ? ? ? | Uwe Kleine-K?nig ? ? ? ? ? ?|
> Industrial Linux Solutions ? ? ? ? ? ? ? ? | http://www.pengutronix.de/ ?|
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
prev parent reply other threads:[~2011-04-12 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 2:51 [PATCH] ARM: mx53/loco: add pwm backlight device Jason Chen
2011-04-04 16:08 ` Uwe Kleine-König
2011-04-12 23:43 ` Jason Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=+1EzK5ZxaAsRRT-e9HzyR3SRUqw@mail.gmail.com' \
--to=weitway@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).