From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: ep93xx: move driver to drivers/gpio
Date: Wed, 1 Jun 2011 10:46:00 -0600 [thread overview]
Message-ID: <BANLkTi=0_t6+=8Ww+a+jX4SR5ni9KQnYqA@mail.gmail.com> (raw)
In-Reply-To: <20110601082631.GC3660@n2100.arm.linux.org.uk>
On Wed, Jun 1, 2011 at 2:26 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Tue, May 31, 2011 at 05:28:26PM -0600, Grant Likely wrote:
>> > [...]Should I change this to:
>> >
>> > +config GPIO_EP93XX
>> > + ? ? ? bool
>> > + ? ? ? depends on ARCH_EP93XX
>> > + ? ? ? default y
>> >
>> > Or like the Samsung drivers, without the visibility:
>> >
>> > +config GPIO_EP93XX
>> > + ? ? ? bool
>> > + ? ? ? depends on ARM
>> > + ? ? ? default y if ARCH_EP93XX
>>
>> I like the former.
>
> Even better is:
>
> config GPIO_EP93XX
> ? ? ? ?def_bool y
> ? ? ? ?depends on ARCH_EP93XX
Yup.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2011-06-01 16:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 19:49 [PATCH] gpio: ep93xx: move driver to drivers/gpio H Hartley Sweeten
2011-05-31 20:40 ` Grant Likely
2011-05-31 22:37 ` H Hartley Sweeten
2011-05-31 23:28 ` Grant Likely
2011-06-01 8:26 ` Russell King - ARM Linux
2011-06-01 16:46 ` Grant Likely [this message]
2011-06-01 17:24 ` H Hartley Sweeten
2011-06-02 2:44 ` Kyungmin Park
2011-06-02 16:55 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=0_t6+=8Ww+a+jX4SR5ni9KQnYqA@mail.gmail.com' \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).