linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: per.forlin@linaro.org (Per Forlin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 00/11] mmc: use nonblock mmc requests to minimize latency
Date: Fri, 24 Jun 2011 10:58:31 +0200	[thread overview]
Message-ID: <BANLkTi=8Awu4Z3ESizE9WDEyWNw0r9N0ug@mail.gmail.com> (raw)
In-Reply-To: <20110623133702.GZ23234@n2100.arm.linux.org.uk>

On 23 June 2011 15:37, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> On Tue, Jun 21, 2011 at 11:26:27AM +0200, Per Forlin wrote:
>> Here are the results.
>
> It looks like this patch is either a no-op or slightly worse. ?As
> people have been telling me that dsb is rather expensive, and this
> patch results in less dsbs, I'm finding these results hard to believe.
> It seems to be saying that dsb is an effective no-op on your platform.
>
The result of your patch depends on the number of sg-elements. With
your patch there is only on DSB per list instead of element I can
write a test to measure performance per number of sg-element in the
sg-list. Fixed transfer size but vary the number of sg-elements in the
list. This test may give a better understanding of the affect.

I have seen performance gain if using __raw_write instead of writel.
Writel test includes both the cost of DSB and the outer_sync, where
outer_sync is more expensive one I presume.

> So either people are wrong about dsb being expensive, the patch is
> wrong, or there's something wrong with these results/test method.
>
> You do have an error in the ported patch, as that hasn't updated the
> v7 cache cleaning code to remove the dsb() there, but that would only
> affect the write tests.
>
I will fix that mistake and also improve the test cases to measure the
cost per number of sg-elements.

I'll come back with new numbers on Monday.

Regards,
Per

  reply	other threads:[~2011-06-24  8:58 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-19 21:17 [PATCH v6 00/11] mmc: use nonblock mmc requests to minimize latency Per Forlin
2011-06-19 21:17 ` [PATCH v6 01/11] mmc: add non-blocking mmc request function Per Forlin
2011-06-19 21:17 ` [PATCH v6 02/11] omap_hsmmc: add support for pre_req and post_req Per Forlin
2011-06-21  5:41   ` Kishore Kadiyala
2011-06-21  6:51     ` Per Forlin
2011-06-21 13:56       ` Kishore Kadiyala
2011-06-21 19:18       ` Nicolas Pitre
2011-06-21 20:18         ` Per Forlin
2011-06-21 20:29           ` Nicolas Pitre
2011-06-19 21:17 ` [PATCH v6 03/11] mmci: implement pre_req() and post_req() Per Forlin
2011-06-19 21:17 ` [PATCH v6 04/11] mmc: mmc_test: add debugfs file to list all tests Per Forlin
2011-06-19 21:17 ` [PATCH v6 05/11] mmc: mmc_test: add test for non-blocking transfers Per Forlin
2011-06-19 21:17 ` [PATCH v6 06/11] mmc: add member in mmc queue struct to hold request data Per Forlin
2011-06-19 21:17 ` [PATCH v6 07/11] mmc: add a block request prepare function Per Forlin
2011-06-19 21:17 ` [PATCH v6 08/11] mmc: move error code in mmc_block_issue_rw_rq to a separate function Per Forlin
2011-06-19 21:17 ` [PATCH v6 09/11] mmc: add a second mmc queue request member Per Forlin
2011-06-19 21:17 ` [PATCH v6 10/11] mmc: test: add random fault injection in core.c Per Forlin
2011-06-19 21:17 ` [PATCH v6 11/11] mmc: add handling for two parallel block requests in issue_rw_rq Per Forlin
2011-06-20 15:17   ` Kishore Kadiyala
2011-06-21  6:40     ` Per Forlin
2011-06-21  7:05       ` Per Forlin
2011-06-21 13:52         ` Kishore Kadiyala
2011-06-21 21:01     ` Per Forlin
2011-06-21  7:14   ` Per Forlin
2011-06-21  7:53 ` [PATCH v6 00/11] mmc: use nonblock mmc requests to minimize latency Russell King - ARM Linux
2011-06-21  8:09   ` Per Forlin
2011-06-21  9:26     ` Per Forlin
2011-06-23 13:37       ` Russell King - ARM Linux
2011-06-24  8:58         ` Per Forlin [this message]
2011-06-27  9:42           ` Per Forlin
2011-06-27 10:02             ` Russell King - ARM Linux
2011-06-27 10:21               ` Per Forlin
2011-06-27 15:29               ` Linus Walleij
2011-06-27 16:34                 ` Vijaya Kumar K-1
2011-06-27 10:34   ` saeed bishara
2011-06-27 11:02     ` Russell King - ARM Linux
2011-06-28  6:22       ` saeed bishara
2011-07-03 14:47         ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTi=8Awu4Z3ESizE9WDEyWNw0r9N0ug@mail.gmail.com' \
    --to=per.forlin@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).