From: eric.y.miao@gmail.com (Eric Miao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa: Fix PGSR register address calculation
Date: Mon, 9 May 2011 11:48:57 +0800 [thread overview]
Message-ID: <BANLkTi=N5YWeouh6U8sxByR9eAFmBiT8SA@mail.gmail.com> (raw)
In-Reply-To: <E1QItCc-0003up-FQ@outmx08.plus.net>
On Sun, May 8, 2011 at 9:54 AM, Paul Parsons <lost.distance@yahoo.com> wrote:
> The file mfp-pxa2xx.c defines a macro, PGSR(), which translates a gpio bank number to a PGSR register address. The function pxa2xx_mfp_suspend() erroneously passed in a gpio number instead of a gpio bank number.
>
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
Applied to 'fix'.
> ---
> --- clean-2.6.39-rc6/arch/arm/mach-pxa/mfp-pxa2xx.c ? ? 2011-03-15 01:20:32.000000000 +0000
> +++ linux-2.6.39-rc6/arch/arm/mach-pxa/mfp-pxa2xx.c ? ? 2011-05-08 02:09:36.706294235 +0100
> @@ -347,9 +347,9 @@ static int pxa2xx_mfp_suspend(struct sys
> ? ? ? ? ? ? ? ?if ((gpio_desc[i].config & MFP_LPM_KEEP_OUTPUT) &&
> ? ? ? ? ? ? ? ? ? ?(GPDR(i) & GPIO_bit(i))) {
> ? ? ? ? ? ? ? ? ? ? ? ?if (GPLR(i) & GPIO_bit(i))
> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? PGSR(i) |= GPIO_bit(i);
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? PGSR(gpio_to_bank(i)) |= GPIO_bit(i);
> ? ? ? ? ? ? ? ? ? ? ? ?else
> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? PGSR(i) &= ~GPIO_bit(i);
> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? PGSR(gpio_to_bank(i)) &= ~GPIO_bit(i);
> ? ? ? ? ? ? ? ?}
> ? ? ? ?}
>
>
>
prev parent reply other threads:[~2011-05-09 3:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-08 1:54 [PATCH] pxa: Fix PGSR register address calculation Paul Parsons
2011-05-09 3:48 ` Eric Miao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=N5YWeouh6U8sxByR9eAFmBiT8SA@mail.gmail.com' \
--to=eric.y.miao@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).