From: zajec5@gmail.com (Rafał Miłecki)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver
Date: Fri, 8 Apr 2011 21:46:19 +0200 [thread overview]
Message-ID: <BANLkTi=QwBOxfxy13PxeX+LRuccV_p06zA@mail.gmail.com> (raw)
In-Reply-To: <1302290881.1664.7.camel@Joe-Laptop>
2011/4/8 Joe Perches <joe@perches.com>:
> On Fri, 2011-04-08 at 21:45 +0200, Rafa? Mi?ecki wrote:
>> diff --git a/include/linux/axi/axi.h b/include/linux/axi/axi.h
> []
>> +#define axi_info ? ? pr_info
>> +#ifdef CONFIG_AXI_DEBUG
>> +#define axi_debug ? ?pr_debug
>> +#else
>> +#define axi_debug ? ?do { } while (0)
>> +#endif
>> +#define axi_err ? ? ? ? ? ? ?pr_err
>
> I think redefining standard functionality like
> this doesn't gain anything and loses some basic
> grep capability.
But on the other hand using:
pr_info, pr_err, BUT axi_debug
can easily lead to mistakes.
Or is this possible to re-define pr_debug locally?
--
Rafa?
next prev parent reply other threads:[~2011-04-08 19:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 19:45 [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver Rafał Miłecki
2011-04-08 19:28 ` Joe Perches
2011-04-08 19:46 ` Rafał Miłecki [this message]
2011-04-08 19:55 ` Joe Perches
2011-04-09 0:03 ` Rafał Miłecki
2011-04-09 0:07 ` Joe Perches
2011-04-08 20:00 ` Gábor Stefanik
2011-04-08 22:01 ` Greg KH
2011-04-08 23:46 ` Rafał Miłecki
2011-04-10 15:52 ` Rafał Miłecki
2011-04-10 16:20 ` Greg KH
2011-04-11 16:59 ` Arend van Spriel
2011-04-11 17:24 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=QwBOxfxy13PxeX+LRuccV_p06zA@mail.gmail.com' \
--to=zajec5@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).