From: festevam@gmail.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [BUGFIX][PATCH] fix the parent of i2c[12]_clk
Date: Fri, 1 Jul 2011 11:01:16 -0300 [thread overview]
Message-ID: <BANLkTi=hBamK2JE1KykAJQWiyrhC8qPB_g@mail.gmail.com> (raw)
In-Reply-To: <1309525326-4762-1-git-send-email-LW@KARO-electronics.de>
On Fri, Jul 1, 2011 at 10:02 AM, Lothar Wa?mann <LW@karo-electronics.de> wrote:
> The clock from which the I2C timing is derived is the ipg_perclk not ipg_clk.
>
> I2C bus frequency was too low by a factor of ~8 due to the clock divider
> calculation being based on 66.5MHz IPG clock while the bus actually
> uses 8MHz ipg_perclk.
>
> Kernel version: 3.0.0-rc2 branch 'imx-for-next' of git://git.pengutronix.de/git/imx/linux-2.6
>
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
> ---
> ?arch/arm/mach-mx5/clock-mx51-mx53.c | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
> index 699b0d2..fe977d0 100644
> --- a/arch/arm/mach-mx5/clock-mx51-mx53.c
> +++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
> @@ -1282,9 +1282,9 @@ DEFINE_CLOCK(pwm2_clk, 0, MXC_CCM_CCGR2, MXC_CCM_CCGRx_CG8_OFFSET,
>
> ?/* I2C */
> ?DEFINE_CLOCK(i2c1_clk, 0, MXC_CCM_CCGR1, MXC_CCM_CCGRx_CG9_OFFSET,
> - ? ? ? NULL, NULL, &ipg_clk, NULL);
> + ? ? ? NULL, NULL, &ipg_perclk, NULL);
> ?DEFINE_CLOCK(i2c2_clk, 1, MXC_CCM_CCGR1, MXC_CCM_CCGRx_CG10_OFFSET,
> - ? ? ? NULL, NULL, &ipg_clk, NULL);
> + ? ? ? NULL, NULL, &ipg_perclk, NULL);
> ?DEFINE_CLOCK(hsi2c_clk, 0, MXC_CCM_CCGR1, MXC_CCM_CCGRx_CG11_OFFSET,
> ? ? ? ?NULL, NULL, &ipg_clk, NULL);
> ?DEFINE_CLOCK(i2c3_mx53_clk, 0, MXC_CCM_CCGR1, MXC_CCM_CCGRx_CG11_OFFSET,
Shouldn't i2c3_mx53_clk have the same change applied?
Regards,
Fabio Estevam
next prev parent reply other threads:[~2011-07-01 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 13:02 [BUGFIX][PATCH] fix the parent of i2c[12]_clk Lothar Waßmann
2011-07-01 14:01 ` Fabio Estevam [this message]
2011-07-04 13:41 ` Lothar Waßmann
2011-07-04 13:52 ` [BUGFIX][PATCH] mach-mx5: fix the I2C clock parents Lothar Waßmann
2011-07-04 14:48 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=hBamK2JE1KykAJQWiyrhC8qPB_g@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).