linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: at91: AT91CAP9 has a macb device
@ 2011-04-19  8:21 Uwe Kleine-König
  2011-04-19 15:33 ` Andrew Victor
  2011-04-19 15:49 ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 2 replies; 5+ messages in thread
From: Uwe Kleine-König @ 2011-04-19  8:21 UTC (permalink / raw)
  To: linux-arm-kernel

commit

	ee621dd (net: atmel_macb Kconfig: remove long dependency line)

replaced a list of several explicit machines in the dependencies of MACB by
a single symbol that is selected by the respective machines. ee621dd missed
to let ARCH_AT91CAP9 select HAVE_NET_MACB though which is fixed here.

Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
 arch/arm/mach-at91/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index 1939023..2d299bf 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -83,6 +83,7 @@ config ARCH_AT91CAP9
 	select CPU_ARM926T
 	select GENERIC_CLOCKEVENTS
 	select HAVE_FB_ATMEL
+	select HAVE_NET_MACB
 
 config ARCH_AT572D940HF
 	bool "AT572D940HF"
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH] ARM: at91: AT91CAP9 has a macb device
  2011-04-19  8:21 [PATCH] ARM: at91: AT91CAP9 has a macb device Uwe Kleine-König
@ 2011-04-19 15:33 ` Andrew Victor
  2011-04-19 15:49 ` Jean-Christophe PLAGNIOL-VILLARD
  1 sibling, 0 replies; 5+ messages in thread
From: Andrew Victor @ 2011-04-19 15:33 UTC (permalink / raw)
  To: linux-arm-kernel

hi,

> commit
>
> ? ? ? ?ee621dd (net: atmel_macb Kconfig: remove long dependency line)
>
> replaced a list of several explicit machines in the dependencies of MACB by
> a single symbol that is selected by the respective machines. ee621dd missed
> to let ARCH_AT91CAP9 select HAVE_NET_MACB though which is fixed here.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Acked-by: Andrew Victor <linux@maxim.org.za>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: at91: AT91CAP9 has a macb device
  2011-04-19  8:21 [PATCH] ARM: at91: AT91CAP9 has a macb device Uwe Kleine-König
  2011-04-19 15:33 ` Andrew Victor
@ 2011-04-19 15:49 ` Jean-Christophe PLAGNIOL-VILLARD
  2011-04-19 18:40   ` Uwe Kleine-König
  1 sibling, 1 reply; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2011-04-19 15:49 UTC (permalink / raw)
  To: linux-arm-kernel

On 10:21 Tue 19 Apr     , Uwe Kleine-K?nig wrote:
> commit
> 
> 	ee621dd (net: atmel_macb Kconfig: remove long dependency line)
> 
> replaced a list of several explicit machines in the dependencies of MACB by
> a single symbol that is selected by the respective machines. ee621dd missed
> to let ARCH_AT91CAP9 select HAVE_NET_MACB though which is fixed here.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Best Regards,
J.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: at91: AT91CAP9 has a macb device
  2011-04-19 15:49 ` Jean-Christophe PLAGNIOL-VILLARD
@ 2011-04-19 18:40   ` Uwe Kleine-König
  2011-04-19 19:08     ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2011-04-19 18:40 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Apr 19, 2011 at 05:49:41PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 10:21 Tue 19 Apr     , Uwe Kleine-K?nig wrote:
> > commit
> > 
> > 	ee621dd (net: atmel_macb Kconfig: remove long dependency line)
> > 
> > replaced a list of several explicit machines in the dependencies of MACB by
> > a single symbol that is selected by the respective machines. ee621dd missed
> > to let ARCH_AT91CAP9 select HAVE_NET_MACB though which is fixed here.
> > 
> > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
I don't understand why you reply with a S-o-b. Does that mean you took
the patch somehow? If not, I think an Ack would be more appropriate.
With path should this patch go? Patch system?

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] ARM: at91: AT91CAP9 has a macb device
  2011-04-19 18:40   ` Uwe Kleine-König
@ 2011-04-19 19:08     ` Jean-Christophe PLAGNIOL-VILLARD
  0 siblings, 0 replies; 5+ messages in thread
From: Jean-Christophe PLAGNIOL-VILLARD @ 2011-04-19 19:08 UTC (permalink / raw)
  To: linux-arm-kernel

On 20:40 Tue 19 Apr     , Uwe Kleine-K?nig wrote:
> On Tue, Apr 19, 2011 at 05:49:41PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 10:21 Tue 19 Apr     , Uwe Kleine-K?nig wrote:
> > > commit
> > > 
> > > 	ee621dd (net: atmel_macb Kconfig: remove long dependency line)
> > > 
> > > replaced a list of several explicit machines in the dependencies of MACB by
> > > a single symbol that is selected by the respective machines. ee621dd missed
> > > to let ARCH_AT91CAP9 select HAVE_NET_MACB though which is fixed here.
> > > 
> > > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> I don't understand why you reply with a S-o-b. Does that mean you took
> the patch somehow? If not, I think an Ack would be more appropriate.
> With path should this patch go? Patch system?
I'll put it via our own tree
and send the pull request end of the week

with other fix

Best Regards,
J.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-04-19 19:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-19  8:21 [PATCH] ARM: at91: AT91CAP9 has a macb device Uwe Kleine-König
2011-04-19 15:33 ` Andrew Victor
2011-04-19 15:49 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-19 18:40   ` Uwe Kleine-König
2011-04-19 19:08     ` Jean-Christophe PLAGNIOL-VILLARD

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).