From: shweta.gulati@ti.com (Gulati, Shweta)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4] OMAP3+: SR Layer Cleanup
Date: Mon, 23 May 2011 10:10:53 +0530 [thread overview]
Message-ID: <BANLkTi=ufSmtnEkyRFKOpbTAJkcUW1dXYg@mail.gmail.com> (raw)
In-Reply-To: <4DD67155.1030705@ti.com>
Benoit,
On Fri, May 20, 2011 at 7:19 PM, Cousson, Benoit <b-cousson@ti.com> wrote:
> Hi Shweta,
>
> On 5/13/2011 8:27 AM, Gulati, Shweta wrote:
>>
>> To set sr ntarget values ?for all volt_domain,
>> volt_table is retrieved by doing a look_up of 'vdd_name'
>> field from omap_hwmod but voltage domain pointer does not
>> belong to omap_hwmod and is not used anywhere else.
>> As a part of voltage layer and SR Layer clean up volt
>> pointer is removed from omap_hwmod and added in dev
>> attributes of SR.
>>
>> Tested on OMAP3630 SDP and OMAP4430 SDP Board
>>
>> Signed-off-by: Shweta Gulati<shweta.gulati@ti.com>
>> Acked by: Nishanth Menon<nm@ti.com>
>> Cc: Benoit Cousson<b-cousson@ti.com>
>> Cc: Paul Walmsley<paul@pwsan.com>
>> ---
>>
>> V4:
>> ? Fixed comments like checking for NULL pointers
>> ? and following conventions in naming the instances
>> ? recommended by Todd Poynor and Benoit Cousson.
>
> It looks like you missed at least two comments I did on the previous version
> whereas you did agree to fix them.
You told me to move smartrefex_xxxx_dev_attr above
omap44xx_smartreflex_XXX_hwmod struct,
which is already in that order and the other thing you suggested was
to move .dev_attr before .slaves,
that I have not done explaining that, to follow the standard as in all
defined hwmod struct .dev_attr are placed after .slaves.
> Thanks,
> Benoit
>
--
Thanks,
Regards,
Shweta
next prev parent reply other threads:[~2011-05-23 4:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 6:27 [PATCH V4] OMAP3+: SR Layer Cleanup Shweta Gulati
2011-05-19 8:59 ` Kevin Hilman
2011-05-19 9:39 ` Gulati, Shweta
2011-05-20 13:23 ` Menon, Nishanth
2011-05-20 13:49 ` Cousson, Benoit
2011-05-23 4:40 ` Gulati, Shweta [this message]
2011-05-24 11:52 ` Cousson, Benoit
2011-05-25 6:39 ` Gulati, Shweta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=ufSmtnEkyRFKOpbTAJkcUW1dXYg@mail.gmail.com' \
--to=shweta.gulati@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).